| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6f0ed829-5b70-3642-ab36-f30c76d95e92 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C502:3AC44A:10B9B9:15F8A7:697E54ED |
| html-safe-nonce | 13024d4658a0c6dfa983534841ab7f5e4b7a3f3486d2f67a6afaf52672ff91b2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTAyOjNBQzQ0QToxMEI5Qjk6MTVGOEE3OjY5N0U1NEVEIiwidmlzaXRvcl9pZCI6IjQ3ODc2MzI4NzMwNTYxMzAyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e5b3628e42d9e187ae6c45d98a775508999c961a62fc88da77508d92a87536dd |
| hovercard-subject-tag | pull_request:420682769 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/720/files |
| twitter:image | https://avatars.githubusercontent.com/u/15938899?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15938899?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
Expand SDKs Test Coverage:
Added unit test to test client.go in Go SDK
Added unit test to test FeastClient in Java SDK.
Expanded unit test for Client.get_online... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/720/changes#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F720%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F720%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/720/changes |
| Reload | https://github.com/feast-dev/feast/pull/720/changes |
| Reload | https://github.com/feast-dev/feast/pull/720/changes |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
183
| https://github.com/feast-dev/feast/issues |
|
Pull requests
68
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
|
Conversation
17
| https://github.com/feast-dev/feast/pull/720 |
|
Commits
13
| https://github.com/feast-dev/feast/pull/720/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/720/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/720/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/720/changes |
|
Expand Go and Java SDK Test Coverage
| https://github.com/feast-dev/feast/pull/720/changes#top |
|
Show all changes
13 commits
| https://github.com/feast-dev/feast/pull/720/files |
|
fe65b02
Added TestGetOnlineFeatures() client_test to test client.GetOnlineFea…
May 20, 2020
| https://github.com/feast-dev/feast/pull/720/commits/fe65b02a5d18da3e244da65b78bd89dfe0673df6 |
|
20bcddd
Added unit test for Java SDK's FeastClient
May 20, 2020
| https://github.com/feast-dev/feast/pull/720/commits/20bcddde3f65aef1a67d7cfa767b63560f738135 |
|
21f41c9
Make Python SDK's client.get_online_features() unit test more compre…
May 20, 2020
| https://github.com/feast-dev/feast/pull/720/commits/21f41c9513ccb297b3a3cba858f88a0216bd2d6e |
|
1e36044
Remove code added to debug the Python SDK tests
May 21, 2020
| https://github.com/feast-dev/feast/pull/720/commits/1e3604421d197ef111758dc177a0353a7a335d05 |
|
e414a2d
Change repo referenced in go.mod to mrzzy fork to test modules retrieval
May 21, 2020
| https://github.com/feast-dev/feast/pull/720/commits/e414a2d4671f6d2e3b9148aa42aac124e4cfd8d9 |
|
b2a7ebc
Fix python sdk lint
May 21, 2020
| https://github.com/feast-dev/feast/pull/720/commits/b2a7ebc4eeb5303420cae77b64f905b9927bc7da |
|
564f5fe
Revert "Change repo referenced in go.mod to mrzzy fork to test module…
May 21, 2020
| https://github.com/feast-dev/feast/pull/720/commits/564f5fe425d0aa8adaab627aed408a4412d34860 |
|
9ad2f2e
Optmisation: Init stripFields map to expected size in client.GetOnlin…
May 21, 2020
| https://github.com/feast-dev/feast/pull/720/commits/9ad2f2e2bfdaede1348b3e0f60b70475905e90f7 |
|
d799830
Make the name of the client test case more descriptive
May 21, 2020
| https://github.com/feast-dev/feast/pull/720/commits/d7998303b0ef3f7815e1e71b519526d2f7935c1b |
|
eeeaced
Add missing mock files
mrzzy May 22, 2020
| https://github.com/feast-dev/feast/pull/720/commits/eeeaceda7199035aab5e01464443000832b5f7e2 |
|
adc60f2
Fix rebase markers in project root go mod
mrzzy Jun 1, 2020
| https://github.com/feast-dev/feast/pull/720/commits/adc60f23d9e065cfbb6cf9aed38c421ea327dc66 |
|
f1a79f4
Fix compilation issue cause by downgrade to java 8
mrzzy Jun 1, 2020
| https://github.com/feast-dev/feast/pull/720/commits/f1a79f4bb1fc06f4e19fa670bdae1e1e026cf890 |
|
6f109ed
Revert row count in python SDK client test to 300
mrzzy Jun 5, 2020
| https://github.com/feast-dev/feast/pull/720/commits/6f109ed80133404fa5baf0610321268e5a0a8a00 |
|
Clear filters
| https://github.com/feast-dev/feast/pull/720/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/720/changes |
| Please reload this page | https://github.com/feast-dev/feast/pull/720/changes |
|
go.mod
| https://github.com/feast-dev/feast/pull/720/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
go.sum
| https://github.com/feast-dev/feast/pull/720/changes#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
client.go
| https://github.com/feast-dev/feast/pull/720/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca |
|
client_test.go
| https://github.com/feast-dev/feast/pull/720/changes#diff-3bab379acb41abd86e1ed861f5a3b851da0d48f0bbd453755046e933ac82123c |
|
go.mod
| https://github.com/feast-dev/feast/pull/720/changes#diff-b7089e2df76d00d51e6baedff04babe6d834a3a86837770fca0cba95041b0ad0 |
|
go.sum
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
serving_mock.go
| https://github.com/feast-dev/feast/pull/720/changes#diff-12aabc1bb1db9c622528a0ec241da0bd2f24b5738935f24f66024c35a52c9b2b |
|
pom.xml
| https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
|
FeastClientTest.java
| https://github.com/feast-dev/feast/pull/720/changes#diff-278f25d331cb8d3946e8a3abd5dda54449414365d223827b717bbc1cef3612b3 |
|
client.py
| https://github.com/feast-dev/feast/pull/720/changes#diff-d952d6ada8564fd279b430907894ccfda698bb52eed90846d3aa04c4c9bc4379 |
|
test_client.py
| https://github.com/feast-dev/feast/pull/720/changes#diff-dd9aaf4113915b368515057d8c42402d3ba8ed6614985497d58887982304e3ca |
| go.mod | https://github.com/feast-dev/feast/pull/720/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/go.mod |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
| go.sum | https://github.com/feast-dev/feast/pull/720/changes#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/go.sum |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/go/client.go | https://github.com/feast-dev/feast/pull/720/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/sdk/go/client.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/go/client_test.go | https://github.com/feast-dev/feast/pull/720/changes#diff-3bab379acb41abd86e1ed861f5a3b851da0d48f0bbd453755046e933ac82123c |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/sdk/go/client_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/go/go.mod | https://github.com/feast-dev/feast/pull/720/changes#diff-b7089e2df76d00d51e6baedff04babe6d834a3a86837770fca0cba95041b0ad0 |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/sdk/go/go.mod |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-b7089e2df76d00d51e6baedff04babe6d834a3a86837770fca0cba95041b0ad0 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-b7089e2df76d00d51e6baedff04babe6d834a3a86837770fca0cba95041b0ad0 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/go/go.sum | https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/sdk/go/go.sum |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-d554ca9fc1e05419651c283e921b2b72d578b5385ed5d0fb44097ba4b672a302 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/go/mocks/serving_mock.go | https://github.com/feast-dev/feast/pull/720/changes#diff-12aabc1bb1db9c622528a0ec241da0bd2f24b5738935f24f66024c35a52c9b2b |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/sdk/go/mocks/serving_mock.go |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/feast-dev/feast/pull/720/changes |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/java/pom.xml | https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
|
View file
| https://github.com/feast-dev/feast/blob/6f109ed80133404fa5baf0610321268e5a0a8a00/sdk/java/pom.xml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/720/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
|
| https://github.com/feast-dev/feast/pull/720/changes#diff-8a62ac77e0872435b1a68c30c20af6127af4f2288794404e8ab23abc8d40cb13 |
| Please reload this page | https://github.com/feast-dev/feast/pull/720/changes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |