René's URL Explorer Experiment


Title: fix: Ingest ZonedTimestamp columns from Arrow with their zone by Nikhi00718 · Pull Request #7162 · feast-dev/feast · GitHub

Open Graph Title: fix: Ingest ZonedTimestamp columns from Arrow with their zone by Nikhi00718 · Pull Request #7162 · feast-dev/feast

X Title: fix: Ingest ZonedTimestamp columns from Arrow with their zone by Nikhi00718 · Pull Request #7162 · feast-dev/feast

Description: What this PR does / why we need it: A ZonedTimestamp feature can't be loaded into the online store from a DataFrame or a batch source. store.write_to_online_store(...) and feast materialize both fail, for any zone, including a plain UTC column: TypeError: ZONED_TIMESTAMP expects datetime values, got _columns_to_proto_values (utils.py) converts each Arrow column with to_numpy(zero_copy_only=False) before python_values_to_proto_values. For a timestamp column that yields tz-less numpy.datetime64 values, and the ZONED_TIMESTAMP branch only accepts datetime. The existing tests call python_values_to_proto_values with datetime objects directly, so the Arrow path was never exercised. Changes: _columns_to_proto_values converts a ZONED_TIMESTAMP column with to_pylist(), which returns tz-aware datetimes in the column's zone. Other types still go through to_numpy(). _zone_name stores a fixed offset that it can't name as UTC+05:30. pyarrow returns pytz.FixedOffset(330) for an offset-zoned column (for example one parsed from 2026-06-17T09:00:00-07:00), and its str(), "pytz.FixedOffset(330)", was stored as the zone and decoded back as UTC with a "Could not resolve zone" warning. Names that already resolve (IANA keys such as America/Los_Angeles, UTC-07:00) are stored as before. A zone-less Arrow timestamp column is stored with zone="" and read back as UTC, the same rule as a naive datetime. A pandas object column that mixes offsets is still converted to a single Arrow zone by pyarrow before Feast sees it. Which issue(s) this PR fixes: None filed. Follow-up to #6537, which added the type (#6536). Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change End to end, on master 108c96704: a FileSource Parquet file and the same DataFrame, ZonedTimestamp feature, SQLite online store, read back with get_online_features: Column Before (write_to_online_store / materialize) After datetime64[ns, UTC] TypeError / TypeError same instants, +00:00 ZoneInfo("America/Los_Angeles"), June and December TypeError / TypeError 09:00 -07:00 and 09:00 -08:00 fixed +05:30 TypeError / TypeError 09:00 +05:30 pd.to_datetime of -07:00 ISO strings TypeError / TypeError 09:00 and 10:00 -07:00 New tests in TestZonedTimestamp (test_type_map.py): an Arrow column with an IANA zone and a null, one built from a pandas column with a fixed offset, a zone-less column, and a pytz.FixedOffset value. All 4 fail before the change and pass after. On Linux (Python 3.11, pyarrow 26, pandas 2.3), test_type_map.py, online_store/test_online_writes.py, test_vector_length_validation.py and test_feature_server_utils.py: 470 passed, 1 skipped, and 29 failed in TestSparkNativeTypeValidation because pyspark isn't installed in my environment. On master the same run has those 29 plus the 4 new tests failing. ruff check, ruff format --check and mypy pass on the changed files. Misc Related, not changed here: a DataFrame column of uuid.UUID objects fails the same way for Uuid/TimeUuid with pyarrow 26.0.1, since pyarrow infers its uuid extension type and to_numpy() returns 16-byte bytes. String UUIDs work. I can send that separately if it's wanted.

Open Graph Description: What this PR does / why we need it: A ZonedTimestamp feature can't be loaded into the online store from a DataFrame or a batch source. store.write_to_online_store(...) and feast materialize bot...

X Description: What this PR does / why we need it: A ZonedTimestamp feature can't be loaded into the online store from a DataFrame or a batch source. store.write_to_online_store(...) and feast materialize...

Opengraph URL: https://github.com/feast-dev/feast/pull/7162

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6079962a-a6fb-12fd-7a73-a43fa3c66a33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1C6:61466:10BFB62:1700032:6AFEA26A
html-safe-noncead295aaf4f0d2ed7e3c441b7452ed0c1cfad98f041b76684f1536bd1dbf1e2e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUM2OjYxNDY2OjEwQkZCNjI6MTcwMDAzMjo2QUZFQTI2QSIsInZpc2l0b3JfaWQiOiI3NjI4OTI4MjIyNDMxNzE1OTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace744e34b827a39a193d791618eb2e2dbd7d1cdaf707da9ae317865e591457375
hovercard-subject-tagpull_request:5315303827
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7162/files
twitter:imagehttps://avatars.githubusercontent.com/u/177048619?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/177048619?s=400&v=4
og:image:altWhat this PR does / why we need it: A ZonedTimestamp feature can't be loaded into the online store from a DataFrame or a batch source. store.write_to_online_store(...) and feast materialize bot...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7162/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7162%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7162%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7162/files
Reloadhttps://github.com/feast-dev/feast/pull/7162/files
Reloadhttps://github.com/feast-dev/feast/pull/7162/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Nikhi00718:fix/zoned-timestamp-arrow-ingesthttps://github.com/Nikhi00718/feast/tree/fix/zoned-timestamp-arrow-ingest
Conversation 2 https://github.com/feast-dev/feast/pull/7162
Commits 1 https://github.com/feast-dev/feast/pull/7162/commits
Checks 23 https://github.com/feast-dev/feast/pull/7162/checks
Files changed https://github.com/feast-dev/feast/pull/7162/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7162/files
fix: Ingest ZonedTimestamp columns from Arrow with their zone https://github.com/feast-dev/feast/pull/7162/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/7162/files
71aba21 fix: Ingest ZonedTimestamp columns from Arrow with their zone Nikhi00718 Nov 14, 2026 https://github.com/feast-dev/feast/pull/7162/commits/71aba2145171a7e0de63e5e244e0999c46b7a1ca
Clear filters https://github.com/feast-dev/feast/pull/7162/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7162/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7162/files
type_map.py https://github.com/feast-dev/feast/pull/7162/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
utils.py https://github.com/feast-dev/feast/pull/7162/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_type_map.py https://github.com/feast-dev/feast/pull/7162/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/type_map.pyhttps://github.com/feast-dev/feast/pull/7162/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
View file https://github.com/Nikhi00718/feast/blob/71aba2145171a7e0de63e5e244e0999c46b7a1ca/sdk/python/feast/type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7162/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7162/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/pull/7162/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/7162/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/Nikhi00718/feast/blob/71aba2145171a7e0de63e5e244e0999c46b7a1ca/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7162/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7162/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/7162/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_type_map.pyhttps://github.com/feast-dev/feast/pull/7162/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
View file https://github.com/Nikhi00718/feast/blob/71aba2145171a7e0de63e5e244e0999c46b7a1ca/sdk/python/tests/unit/test_type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7162/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7162/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/pull/7162/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
Please reload this pagehttps://github.com/feast-dev/feast/pull/7162/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.