René's URL Explorer Experiment


Title: feat: Add BM25 field tags to the Milvus online store by jiwidi · Pull Request #7144 · feast-dev/feast · GitHub

Open Graph Title: feat: Add BM25 field tags to the Milvus online store by jiwidi · Pull Request #7144 · feast-dev/feast

X Title: feat: Add BM25 field tags to the Milvus online store by jiwidi · Pull Request #7144 · feast-dev/feast

Description: What this PR does / why we need it: Builds on #7143, which adds text analysis tags. A String feature can now declare a BM25 index, which Feast creates with the collection: Field( name="title", dtype=String, tags={ "milvus.bm25": "true", "milvus.bm25_index_params": '{"inverted_index_algo": "TAAT_NAIVE", "bm25_b": 0.3}', }, ), milvus.bm25: "true" adds a SPARSE_FLOAT_VECTOR field _bm25, a BM25 function _bm25_fn and a SPARSE_INVERTED_INDEX bm25_index_. Names are derived from the field, as for scalar_index_ and vector_index_. milvus.bm25_index_params passes a JSON object of build parameters to that index. Writes leave _bm25 to Milvus: PyMilvus rejects rows that carry a function output. A view whose only vector is a BM25 output gets no _placeholder_vector. A feature named like a BM25 output is rejected (PyMilvus accepts duplicate field names). Retrieval change: retrieve_online_documents_v2 now names the only dense vector field even when it is not a requested feature. Before, Feast passed no anns_field and Milvus inferred it, which fails with "multiple anns_fields exist" once the collection also has a BM25 output. No behaviour change for collections without one. Feast does not search the BM25 output yet; clients that query Milvus directly can. A follow-up can add BM25 and hybrid search to retrieve_online_documents_v2. An existing collection without the output is reported by the existing schema check, and one without the index by the missing-index warning. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit: the created output, function, index and build params; no placeholder; validation; writes and re-writes through a fresh store on Milvus Lite (fails without the write change); the named anns_field (fails without the retrieval change). Integration (test_milvus_remote.py, against Milvus 2.5.27, 2.6.27 and 3.0.2): the server stores the index params, writes succeed, and a BM25 search on _bm25 finds the row. Milvus Lite does not reproduce the anns_field ambiguity, so the unit test checks the argument Feast passes. Misc Stacked on #7143, whose commit is included here until it merges; review the last commit. Written with @jonasfagerlund, who is a co-author of the commit.

Open Graph Description: What this PR does / why we need it: Builds on #7143, which adds text analysis tags. A String feature can now declare a BM25 index, which Feast creates with the collection: Field( name="tit...

X Description: What this PR does / why we need it: Builds on #7143, which adds text analysis tags. A String feature can now declare a BM25 index, which Feast creates with the collection: Field( name=&quot...

Opengraph URL: https://github.com/feast-dev/feast/pull/7144

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:adef0f3e-b062-22d8-ba08-fc48d8200e4c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAAA:F9808:F49DBC:1424D9C:6AFE98B3
html-safe-noncec5de4a11b0bbdf5b77a5d9f1bfeb7b708c6ea4119c24c86a3ace8db1d95ecf01
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUFBOkY5ODA4OkY0OURCQzoxNDI0RDlDOjZBRkU5OEIzIiwidmlzaXRvcl9pZCI6IjMwMDc5NDU3OTAyNDE4MDY1MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf1795d9b3ce3d0caedcc041b67c26a6c76a53ff39b4ea3cf1d8099fa71e4d6be
hovercard-subject-tagpull_request:5280070406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7144/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: Builds on #7143, which adds text analysis tags. A String feature can now declare a BM25 index, which Feast creates with the collection: Field( name="tit...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7144/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7144%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7144%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7144/files
Reloadhttps://github.com/feast-dev/feast/pull/7144/files
Reloadhttps://github.com/feast-dev/feast/pull/7144/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:feat/milvus-bm25-tagshttps://github.com/jiwidi/feast/tree/feat/milvus-bm25-tags
Conversation 1 https://github.com/feast-dev/feast/pull/7144
Commits 3 https://github.com/feast-dev/feast/pull/7144/commits
Checks 23 https://github.com/feast-dev/feast/pull/7144/checks
Files changed https://github.com/feast-dev/feast/pull/7144/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7144/files
feat: Add BM25 field tags to the Milvus online store https://github.com/feast-dev/feast/pull/7144/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/7144/files
129cfbe feat: Add text analysis tags to the Milvus online store jiwidi Nov 12, 2026 https://github.com/feast-dev/feast/pull/7144/commits/129cfbe0d7e6453b4b3979ccfd4b81c766b16500
073d0e1 feat: Add BM25 field tags to the Milvus online store jiwidi Nov 12, 2026 https://github.com/feast-dev/feast/pull/7144/commits/073d0e13233716dc97f50cadf16d324643b15ed3
288c05e ci: Rerun the macOS unit tests jiwidi Nov 13, 2026 https://github.com/feast-dev/feast/pull/7144/commits/288c05ef85465aa7cdef30dc251df0c4a2d2c85f
Clear filters https://github.com/feast-dev/feast/pull/7144/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7144/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7144/files
milvus.md https://github.com/feast-dev/feast/pull/7144/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
milvus.py https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_remote.py https://github.com/feast-dev/feast/pull/7144/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/7144/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/milvus.mdhttps://github.com/feast-dev/feast/pull/7144/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
View file https://github.com/jiwidi/feast/blob/288c05ef85465aa7cdef30dc251df0c4a2d2c85f/docs/reference/online-stores/milvus.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7144/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7144/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7144/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.pyhttps://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
View file https://github.com/jiwidi/feast/blob/288c05ef85465aa7cdef30dc251df0c4a2d2c85f/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7144/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7144/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/online_store/test_milvus_remote.pyhttps://github.com/feast-dev/feast/pull/7144/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
View file https://github.com/jiwidi/feast/blob/288c05ef85465aa7cdef30dc251df0c4a2d2c85f/sdk/python/tests/integration/online_store/test_milvus_remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7144/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7144/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
https://github.com/feast-dev/feast/pull/7144/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
https://github.com/feast-dev/feast/pull/7144/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
Please reload this pagehttps://github.com/feast-dev/feast/pull/7144/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7144/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.