Title: feat: Add text analysis tags to the Milvus online store by jiwidi · Pull Request #7143 · feast-dev/feast · GitHub
Open Graph Title: feat: Add text analysis tags to the Milvus online store by jiwidi · Pull Request #7143 · feast-dev/feast
X Title: feat: Add text analysis tags to the Milvus online store by jiwidi · Pull Request #7143 · feast-dev/feast
Description: What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares scalar indexes (#7120): Field( name="title", dtype=String, tags={ "milvus.analyzer_params": '{"tokenizer": "whitespace"}', "milvus.enable_match": "true", }, ), milvus.analyzer_params: JSON object with the field's analyzer. Turns on enable_analyzer. milvus.enable_match: "true" builds the token index that Milvus TEXT_MATCH filters need. Both apply only to String features and need Milvus 2.5 or later. Feast does not query the tokens: Feast filters have no TEXT_MATCH operator and retrieve_online_documents_v2 still filters a query_string with LIKE. Clients that query the collection directly can use them. A follow-up will add BM25 field tags on top of the analyzer. Like the other creation-time tags, the settings apply only when Feast creates a collection. Unlike them, Feast does not compare them with an existing collection or warn when they differ. _nullable_tag becomes _boolean_tag(field, tag) so both boolean tags share one parser and error message. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit: the created schema per tag combination, and validation (non-String feature, invalid boolean, analyzer JSON that is not an object). Integration (test_milvus_remote.py, against Milvus 2.5.27, 2.6.27 and 3.0.2): a whitespace analyzer keeps wool-blend as one token, so TEXT_MATCH finds wool-blend and not wool. Milvus Lite accepts both tags but does not apply them (its TEXT_MATCH always uses the standard analyzer), so only the server tests cover the behaviour. Misc Milvus 2.6 makes new rows visible to TEXT_MATCH about 2 seconds after the write, even with Strong consistency, so the integration test retries that query. Written with @jonasfagerlund, who is a co-author of the commit. A BM25 PR builds on this one.
Open Graph Description: What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares s...
X Description: What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares s...
Opengraph URL: https://github.com/feast-dev/feast/pull/7143
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:213823f1-53b2-ed57-048f-e10bdc4ce22a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8BF8:1325C0:E54B81:12E6F14:6AFE9565 |
| html-safe-nonce | c9829fb4f750d08fcacd7164c84fd92f89e09d86c32609c9d0db9d6d54e0eee6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkY4OjEzMjVDMDpFNTRCODE6MTJFNkYxNDo2QUZFOTU2NSIsInZpc2l0b3JfaWQiOiI1NDkwODkyNzEyMjA4OTMwMTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 970bd261ca9f427f038aa15f1dfbb3a99add86d64dcfa0fcbb57cd4d2a3692b2 |
| hovercard-subject-tag | pull_request:5280066980 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7143/files |
| twitter:image | https://avatars.githubusercontent.com/u/10882086?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10882086?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width