René's URL Explorer Experiment


Title: feat: Add text analysis tags to the Milvus online store by jiwidi · Pull Request #7143 · feast-dev/feast · GitHub

Open Graph Title: feat: Add text analysis tags to the Milvus online store by jiwidi · Pull Request #7143 · feast-dev/feast

X Title: feat: Add text analysis tags to the Milvus online store by jiwidi · Pull Request #7143 · feast-dev/feast

Description: What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares scalar indexes (#7120): Field( name="title", dtype=String, tags={ "milvus.analyzer_params": '{"tokenizer": "whitespace"}', "milvus.enable_match": "true", }, ), milvus.analyzer_params: JSON object with the field's analyzer. Turns on enable_analyzer. milvus.enable_match: "true" builds the token index that Milvus TEXT_MATCH filters need. Both apply only to String features and need Milvus 2.5 or later. Feast does not query the tokens: Feast filters have no TEXT_MATCH operator and retrieve_online_documents_v2 still filters a query_string with LIKE. Clients that query the collection directly can use them. A follow-up will add BM25 field tags on top of the analyzer. Like the other creation-time tags, the settings apply only when Feast creates a collection. Unlike them, Feast does not compare them with an existing collection or warn when they differ. _nullable_tag becomes _boolean_tag(field, tag) so both boolean tags share one parser and error message. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit: the created schema per tag combination, and validation (non-String feature, invalid boolean, analyzer JSON that is not an object). Integration (test_milvus_remote.py, against Milvus 2.5.27, 2.6.27 and 3.0.2): a whitespace analyzer keeps wool-blend as one token, so TEXT_MATCH finds wool-blend and not wool. Milvus Lite accepts both tags but does not apply them (its TEXT_MATCH always uses the standard analyzer), so only the server tests cover the behaviour. Misc Milvus 2.6 makes new rows visible to TEXT_MATCH about 2 seconds after the write, even with Strong consistency, so the integration test retries that query. Written with @jonasfagerlund, who is a co-author of the commit. A BM25 PR builds on this one.

Open Graph Description: What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares s...

X Description: What this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares s...

Opengraph URL: https://github.com/feast-dev/feast/pull/7143

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:213823f1-53b2-ed57-048f-e10bdc4ce22a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BF8:1325C0:E54B81:12E6F14:6AFE9565
html-safe-noncec9829fb4f750d08fcacd7164c84fd92f89e09d86c32609c9d0db9d6d54e0eee6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkY4OjEzMjVDMDpFNTRCODE6MTJFNkYxNDo2QUZFOTU2NSIsInZpc2l0b3JfaWQiOiI1NDkwODkyNzEyMjA4OTMwMTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac970bd261ca9f427f038aa15f1dfbb3a99add86d64dcfa0fcbb57cd4d2a3692b2
hovercard-subject-tagpull_request:5280066980
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7143/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: Adds two field tags so the Milvus online store can set up text analysis on a String feature when it creates a collection, in the same way milvus.index declares s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7143/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7143%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7143%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7143/files
Reloadhttps://github.com/feast-dev/feast/pull/7143/files
Reloadhttps://github.com/feast-dev/feast/pull/7143/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
jiwidihttps://github.com/jiwidi
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:feat/milvus-text-analysis-tagshttps://github.com/jiwidi/feast/tree/feat/milvus-text-analysis-tags
Conversation 3 https://github.com/feast-dev/feast/pull/7143
Commits 2 https://github.com/feast-dev/feast/pull/7143/commits
Checks 15 https://github.com/feast-dev/feast/pull/7143/checks
Files changed https://github.com/feast-dev/feast/pull/7143/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7143/files
feat: Add text analysis tags to the Milvus online store https://github.com/feast-dev/feast/pull/7143/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7143/files
e6d4fdb feat: Add text analysis tags to the Milvus online store jiwidi Nov 12, 2026 https://github.com/feast-dev/feast/pull/7143/commits/e6d4fdb07fb0f59eed22e2092eb435a941e9cd69
756c2f2 Merge remote-tracking branch 'upstream/master' into feat/milvus-text-… jiwidi Nov 13, 2026 https://github.com/feast-dev/feast/pull/7143/commits/756c2f22835d2ba3d7a92aa677c9bad77362e93d
Clear filters https://github.com/feast-dev/feast/pull/7143/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7143/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7143/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.