René's URL Explorer Experiment


Title: feat: Batch DynamoDB online reads across feature views by NopeCharon · Pull Request #7134 · feast-dev/feast · GitHub

Open Graph Title: feat: Batch DynamoDB online reads across feature views by NopeCharon · Pull Request #7134 · feast-dev/feast

X Title: feat: Batch DynamoDB online reads across feature views by NopeCharon · Pull Request #7134 · feast-dev/feast

Description: What this PR does / why we need it: The generic OnlineStore._read_features_per_fv loop reads one feature view after another. For DynamoDB that means a sync get_online_features call spanning N feature views costs at least N sequential BatchGetItem round trips, and the async path sends at least N separate requests. Redis and PostgreSQL already override this seam to batch. This PR does the same for DynamoDB, as discussed in #3259, where per-store overrides were agreed as the approach. DynamoDB keeps each feature view in its own table, and one BatchGetItem request can read from several tables. The override: resolves every view's table name (versioning included) and entity ids up front; packs all of the keys into as few requests as possible, with at most batch_size keys per request across all of its tables. Each table keeps its own ProjectionExpression and ConsistentRead; sends the requests in parallel: a thread pool capped at max_read_workers on the sync path, asyncio.gather on the async path; splits the returned items back apart by table and entity id, and fills the response in grouped_refs order. For example, a request for 10 feature views and 5 entities now needs 1 BatchGetItem call instead of 10. BatchGetItem rejects a request that lists the same key twice for a table. So views that map to the same table, such as one feature view requested under two aliases, are read once, projecting the union of their requested features. Extra features in a row are already ignored when the response is filled. The gating follows the PostgreSQL implementation (#6832): A single-view request always takes the generic path, because there is nothing to combine. Requests larger than the new max_batched_result_rows setting (entity rows × feature views, default 2048) also take the generic path. At that size each view already fills requests of its own, so packing saves at most one partly filled request per view, while holding every view's items at once raises peak memory. Setting max_batched_result_rows: 0 turns batching off. Error and throttling behaviour does not change: any exception from batch_get_item still propagates, and UnprocessedKeys are handled the same way as in the per-view path. The item decoding in _process_batch_get_response moves into a shared _to_read_row helper, so both paths parse items the same way. Docs: the DynamoDB online store reference (new option plus a performance note) and the online server performance tuning guide. Which issue(s) this PR fixes: Refs #3259 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New tests are in sdk/python/tests/unit/infra/online_store/test_dynamodb_batched_read.py. They run against moto-backed tables, and each one covers both the sync and the async override: One request serves three views (two of them share an entity id and a feature name, and the third is keyed on a different entity), and the response matches the generic per-view path exactly, including entities that are missing from one view. Keys are packed across tables up to batch_size. Aliases of one view read each key once, with the union projection. Projection is set per table. A single view, max_batched_result_rows: 0, or a request over the limit falls back to one online_read per view. Config default and validation. The existing DynamoDB unit tests still pass. Misc Release note: The DynamoDB online store now packs the reads of every feature view in a request into shared BatchGetItem calls, so requests that span several feature views need fewer round trips. The new max_batched_result_rows option controls this.

Open Graph Description: What this PR does / why we need it: The generic OnlineStore._read_features_per_fv loop reads one feature view after another. For DynamoDB that means a sync get_online_features call spanning N featu...

X Description: What this PR does / why we need it: The generic OnlineStore._read_features_per_fv loop reads one feature view after another. For DynamoDB that means a sync get_online_features call spanning N featu...

Opengraph URL: https://github.com/feast-dev/feast/pull/7134

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:36e30d3d-7434-b304-5b5a-426804fa9390
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8654:3FDE19:31B725:4265D4:6AFE988D
html-safe-nonceb61055728103f52735b9f7dffaa6da41c0ee7625c27573b088685d7d8c2d3ad3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjU0OjNGREUxOTozMUI3MjU6NDI2NUQ0OjZBRkU5ODhEIiwidmlzaXRvcl9pZCI6IjEwMzkzNzMzMzQyODM3MjA4NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbd7305e970bfe644637e7114cefa361ef3eed864aefaf31328e23ff339443f66
hovercard-subject-tagpull_request:5263804844
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7134/files
twitter:imagehttps://avatars.githubusercontent.com/u/115794254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/115794254?s=400&v=4
og:image:altWhat this PR does / why we need it: The generic OnlineStore._read_features_per_fv loop reads one feature view after another. For DynamoDB that means a sync get_online_features call spanning N featu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7134/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7134%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7134%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7134/files
Reloadhttps://github.com/feast-dev/feast/pull/7134/files
Reloadhttps://github.com/feast-dev/feast/pull/7134/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
NopeCharon:feat/dynamodb-batched-online-readhttps://github.com/NopeCharon/feast/tree/feat/dynamodb-batched-online-read
Conversation 1 https://github.com/feast-dev/feast/pull/7134
Commits 1 https://github.com/feast-dev/feast/pull/7134/commits
Checks 23 https://github.com/feast-dev/feast/pull/7134/checks
Files changed https://github.com/feast-dev/feast/pull/7134/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7134/files
feat: Batch DynamoDB online reads across feature views https://github.com/feast-dev/feast/pull/7134/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/7134/files
51b75b5 feat: Batch DynamoDB online reads across feature views NopeCharon Nov 11, 2026 https://github.com/feast-dev/feast/pull/7134/commits/51b75b53ffbcf2eb823ff6b411f1af85f6ae0a55
Clear filters https://github.com/feast-dev/feast/pull/7134/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7134/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7134/files
online-server-performance-tuning.md https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
dynamodb.md https://github.com/feast-dev/feast/pull/7134/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
dynamodb.py https://github.com/feast-dev/feast/pull/7134/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
test_dynamodb_batched_read.py https://github.com/feast-dev/feast/pull/7134/files#diff-b91df8b097cc51ac380745f4cce2ed0aac7ad264c5b0352db510dab8f0efb9a1
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/online-server-performance-tuning.mdhttps://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
View file https://github.com/NopeCharon/feast/blob/51b75b53ffbcf2eb823ff6b411f1af85f6ae0a55/docs/how-to-guides/online-server-performance-tuning.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7134/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7134/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/dynamodb.mdhttps://github.com/feast-dev/feast/pull/7134/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
View file https://github.com/NopeCharon/feast/blob/51b75b53ffbcf2eb823ff6b411f1af85f6ae0a55/docs/reference/online-stores/dynamodb.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7134/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7134/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
https://github.com/feast-dev/feast/pull/7134/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
https://github.com/feast-dev/feast/pull/7134/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
Please reload this pagehttps://github.com/feast-dev/feast/pull/7134/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7134/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.