René's URL Explorer Experiment


Title: fix: Round-trip every Feast type and null in the Milvus online store by jiwidi · Pull Request #7119 · feast-dev/feast · GitHub

Open Graph Title: fix: Round-trip every Feast type and null in the Milvus online store by jiwidi · Pull Request #7119 · feast-dev/feast

X Title: fix: Round-trip every Feast type and null in the Milvus online store by jiwidi · Pull Request #7119 · feast-dev/feast

Description: What this PR does / why we need it: Every other online store returns a feature value as it was written, whatever its type, because Redis, Postgres, SQLite, DynamoDB, Elasticsearch, Qdrant and the rest store the serialized ValueProto. The Milvus online store keeps one column per feature, and with the default configuration it could not return most non-numeric types. On upstream master with Milvus Lite: Feast type Before this PR Bool the write works, the read raises TypeError UnixTimestamp no column is created, so every write of the feature view fails Array(String) the write works, the read raises AttributeError an array of numbers without vector_index declared as a vector of embedding_dim, so every write fails Bytes comes back as its base64 text, not the bytes Json comes back as the base64 of its protobuf, not the JSON text a missing value stored as "", 0 or false; the read of a numeric text column raises ValueError any Array, Map or Struct in a search hit comes back as text, because the search path decoded primitive types only a Bytes or UnixTimestamp entity column written as the text of its Python value, b'...' or a datetime The write path now stores every scalar natively or as text, bytes as base64, and every other value as the base64 of its ValueProto, for features and entity columns alike, and one helper rebuilds the ValueProto for reads and searches from every declared field type. UnixTimestamp gets a column. Only a field with vector_index=True becomes a vector, with the dimension from Field.vector_length before embedding_dim; the Elasticsearch, Postgres, Qdrant and MongoDB stores already pick the vector field this way. An empty text in a non-string column reads as null. Array(Bool) with vector_index=True now raises at collection creation: it was mapped to a binary vector but written unpacked and indexed with a float metric, so it could not work. A missing value is still written as the column's default when the column cannot hold NULL. The new milvus.nullable: "true" field tag makes a column nullable, so a missing value is stored and read as null, as every other store does: Field(name="rating", dtype=Float32, tags={"milvus.nullable": "true"}) Nothing here needs a flag. Every change fixes a call that failed or returned a wrong value, the read fixes apply to existing collections at once, and the new columns and the tag only apply when Feast creates a collection, like the partition key. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit (Milvus Lite): thirteen Feast values, empty bytes included, round-trip through online_write_batch and online_read, with and without native numeric types; a missing value in a text column reads as null; a milvus.nullable column stores null and a plain column keeps its default; search hits decode every type the same way as reads; Bytes and UnixTimestamp entity columns round-trip. Unit (mocked client): a numeric array without vector_index is a VARCHAR column, a vector_index field takes its vector_length, UnixTimestamp gets a column; the tag is rejected on entity, vector and partition key fields and for an invalid value; Array(Bool) with vector_index is rejected. Server: the same round-trip and the nullable column against a real server, with and without native numeric types. Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). The server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py pass against a local Milvus 3.0.2 server. The existing Milvus unit and server tests pass unchanged. Misc Follows #7082, #7083 and #7084 and Simon Hearne's series #6882, #6895, #6917, #6921 and #6940. The next PR builds on this one: native ARRAY and JSON columns and scalar index tags behind enable_openai_compatible_store.

Open Graph Description: What this PR does / why we need it: Every other online store returns a feature value as it was written, whatever its type, because Redis, Postgres, SQLite, DynamoDB, Elasticsearch, Qdrant and the r...

X Description: What this PR does / why we need it: Every other online store returns a feature value as it was written, whatever its type, because Redis, Postgres, SQLite, DynamoDB, Elasticsearch, Qdrant and the r...

Opengraph URL: https://github.com/feast-dev/feast/pull/7119

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2728d87a-d9ef-9777-6751-b4de022624ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD838:110AAF:215B0A:2E01AE:6AFE9560
html-safe-nonce35ad59bf53d55393f53d7beed5cc7436e297e0ed53cb3a575cd8dc92b78a0b02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODM4OjExMEFBRjoyMTVCMEE6MkUwMUFFOjZBRkU5NTYwIiwidmlzaXRvcl9pZCI6IjUwNzExOTM5MTg2NzgzNTc0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac22b980567e6f14ad2e6cf463b14214f718f5776a59f0dd9998b5c32dee1b98a0
hovercard-subject-tagpull_request:5224452990
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7119/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: Every other online store returns a feature value as it was written, whatever its type, because Redis, Postgres, SQLite, DynamoDB, Elasticsearch, Qdrant and the r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7119/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7119%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7119%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7119/files
Reloadhttps://github.com/feast-dev/feast/pull/7119/files
Reloadhttps://github.com/feast-dev/feast/pull/7119/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
jiwidihttps://github.com/jiwidi
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:fix/milvus-type-round-triphttps://github.com/jiwidi/feast/tree/fix/milvus-type-round-trip
Conversation 2 https://github.com/feast-dev/feast/pull/7119
Commits 1 https://github.com/feast-dev/feast/pull/7119/commits
Checks 26 https://github.com/feast-dev/feast/pull/7119/checks
Files changed https://github.com/feast-dev/feast/pull/7119/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7119/files
fix: Round-trip every Feast type and null in the Milvus online store https://github.com/feast-dev/feast/pull/7119/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/7119/files
f9be11e fix: Round-trip every Feast type and null in the Milvus online store jiwidi Nov 9, 2026 https://github.com/feast-dev/feast/pull/7119/commits/f9be11eda7afb3dd7efe4028bd2eeec8fdbdd940
Clear filters https://github.com/feast-dev/feast/pull/7119/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7119/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7119/files
milvus.md https://github.com/feast-dev/feast/pull/7119/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
milvus.py https://github.com/feast-dev/feast/pull/7119/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_remote.py https://github.com/feast-dev/feast/pull/7119/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/7119/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/milvus.mdhttps://github.com/feast-dev/feast/pull/7119/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
View file https://github.com/jiwidi/feast/blob/f9be11eda7afb3dd7efe4028bd2eeec8fdbdd940/docs/reference/online-stores/milvus.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7119/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7119/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7119/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
Please reload this pagehttps://github.com/feast-dev/feast/pull/7119/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7119/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.