René's URL Explorer Experiment


Title: feat: Add a schema check and mutation timeout to the Milvus online store by jiwidi · Pull Request #7118 · feast-dev/feast · GitHub

Open Graph Title: feat: Add a schema check and mutation timeout to the Milvus online store by jiwidi · Pull Request #7118 · feast-dev/feast

X Title: feat: Add a schema check and mutation timeout to the Milvus online store by jiwidi · Pull Request #7118 · feast-dev/feast

Description: What this PR does / why we need it: Two small additions to how the Milvus online store treats a collection that already exists, both behind settings that are off by default. Schema check. A collection's schema only applies when Feast creates it. Until now Feast used an existing collection as it was, so a feature view that gained a field, lost a field or changed its vector dimension failed later with a Milvus error at write or read time, or kept writing into a stale schema. Feast now compares the fields of an existing collection with the schema the feature view declares, the first time a process touches the collection and on every feast apply. By default it logs a warning that names each difference, as it already does for a missing partition key. With fail_on_schema_mismatch: true it raises a ValueError instead, so the mismatch is caught at feast apply. Field types are not compared, because reads and writes adapt to the types a collection has. The Redis, Postgres and SQLite online stores do not have this problem: a feature is a hash field or a row there, so a changed feature view needs no schema change. Mutation timeout. PyMilvus retries a failed upsert or delete and, without a timeout, a call can wait for a long time, for example while a cluster refuses writes at its memory quota. Streaming writers need a bound so a stuck call fails and the batch can be retried. mutation_timeout is passed as the PyMilvus timeout of every upsert and delete. PyMilvus applies it to each attempt and stops retrying once the elapsed time exceeds it, so a call ends within the timeout plus one attempt. When unset, nothing is sent and PyMilvus keeps its default retry policy. The Redis online store takes the same control from socket_timeout and socket_connect_timeout in its connection_string. online_store: type: milvus fail_on_schema_mismatch: true mutation_timeout: 60 Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit (mocked client): a missing field, an extra field and a changed vector dimension are logged, or raised with fail_on_schema_mismatch, and the placeholder vector of older collections is ignored; an invalid mutation_timeout is rejected by the config. Unit (Milvus Lite): a changed feature view applied again by the same process warns, then raises with the setting; timeout is sent to upserts and deletes only when mutation_timeout is set. Server: the schema check raises on a real collection; writes and deletes with a timeout succeed. Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). The server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py pass against a local Milvus 3.0.2 server. The existing Milvus unit and server tests pass unchanged. Misc Follows #7082, #7083 and #7084, which brought the Milvus online store the row deletion, partition options and write-batch ordering that the Redis online store has, and Simon Hearne's series #6882, #6895, #6917, #6921 and #6940.

Open Graph Description: What this PR does / why we need it: Two small additions to how the Milvus online store treats a collection that already exists, both behind settings that are off by default. Schema check. A collect...

X Description: What this PR does / why we need it: Two small additions to how the Milvus online store treats a collection that already exists, both behind settings that are off by default. Schema check. A collect...

Opengraph URL: https://github.com/feast-dev/feast/pull/7118

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:464dd5dd-2e98-a3ac-888d-c253dae0b8c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A0E:1EECAE:F68786:150FB88:6AFE9A04
html-safe-nonced50ba8ab74d015b2d7ff1098b76ba7712387e17a5fb5f388029983c1f27c0e35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTBFOjFFRUNBRTpGNjg3ODY6MTUwRkI4ODo2QUZFOUEwNCIsInZpc2l0b3JfaWQiOiIyNzUyNzAyNzk4NzM3ODczNDEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacedf928f281febe6c65a1af0e355636aa6dcbaae3e9c55c4030ada372fd9aa0af
hovercard-subject-tagpull_request:5224452183
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7118/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: Two small additions to how the Milvus online store treats a collection that already exists, both behind settings that are off by default. Schema check. A collect...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7118/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7118%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7118%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7118/files
Reloadhttps://github.com/feast-dev/feast/pull/7118/files
Reloadhttps://github.com/feast-dev/feast/pull/7118/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:feat/milvus-schema-check-and-timeouthttps://github.com/jiwidi/feast/tree/feat/milvus-schema-check-and-timeout
Conversation 3 https://github.com/feast-dev/feast/pull/7118
Commits 4 https://github.com/feast-dev/feast/pull/7118/commits
Checks 32 https://github.com/feast-dev/feast/pull/7118/checks
Files changed https://github.com/feast-dev/feast/pull/7118/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7118/files
feat: Add a schema check and mutation timeout to the Milvus online store https://github.com/feast-dev/feast/pull/7118/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/7118/files
b59e834 feat: Add a schema check and mutation timeout to the Milvus online store jiwidi Nov 9, 2026 https://github.com/feast-dev/feast/pull/7118/commits/b59e834e2d964818b1546072c602e656b973ba29
4176b42 Merge remote-tracking branch 'upstream/master' into feat/milvus-schem… jiwidi Nov 10, 2026 https://github.com/feast-dev/feast/pull/7118/commits/4176b4224ed42029d313843391b0f5809e5b8b77
59236f5 Merge remote-tracking branch 'upstream/master' into feat/milvus-schem… jiwidi Nov 11, 2026 https://github.com/feast-dev/feast/pull/7118/commits/59236f53cc90ac6b09436df9e169f90421121565
a455bad Merge remote-tracking branch 'upstream/master' into feat/milvus-schem… jiwidi Nov 12, 2026 https://github.com/feast-dev/feast/pull/7118/commits/a455bad0d06892f36951718143192932c9bee3ee
Clear filters https://github.com/feast-dev/feast/pull/7118/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7118/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7118/files
milvus.md https://github.com/feast-dev/feast/pull/7118/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
milvus.py https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_remote.py https://github.com/feast-dev/feast/pull/7118/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/7118/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/milvus.mdhttps://github.com/feast-dev/feast/pull/7118/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
View file https://github.com/jiwidi/feast/blob/a455bad0d06892f36951718143192932c9bee3ee/docs/reference/online-stores/milvus.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7118/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7118/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7118/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7118/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7118/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.pyhttps://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
View file https://github.com/jiwidi/feast/blob/a455bad0d06892f36951718143192932c9bee3ee/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7118/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7118/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/online_store/test_milvus_remote.pyhttps://github.com/feast-dev/feast/pull/7118/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
View file https://github.com/jiwidi/feast/blob/a455bad0d06892f36951718143192932c9bee3ee/sdk/python/tests/integration/online_store/test_milvus_remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7118/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7118/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_milvus_online_store.pyhttps://github.com/feast-dev/feast/pull/7118/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
View file https://github.com/jiwidi/feast/blob/a455bad0d06892f36951718143192932c9bee3ee/sdk/python/tests/unit/infra/online_store/test_milvus_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7118/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7118/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
Please reload this pagehttps://github.com/feast-dev/feast/pull/7118/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.