René's URL Explorer Experiment


Title: fix: Log ODFV materialization skips instead of printing them by VenishPaneliya · Pull Request #7117 · feast-dev/feast · GitHub

Open Graph Title: fix: Log ODFV materialization skips instead of printing them by VenishPaneliya · Pull Request #7117 · feast-dev/feast

X Title: fix: Log ODFV materialization skips instead of printing them by VenishPaneliya · Pull Request #7117 · feast-dev/feast

Description: What this PR does / why we need it: FeatureStore._materialize_odfv gives up and returns without materializing on five conditions: no source feature view projections, no join keys, more than one timestamp column, no batch source with a timestamp column, and no source data in the range. Each one reported itself with a bare print carrying a hand-rolled [WARNING] prefix, for example: print( f"[WARNING] ODFV {feature_view.name} materialization: No join keys found in source views. Cannot create entity_df. Skipping." ) Those go to stdout, so a user's logging configuration cannot silence, redirect or capture them, nothing about a skipped ODFV reaches the log, and the prefix reimplements the level that logging already carries. feature_store.py defines _logger at the top and uses _logger.warning(...) with lazy %s formatting for every other warning in the file, so this just brings these five in line. Nothing else changes: the conditions, the early returns and the message text are the same. Which issue(s) this PR fixes: None filed. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Added test_materialize_odfv_reports_skips_through_the_logger to sdk/python/tests/unit/test_unit_feature_store.py, following the FeatureStore.__new__ pattern already used in that file. It takes the first early return and asserts the message lands in caplog and that stdout stays empty, so it fails on the old code and passes on the new. Misc I left the print calls in materialize and materialize_incremental alone: those are deliberate colorized progress output, not diagnostics.

Open Graph Description: What this PR does / why we need it: FeatureStore._materialize_odfv gives up and returns without materializing on five conditions: no source feature view projections, no join keys, more than one tim...

X Description: What this PR does / why we need it: FeatureStore._materialize_odfv gives up and returns without materializing on five conditions: no source feature view projections, no join keys, more than one tim...

Opengraph URL: https://github.com/feast-dev/feast/pull/7117

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6cade5bc-3ac3-1064-f021-0dc838f43786
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4CC:2530C8:EE5902:143A006:6AFE926E
html-safe-noncefd87f5b6ccabd6b37d4e6a82497291abb527d07d9f0b1c81b3c72ae0254a6a54
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENENDOjI1MzBDODpFRTU5MDI6MTQzQTAwNjo2QUZFOTI2RSIsInZpc2l0b3JfaWQiOiIyMzk1MTA4NzY5NDc1MjM2NDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac853526d0b3f0b8532a0f105e1af3a0955766bc1226ab2c3e95d7cd4216a351be
hovercard-subject-tagpull_request:5224116229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7117/files
twitter:imagehttps://avatars.githubusercontent.com/u/141703684?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/141703684?s=400&v=4
og:image:altWhat this PR does / why we need it: FeatureStore._materialize_odfv gives up and returns without materializing on five conditions: no source feature view projections, no join keys, more than one tim...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7117/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7117%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7117%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7117/files
Reloadhttps://github.com/feast-dev/feast/pull/7117/files
Reloadhttps://github.com/feast-dev/feast/pull/7117/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
VenishPaneliya:odfv-materialize-warnings-to-loggerhttps://github.com/VenishPaneliya/feast/tree/odfv-materialize-warnings-to-logger
Conversation 2 https://github.com/feast-dev/feast/pull/7117
Commits 2 https://github.com/feast-dev/feast/pull/7117/commits
Checks 22 https://github.com/feast-dev/feast/pull/7117/checks
Files changed 2 https://github.com/feast-dev/feast/pull/7117/files
fix: Log ODFV materialization skips instead of printing them https://github.com/feast-dev/feast/pull/7117/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7117/files
a7c749c fix: Log ODFV materialization skips instead of printing them VenishPaneliya Nov 9, 2026 https://github.com/feast-dev/feast/pull/7117/commits/a7c749c05afbd433aa051de3f5119893e6ded957
0085b7a Merge branch 'master' into odfv-materialize-warnings-to-logger shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7117/commits/0085b7a0b26ce03e6c96db7f760c5ba8b118290a
Clear filters https://github.com/feast-dev/feast/pull/7117/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7117/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7117/files
feature_store.py https://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
test_unit_feature_store.py https://github.com/feast-dev/feast/pull/7117/files#diff-7c60e7b908d67d28445f54d77f8a05ed06bdf8904efe6f8cc40b696c9735dfd0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/VenishPaneliya/feast/blob/0085b7a0b26ce03e6c96db7f760c5ba8b118290a/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7117/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7117/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_unit_feature_store.pyhttps://github.com/feast-dev/feast/pull/7117/files#diff-7c60e7b908d67d28445f54d77f8a05ed06bdf8904efe6f8cc40b696c9735dfd0
View file https://github.com/VenishPaneliya/feast/blob/0085b7a0b26ce03e6c96db7f760c5ba8b118290a/sdk/python/tests/unit/test_unit_feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7117/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7117/files#diff-7c60e7b908d67d28445f54d77f8a05ed06bdf8904efe6f8cc40b696c9735dfd0
https://github.com/feast-dev/feast/pull/7117/files#diff-7c60e7b908d67d28445f54d77f8a05ed06bdf8904efe6f8cc40b696c9735dfd0
Please reload this pagehttps://github.com/feast-dev/feast/pull/7117/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.