René's URL Explorer Experiment


Title: fix: Use date-only bounds for partition filters built from string timestamps by sohailshk · Pull Request #7116 · feast-dev/feast · GitHub

Open Graph Title: fix: Use date-only bounds for partition filters built from string timestamps by sohailshk · Pull Request #7116 · feast-dev/feast

X Title: fix: Use date-only bounds for partition filters built from string timestamps by sohailshk · Pull Request #7116 · feast-dev/feast

Description: What this PR does / why we need it: get_timestamp_filter_sql formats datetime bounds as dates for the date_partition_column predicate, but returns string bounds unchanged. AthenaOfflineStore.pull_all_from_table_or_query passes strings such as 2026-02-01 01:00:00.000, so the generated partition predicate was dt >= '2026-02-01 01:00:00.000' AND dt <= '2026-02-02 02:00:00.000'. A partition value '2026-02-01' sorts before that bound, so the first partition day was dropped. String bounds are now truncated to their date part, the same way the date_func cast style already does. Adds test_pull_all_partition_filter_uses_dates_only, which builds the Athena query for a source with a partition column and checks the partition predicate. It fails on master and passes with the change. Which issue(s) this PR fixes: N/A (found while reading the Athena offline store; no existing issue) Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc pytest tests/unit/infra/offline_stores: 263 passed, 20 skipped; 2 test_ibis.py failures (sqlglot TypeError) also occur on unmodified master.

Open Graph Description: What this PR does / why we need it: get_timestamp_filter_sql formats datetime bounds as dates for the date_partition_column predicate, but returns string bounds unchanged. AthenaOfflineStore.pull_a...

X Description: What this PR does / why we need it: get_timestamp_filter_sql formats datetime bounds as dates for the date_partition_column predicate, but returns string bounds unchanged. AthenaOfflineStore.pull_a...

Opengraph URL: https://github.com/feast-dev/feast/pull/7116

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:182ecae3-9275-76d8-2cb1-8d7cb9587a85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD51E:2BC66C:DFD212:1325200:6AFE9274
html-safe-nonced577681c7836a49bfc9fa8d0e4db5304dc2aaba49f3807ced92b6fcd65f12057
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTFFOjJCQzY2QzpERkQyMTI6MTMyNTIwMDo2QUZFOTI3NCIsInZpc2l0b3JfaWQiOiI3MjQ1NTk0MTIzNDUxNjY3MDYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1d563056e245c535587f6d018e49917cbc27160639f5d37a8d58b4f3bc4fd1fc
hovercard-subject-tagpull_request:5222091248
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7116/files
twitter:imagehttps://avatars.githubusercontent.com/u/122166523?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/122166523?s=400&v=4
og:image:altWhat this PR does / why we need it: get_timestamp_filter_sql formats datetime bounds as dates for the date_partition_column predicate, but returns string bounds unchanged. AthenaOfflineStore.pull_a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7116/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7116%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7116%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7116/files
Reloadhttps://github.com/feast-dev/feast/pull/7116/files
Reloadhttps://github.com/feast-dev/feast/pull/7116/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
sohailshk:fix/athena-partition-string-datehttps://github.com/sohailshk/feast/tree/fix/athena-partition-string-date
Conversation 1 https://github.com/feast-dev/feast/pull/7116
Commits 2 https://github.com/feast-dev/feast/pull/7116/commits
Checks 1 https://github.com/feast-dev/feast/pull/7116/checks
Files changed 2 https://github.com/feast-dev/feast/pull/7116/files
fix: Use date-only bounds for partition filters built from string timestamps https://github.com/feast-dev/feast/pull/7116/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7116/files
c7c5ef6 fix: Use date-only bounds for partition filters built from string tim… sohailshk Nov 9, 2026 https://github.com/feast-dev/feast/pull/7116/commits/c7c5ef61b8ad96f9756759751646827ccbd80897
9acad95 Merge branch 'master' into fix/athena-partition-string-date shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7116/commits/9acad95e38c87720faac60adbb504aee805dbb8b
Clear filters https://github.com/feast-dev/feast/pull/7116/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7116/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7116/files
offline_utils.py https://github.com/feast-dev/feast/pull/7116/files#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376
test_athena.py https://github.com/feast-dev/feast/pull/7116/files#diff-26ead03c79dde808dc59cc7a4d8ccd889a3abd86b41a56a977c1d78971c6c293
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L20
sdk/python/feast/infra/offline_stores/offline_utils.pyhttps://github.com/feast-dev/feast/pull/7116/files#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376
View file https://github.com/sohailshk/feast/blob/9acad95e38c87720faac60adbb504aee805dbb8b/sdk/python/feast/infra/offline_stores/offline_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7116/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7116/files#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376
https://github.com/feast-dev/feast/pull/7116/files#diff-f515f3d334f6ab63f082e3d078bcf23f460538b468a5177105cd79440178f376
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/contrib/athena_offline_store/test_athena.pyhttps://github.com/feast-dev/feast/pull/7116/files#diff-26ead03c79dde808dc59cc7a4d8ccd889a3abd86b41a56a977c1d78971c6c293
View file https://github.com/sohailshk/feast/blob/9acad95e38c87720faac60adbb504aee805dbb8b/sdk/python/tests/unit/infra/offline_stores/contrib/athena_offline_store/test_athena.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7116/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.