Title: Remove feature set update from job update cycle by zhilingc · Pull Request #711 · feast-dev/feast · GitHub
Open Graph Title: Remove feature set update from job update cycle by zhilingc · Pull Request #711 · feast-dev/feast
X Title: Remove feature set update from job update cycle by zhilingc · Pull Request #711 · feast-dev/feast
Description: What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long periods of time. Hopefully this improves the performance of the system. The responsibility of making feature set status updates is pushed to when the feature set is retrieved (either by ListFeatureSets or GetFeatureSet). Would like the dataflow tests to be fixed and run on this PR before this is merged in, ideally. Which issue(s) this PR fixes: Fixes #664 Does this PR introduce a user-facing change?:
Open Graph Description: What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ...
X Description: What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ...
Opengraph URL: https://github.com/feast-dev/feast/pull/711
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fbb1da0a-67f0-f0db-2972-dc5213e9612e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E900:25AFF0:16B6F40:1D433D9:697FCCDF |
| html-safe-nonce | 2c1a12c3ff1903ed0a96653f547cfdef13a4c88d92373fbed52c2814126d3917 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTAwOjI1QUZGMDoxNkI2RjQwOjFENDMzRDk6Njk3RkNDREYiLCJ2aXNpdG9yX2lkIjoiMjkzMjU4MTUwMDg1NzYwMTI0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 62a279b7babf261670c0b5f3910a53d4d2fb262110dab490fa6b1f84ee7cbf29 |
| hovercard-subject-tag | pull_request:418518076 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/711/files |
| twitter:image | https://avatars.githubusercontent.com/u/15104168?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15104168?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width