René's URL Explorer Experiment


Title: Remove feature set update from job update cycle by zhilingc · Pull Request #711 · feast-dev/feast · GitHub

Open Graph Title: Remove feature set update from job update cycle by zhilingc · Pull Request #711 · feast-dev/feast

X Title: Remove feature set update from job update cycle by zhilingc · Pull Request #711 · feast-dev/feast

Description: What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ...

Open Graph Description: What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ...

X Description: What this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ...

Opengraph URL: https://github.com/feast-dev/feast/pull/711

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:02998e55-7f8b-64fc-e920-77b0df2244f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C12:27367:8493A9:A87F3D:697F69C1
html-safe-nonced7a9c43950eeb08627bd48c42efaa56acee55c0f247b0d58ef037d0a56004740
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzEyOjI3MzY3Ojg0OTNBOTpBODdGM0Q6Njk3RjY5QzEiLCJ2aXNpdG9yX2lkIjoiNTMzNjAyMzYzMDM3MzQxNTM2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd8055aca17dcc7352cca1d496f0ccdb04852f931cce8fda56113b424123d0559
hovercard-subject-tagpull_request:418518076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/711/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/362f5a14fd2d2898aaaa817c953c9414e261ef3eebbefadbe8095cdfaf9ef889/feast-dev/feast/pull/711
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/362f5a14fd2d2898aaaa817c953c9414e261ef3eebbefadbe8095cdfaf9ef889/feast-dev/feast/pull/711
og:image:altWhat this PR does / why we need it: Removes the feature set update from the job update cycle, because job updates are long running and are write-transactional, and so can block feast core for long ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhilingc
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/711#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F711
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F711
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/711
Reloadhttps://github.com/feast-dev/feast/pull/711
Reloadhttps://github.com/feast-dev/feast/pull/711
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/711#issue-comment-box
zhilingchttps://github.com/zhilingc
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
zhilingc:jobs-no-update-fshttps://github.com/zhilingc/feast/tree/jobs-no-update-fs
Remove feature set update from job update cycle https://github.com/feast-dev/feast/pull/711#top
zhilingchttps://github.com/zhilingc
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
zhilingc:jobs-no-update-fshttps://github.com/zhilingc/feast/tree/jobs-no-update-fs
Conversation 6 https://github.com/feast-dev/feast/pull/711
Commits 6 https://github.com/feast-dev/feast/pull/711/commits
Checks 0 https://github.com/feast-dev/feast/pull/711/checks
Files changed https://github.com/feast-dev/feast/pull/711/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
May 15, 2020https://github.com/feast-dev/feast/pull/711#issue-618876906
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
#664https://github.com/feast-dev/feast/issues/664
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
pradithyahttps://github.com/pradithya
code ownerhttps://github.com/feast-dev/feast/blob/09984b3fd118ebeb0595f895516eb76c56ca22be/.github/CODEOWNERS#L5
May 15, 2020 10:48https://github.com/feast-dev/feast/pull/711#event-3340394389
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
May 15, 2020https://github.com/feast-dev/feast/pull/711#event-3340394683
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
area/core https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aarea%2Fcore
kind/housekeeping https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping
kind/techdebt https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Ftechdebt
May 15, 2020https://github.com/feast-dev/feast/pull/711#event-3340397103
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
May 15, 2020https://github.com/feast-dev/feast/pull/711#event-3340397168
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
May 15, 2020https://github.com/feast-dev/feast/pull/711#issuecomment-629174618
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
May 15, 2020https://github.com/feast-dev/feast/pull/711#event-3340449277
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
do-not-merge/work-in-progress https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
May 17, 2020https://github.com/feast-dev/feast/pull/711#event-3344093411
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
May 18, 2020https://github.com/feast-dev/feast/pull/711#issuecomment-629974092
zhilingchttps://github.com/feast-dev/feast/pull/711
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
May 18, 2020 14:36https://github.com/feast-dev/feast/pull/711#commits-pushed-022dbca
Remove feature set update from job update cyclehttps://github.com/feast-dev/feast/pull/711/commits/022dbca82b4ad7a219e1a314152186455b4a8ad5
022dbcahttps://github.com/feast-dev/feast/pull/711/commits/022dbca82b4ad7a219e1a314152186455b4a8ad5
Apply spotlesshttps://github.com/feast-dev/feast/pull/711/commits/ee6260344e9cde104965a960b55d392a87b60d7c
ee62603https://github.com/feast-dev/feast/pull/711/commits/ee6260344e9cde104965a960b55d392a87b60d7c
Track feature set version in jobhttps://github.com/feast-dev/feast/pull/711/commits/e89f480426a1cc8ac5b9556f49aea17188bb95ee
e89f480https://github.com/feast-dev/feast/pull/711/commits/e89f480426a1cc8ac5b9556f49aea17188bb95ee
Resolve imports after rebasehttps://github.com/feast-dev/feast/pull/711/commits/e05f014881997fc24ae36c05bccaab8365f5792b
e05f014https://github.com/feast-dev/feast/pull/711/commits/e05f014881997fc24ae36c05bccaab8365f5792b
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
force-pushedhttps://github.com/feast-dev/feast/compare/35297dbff7553efc688b66fda135df4104485b29..e05f014881997fc24ae36c05bccaab8365f5792b
35297dbhttps://github.com/feast-dev/feast/commit/35297dbff7553efc688b66fda135df4104485b29
e05f014https://github.com/feast-dev/feast/commit/e05f014881997fc24ae36c05bccaab8365f5792b
Compare https://github.com/feast-dev/feast/compare/35297dbff7553efc688b66fda135df4104485b29..e05f014881997fc24ae36c05bccaab8365f5792b
May 18, 2020 06:51https://github.com/feast-dev/feast/pull/711#event-3345799127
May 18, 2020 14:59https://github.com/feast-dev/feast/pull/711#commits-pushed-5e2e07e
Apply spotlesshttps://github.com/feast-dev/feast/pull/711/commits/5e2e07e3288c25ef1d9cc9ac6f7e64a5d30c8f84
5e2e07ehttps://github.com/feast-dev/feast/pull/711/commits/5e2e07e3288c25ef1d9cc9ac6f7e64a5d30c8f84
Compare between feature sets during job updateshttps://github.com/feast-dev/feast/pull/711/commits/c58a6174dbb4bd3eb0b93940e438b3bfa442c666
c58a617https://github.com/feast-dev/feast/pull/711/commits/c58a6174dbb4bd3eb0b93940e438b3bfa442c666
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
force-pushedhttps://github.com/feast-dev/feast/compare/5beabcc71a8bc8d50f131dd543e6415da2e30b39..c58a6174dbb4bd3eb0b93940e438b3bfa442c666
5beabcchttps://github.com/feast-dev/feast/commit/5beabcc71a8bc8d50f131dd543e6415da2e30b39
c58a617https://github.com/feast-dev/feast/commit/c58a6174dbb4bd3eb0b93940e438b3bfa442c666
Compare https://github.com/feast-dev/feast/compare/5beabcc71a8bc8d50f131dd543e6415da2e30b39..c58a6174dbb4bd3eb0b93940e438b3bfa442c666
May 18, 2020 07:30https://github.com/feast-dev/feast/pull/711#event-3345938400
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
May 18, 2020https://github.com/feast-dev/feast/pull/711#issuecomment-630002589
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
May 18, 2020https://github.com/feast-dev/feast/pull/711#issuecomment-630007600
@zhilingchttps://github.com/zhilingc
c58a617https://github.com/feast-dev/feast/commit/c58a6174dbb4bd3eb0b93940e438b3bfa442c666
linkhttp://prow.feast.ai/view/gcs/feast-templocation-kf-feast/pr-logs/pull/feast-dev_feast/711/test-end-to-end-redis-cluster/1262284415749328897
c58a617https://github.com/feast-dev/feast/commit/c58a6174dbb4bd3eb0b93940e438b3bfa442c666
linkhttp://prow.feast.ai/view/gcs/feast-templocation-kf-feast/pr-logs/pull/feast-dev_feast/711/test-end-to-end/1262286554559156224
Full PR test historyhttps://prow.feast.ai/pr-history?org=feast-dev&repo=feast&pr=711
herehttps://git.k8s.io/community/contributors/guide/pull-requests.md
kubernetes/test-infrahttps://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:
herehttps://go.k8s.io/bot-commands
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
May 18, 2020https://github.com/feast-dev/feast/pull/711#issuecomment-630008658
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/woop
woophttps://github.com/woop
force-pushedhttps://github.com/feast-dev/feast/compare/68eb265a4de38989705b27e02f49aab25d1cc311..35f8f188c8294db4ed45d94df48d3ebf63b1cbe3
68eb265https://github.com/feast-dev/feast/commit/68eb265a4de38989705b27e02f49aab25d1cc311
35f8f18https://github.com/feast-dev/feast/commit/35f8f188c8294db4ed45d94df48d3ebf63b1cbe3
Compare https://github.com/feast-dev/feast/compare/68eb265a4de38989705b27e02f49aab25d1cc311..35f8f188c8294db4ed45d94df48d3ebf63b1cbe3
May 24, 2020 06:47https://github.com/feast-dev/feast/pull/711#event-3367694741
https://github.com/woop
woophttps://github.com/woop
Jun 19, 2020https://github.com/feast-dev/feast/pull/711#issuecomment-646374293
#792https://github.com/feast-dev/feast/pull/792
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/woop
woophttps://github.com/woop
Jun 19, 2020https://github.com/feast-dev/feast/pull/711#event-3460531114
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F711
https://github.com/pradithya
pradithya https://github.com/pradithya
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
area/core https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aarea%2Fcore
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
do-not-merge/work-in-progress https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress
kind/housekeeping https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping
kind/techdebt https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Ftechdebt
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Job Management Optimizations https://github.com/feast-dev/feast/issues/664
Please reload this pagehttps://github.com/feast-dev/feast/pull/711
https://github.com/zhilingc
https://github.com/feast-ci-bot
https://github.com/woop
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.