Title: fix: Pin build dependencies of source builds to the CI lock by patelchaitany · Pull Request #7104 · feast-dev/feast · GitHub
Open Graph Title: fix: Pin build dependencies of source builds to the CI lock by patelchaitany · Pull Request #7104 · feast-dev/feast
X Title: fix: Pin build dependencies of source builds to the CI lock by patelchaitany · Pull Request #7104 · feast-dev/feast
Description: What this PR does / why we need it: The unit-test-python (3.10, ubuntu-latest) job fails on master and on every open PR since Nov 2: error: Failed to build `sqlglotc==30.21.0` /tmp/sqlglotc_build_*/sqlglot/schema.py:284: error: Multiple inheritance is not supported (except for traits) Cause: sqlglotc no longer has Python 3.10 wheels on PyPI, so on 3.10 uv pip sync builds sqlglotc==30.21.0 from source. The sdist's build requirements include an unpinned sqlglot, and its setup.py compiles that installed copy. So the build compiles the newest sqlglot instead of the locked 30.21.0. In newer sqlglot, Schema is no longer a mypyc trait, so MappingSchema(AbstractMappingSchema, Schema) fails to compile. Fix: pass the CI lock as --build-constraints in install-python-dependencies-ci. Source builds then use the locked versions (sqlglot==30.21.0). This only affects build-time dependencies of packages built from source; the installed set is unchanged. It is a stopgap until Python 3.10 support is dropped. Which issue(s) this PR fixes: CI failure on Python 3.10 (no issue filed). Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc Verification is the unit-test-python (3.10, ubuntu-latest) job on this PR; it could not be reproduced locally (no Python 3.10 available).
Open Graph Description: What this PR does / why we need it: The unit-test-python (3.10, ubuntu-latest) job fails on master and on every open PR since Nov 2: error: Failed to build `sqlglotc==30.21.0` /tmp/sqlglotc_build...
X Description: What this PR does / why we need it: The unit-test-python (3.10, ubuntu-latest) job fails on master and on every open PR since Nov 2: error: Failed to build `sqlglotc==30.21.0` /tmp/sqlglotc_build...
Opengraph URL: https://github.com/feast-dev/feast/pull/7104
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3d32d515-b480-8e50-5f71-16b734f2fc61 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 966A:22BB81:E4281D:12C1884:6AFE9269 |
| html-safe-nonce | 1b2d8b698e58c2bd3189f9ef6a64acaf476ffddd14ed70dc74d5f5b09e9c6002 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjZBOjIyQkI4MTpFNDI4MUQ6MTJDMTg4NDo2QUZFOTI2OSIsInZpc2l0b3JfaWQiOiIxMzQ0MzczNzk2Nzg5NzE5NjU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0dfd8e25326be62e8afe4ee7c2e56b2c6052a926cf5b372f4632ae9e0c263c05 |
| hovercard-subject-tag | pull_request:5152121245 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7104/files |
| twitter:image | https://avatars.githubusercontent.com/u/67532224?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/67532224?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: The unit-test-python (3.10, ubuntu-latest) job fails on master and on every open PR since Nov 2: error: Failed to build `sqlglotc==30.21.0` /tmp/sqlglotc_build... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width