René's URL Explorer Experiment


Title: docs: Fix docstring argument names that do not match the signature by mmporong · Pull Request #7098 · feast-dev/feast · GitHub

Open Graph Title: docs: Fix docstring argument names that do not match the signature by mmporong · Pull Request #7098 · feast-dev/feast

X Title: docs: Fix docstring argument names that do not match the signature by mmporong · Pull Request #7098 · feast-dev/feast

Description: What this PR does / why we need it: Fixes docstring Args entries that name a parameter the function does not have. Docstrings only, no code changes. BaseRegistry.delete_project: project -> name init_security_manager (feast/permissions/server/utils.py): registry -> fs. The function takes the FeatureStore and reads fs.project and fs.registry. DecisionEvaluator: removed decision_strategy. The constructor only takes num_of_voters and always uses AFFIRMATIVE, so the summary line now says that instead of "according to the selected strategy". The example in the same docstring called DecisionEvaluator(DecisionStrategy.UNANIMOUS, 3), which raises TypeError: DecisionEvaluator.__init__() takes 2 positional arguments but 3 were given, so it now reads DecisionEvaluator(3). Also fixed in the same file: the "receivem" typo in that example, and in the add_grant docstring vote -> grant and "True is" -> "True if". Project.from_proto: entity_proto -> project_proto, and the Returns line now says it returns a Project (it said "An Entity object based on the entity protobuf"). "an project" -> "a project" in the same docstring. Provider.retrieve_online_documents_v2: query -> embedding configure_ca_trust_store_env_variables: removed :param ca_file_path:. The function takes no arguments and reads FEAST_CA_CERT_FILE_PATH from the environment. _proto_value_to_value_type (feast/type_map.py): proto_str -> proto_value, and the summary line now says it takes a proto value. These were found with a script that parses each function with ast and compares the names in its docstring parameter section with the signature. Before this change it reported 12 entries under sdk/python/feast, after it 5, none of which is a wrong name: created_timestamp and last_updated_timestamp in the DataSource class docstring are attributes listed under Args, Versions: in serialize_entity_key is a heading inside an argument description, and start_date / end_date in Provider.get_historical_features go through **kwargs. Checks run locally (Python 3.12): ruff check sdk/python/feast/ sdk/python/tests/ and ruff format --check on the changed files, ruff 0.16.10 as pinned in sdk/python/requirements/py3.12-ci-requirements.txt: pass mypy 1.11.2 on the 7 changed files, run from sdk/python: no issues pytest tests/unit/permissions tests/unit/test_project.py tests/unit/test_type_map.py -k "not TestSparkNativeTypeValidation": 657 passed, the same as on master. The 24 deselected tests need pyspark, which was not installed. Ran both versions of the DecisionEvaluator example against feast/permissions/decision.py: the old one raises the TypeError above, the new one runs and returns a decision. Which issue(s) this PR fixes: None, there is no issue for this. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc

Open Graph Description: What this PR does / why we need it: Fixes docstring Args entries that name a parameter the function does not have. Docstrings only, no code changes. BaseRegistry.delete_project: project -> name...

X Description: What this PR does / why we need it: Fixes docstring Args entries that name a parameter the function does not have. Docstrings only, no code changes. BaseRegistry.delete_project: project -> ...

Opengraph URL: https://github.com/feast-dev/feast/pull/7098

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:83b77548-aed3-e087-c525-3647daab6e9b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1EC:6D939:2270AB:2DDCB4:6AFE989D
html-safe-noncea1291c6ad2124ea0d62a44898d8c7a024177b629508554546dddf60365e4a1ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUVDOjZEOTM5OjIyNzBBQjoyRERDQjQ6NkFGRTk4OUQiLCJ2aXNpdG9yX2lkIjoiMzM5NDA0MTgxMDg5MTIxNzA1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9100c48232f3e32d8e2d927df333058f2a5940e1a6b3ccecf4f4eb59adbba341
hovercard-subject-tagpull_request:5148170907
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7098/files
twitter:imagehttps://avatars.githubusercontent.com/u/74720422?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/74720422?s=400&v=4
og:image:altWhat this PR does / why we need it: Fixes docstring Args entries that name a parameter the function does not have. Docstrings only, no code changes. BaseRegistry.delete_project: project -> name...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7098/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7098%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7098%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7098/files
Reloadhttps://github.com/feast-dev/feast/pull/7098/files
Reloadhttps://github.com/feast-dev/feast/pull/7098/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
mmporong:docs-fix-docstring-arg-nameshttps://github.com/mmporong/feast/tree/docs-fix-docstring-arg-names
Conversation 2 https://github.com/feast-dev/feast/pull/7098
Commits 2 https://github.com/feast-dev/feast/pull/7098/commits
Checks 1 https://github.com/feast-dev/feast/pull/7098/checks
Files changed https://github.com/feast-dev/feast/pull/7098/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7098/files
docs: Fix docstring argument names that do not match the signature https://github.com/feast-dev/feast/pull/7098/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7098/files
0d7d551 docs: Fix docstring argument names that do not match the signature mmporong Nov 4, 2026 https://github.com/feast-dev/feast/pull/7098/commits/0d7d551fd2cb0b5543a94a4fe45a79aeba41c398
5def032 Merge branch 'master' into docs-fix-docstring-arg-names shuchu Nov 4, 2026 https://github.com/feast-dev/feast/pull/7098/commits/5def0328c84b8625244ee68a13d01da99abc5508
Clear filters https://github.com/feast-dev/feast/pull/7098/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7098/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7098/files
provider.py https://github.com/feast-dev/feast/pull/7098/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
base_registry.py https://github.com/feast-dev/feast/pull/7098/files#diff-c0a697ad0a143c46409d813c90c6d1d412f6db7368e656bfe1c4855b32228244
decision.py https://github.com/feast-dev/feast/pull/7098/files#diff-48a16c754b7efe82b2a492888f2af7a57337cf23151703806b91c6d92090a783
utils.py https://github.com/feast-dev/feast/pull/7098/files#diff-6f1db082cdec92b4b7a14661770f9cd502b731745cc579e238b8a5b6e7489c82
project.py https://github.com/feast-dev/feast/pull/7098/files#diff-08b51db2cedf5175e2cfb896ca92144100ea46d48dead70f46cd312a857d1a60
ssl_ca_trust_store_setup.py https://github.com/feast-dev/feast/pull/7098/files#diff-93b676d5682cc52a8b50b952986256a25b84e08fe13b9a2ee1a7dc983e23d222
type_map.py https://github.com/feast-dev/feast/pull/7098/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/provider.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/infra/provider.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
https://github.com/feast-dev/feast/pull/7098/files#diff-465c56d60ad11aa485727982ae4b7adf6e1eca816f610442078f871ddd9357a5
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/registry/base_registry.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-c0a697ad0a143c46409d813c90c6d1d412f6db7368e656bfe1c4855b32228244
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/infra/registry/base_registry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-c0a697ad0a143c46409d813c90c6d1d412f6db7368e656bfe1c4855b32228244
https://github.com/feast-dev/feast/pull/7098/files#diff-c0a697ad0a143c46409d813c90c6d1d412f6db7368e656bfe1c4855b32228244
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/decision.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-48a16c754b7efe82b2a492888f2af7a57337cf23151703806b91c6d92090a783
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/permissions/decision.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-48a16c754b7efe82b2a492888f2af7a57337cf23151703806b91c6d92090a783
https://github.com/feast-dev/feast/pull/7098/files#diff-48a16c754b7efe82b2a492888f2af7a57337cf23151703806b91c6d92090a783
https://github.com/feast-dev/feast/pull/7098/files#diff-48a16c754b7efe82b2a492888f2af7a57337cf23151703806b91c6d92090a783
https://github.com/feast-dev/feast/pull/7098/files#diff-48a16c754b7efe82b2a492888f2af7a57337cf23151703806b91c6d92090a783
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/server/utils.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-6f1db082cdec92b4b7a14661770f9cd502b731745cc579e238b8a5b6e7489c82
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/permissions/server/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-6f1db082cdec92b4b7a14661770f9cd502b731745cc579e238b8a5b6e7489c82
https://github.com/feast-dev/feast/pull/7098/files#diff-6f1db082cdec92b4b7a14661770f9cd502b731745cc579e238b8a5b6e7489c82
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/project.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-08b51db2cedf5175e2cfb896ca92144100ea46d48dead70f46cd312a857d1a60
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/project.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-08b51db2cedf5175e2cfb896ca92144100ea46d48dead70f46cd312a857d1a60
https://github.com/feast-dev/feast/pull/7098/files#diff-08b51db2cedf5175e2cfb896ca92144100ea46d48dead70f46cd312a857d1a60
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/ssl_ca_trust_store_setup.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-93b676d5682cc52a8b50b952986256a25b84e08fe13b9a2ee1a7dc983e23d222
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/ssl_ca_trust_store_setup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-93b676d5682cc52a8b50b952986256a25b84e08fe13b9a2ee1a7dc983e23d222
https://github.com/feast-dev/feast/pull/7098/files#diff-93b676d5682cc52a8b50b952986256a25b84e08fe13b9a2ee1a7dc983e23d222
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/type_map.pyhttps://github.com/feast-dev/feast/pull/7098/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
View file https://github.com/mmporong/feast/blob/5def0328c84b8625244ee68a13d01da99abc5508/sdk/python/feast/type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7098/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7098/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/pull/7098/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.