René's URL Explorer Experiment


Title: feat: Add read_from and client_az options to the Redis GLIDE client by NopeCharon · Pull Request #7093 · feast-dev/feast · GitHub

Open Graph Title: feat: Add read_from and client_az options to the Redis GLIDE client by NopeCharon · Pull Request #7093 · feast-dev/feast

X Title: feat: Add read_from and client_az options to the Redis GLIDE client by NopeCharon · Pull Request #7093 · feast-dev/feast

Description: What this PR does / why we need it: The GLIDE client from #6870 always reads from the primary: the Feast config has no way to pass GLIDE's read strategy through, so clusters with replicas can't spread online reads across them. This adds two RedisOnlineStoreConfig options that map directly onto GLIDE's own settings: read_from: primary (default), prefer_replica, az_affinity, az_affinity_replicas_and_primary or all_nodes, translated to glide_sync.ReadFrom. client_az: the client's availability zone, used by the az_affinity strategies. online_store: type: redis redis_type: redis_cluster connection_string: "redis1:6379,redis2:6379" client: glide read_from: az_affinity client_az: us-east-1a I used dedicated options rather than connection_string parameters, as the issue suggests. The reason is that connection_string parameters are also passed as kwargs to redis-py, which still handles writes and async reads, and redis-py would reject them. The config is validated at load time, so a setting is never silently ignored: read_from and client_az require client: glide, since redis-py doesn't use them. A read_from other than primary requires redis_type: redis_cluster. A standalone GLIDE client sends every batch to the primary whatever read_from is, so the batched HMGET read would ignore the strategy. GLIDE's standalone BatchOptions has no routing option. I checked this against a real primary + replica: with PREFER_REPLICA, single hmget calls went to the replica but exec(Batch(...)) still went to the primary. The az_affinity strategies require client_az. GLIDE also enforces this, but only when the client is created. Docs: docs/reference/online-stores/redis.md gets a "Reading from replicas" section and two new rows in the configuration reference table. Which issue(s) this PR fixes: Fixes #7086 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit tests (tests/unit/infra/online_store/test_redis.py) cover the default, the three validation rules, and the mapping of every read_from value onto glide_sync.ReadFrom and client_az. Manual test: I ran RedisOnlineStore.online_write_batch + online_read with client: glide against a Valkey 8 cluster with one primary (availability-zone zone-a) and one replica (zone-b). For each config I counted HMGET calls per node from INFO commandstats over one read of 3 entities: config primary replica default (primary) 3 0 prefer_replica 0 3 all_nodes 2 1 az_affinity, client_az: zone-b 0 3 az_affinity, client_az: zone-a (no replica in zone, falls back to other replicas) 0 3 az_affinity_replicas_and_primary, client_az: zone-a 3 0 All reads returned the written values. Misc

Open Graph Description: What this PR does / why we need it: The GLIDE client from #6870 always reads from the primary: the Feast config has no way to pass GLIDE's read strategy through, so clusters with replicas can&#...

X Description: What this PR does / why we need it: The GLIDE client from #6870 always reads from the primary: the Feast config has no way to pass GLIDE's read strategy through, so clusters with replicas c...

Opengraph URL: https://github.com/feast-dev/feast/pull/7093

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e99bdb33-e667-8588-e709-ba5f6cdb454b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99BE:3DF67A:F65238:143B1C2:6AFE9894
html-safe-nonce0535225be1b50f0ba2a0b0b25f9d24299dad43a21a4c0229fcc35538610e5835
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUJFOjNERjY3QTpGNjUyMzg6MTQzQjFDMjo2QUZFOTg5NCIsInZpc2l0b3JfaWQiOiI1Nzc5MDAyODA3ODAxNTE4MjI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc354b59fe5b06efdf419dbb1276a8f4756531ae967ac37155ab625723eea7250
hovercard-subject-tagpull_request:5079472030
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7093/files
twitter:imagehttps://avatars.githubusercontent.com/u/115794254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/115794254?s=400&v=4
og:image:altWhat this PR does / why we need it: The GLIDE client from #6870 always reads from the primary: the Feast config has no way to pass GLIDE's read strategy through, so clusters with replicas can&#...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7093/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7093%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7093%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7093/files
Reloadhttps://github.com/feast-dev/feast/pull/7093/files
Reloadhttps://github.com/feast-dev/feast/pull/7093/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
NopeCharon:feat/redis-glide-read-fromhttps://github.com/NopeCharon/feast/tree/feat/redis-glide-read-from
Conversation 4 https://github.com/feast-dev/feast/pull/7093
Commits 1 https://github.com/feast-dev/feast/pull/7093/commits
Checks 23 https://github.com/feast-dev/feast/pull/7093/checks
Files changed https://github.com/feast-dev/feast/pull/7093/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7093/files
feat: Add read_from and client_az options to the Redis GLIDE client https://github.com/feast-dev/feast/pull/7093/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/7093/files
38df0e8 feat: Add read_from and client_az options to the Redis GLIDE client NopeCharon Oct 30, 2026 https://github.com/feast-dev/feast/pull/7093/commits/38df0e8ab0ae0342b9d0df4bd5d957d29444a29d
Clear filters https://github.com/feast-dev/feast/pull/7093/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7093/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7093/files
redis.md https://github.com/feast-dev/feast/pull/7093/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
redis.py https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
test_redis.py https://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/redis.mdhttps://github.com/feast-dev/feast/pull/7093/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
View file https://github.com/NopeCharon/feast/blob/38df0e8ab0ae0342b9d0df4bd5d957d29444a29d/docs/reference/online-stores/redis.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7093/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7093/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/7093/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/7093/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/7093/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/redis.pyhttps://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
View file https://github.com/NopeCharon/feast/blob/38df0e8ab0ae0342b9d0df4bd5d957d29444a29d/sdk/python/feast/infra/online_stores/redis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7093/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/7093/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_redis.pyhttps://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
View file https://github.com/NopeCharon/feast/blob/38df0e8ab0ae0342b9d0df4bd5d957d29444a29d/sdk/python/tests/unit/infra/online_store/test_redis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7093/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/pull/7093/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
Please reload this pagehttps://github.com/feast-dev/feast/pull/7093/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.