René's URL Explorer Experiment


Title: fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast · GitHub

Open Graph Title: fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast

X Title: fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast

Description: What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_exists_in_inferred checks specified_feature in inferred_features, which uses Field.__eq__ and compares the description, tags and vector settings. The inferred fields carry only a name and a type, and a scalar field with a description never matches. The check now compares the name and the type. With only that change, feast apply succeeds, but the view read back from the registry has an empty description. _parse_features_from_proto builds each Field from the name, the value type and the vector settings instead of calling Field.from_proto, which FeatureView and StreamFeatureView use. Besides the description and tags, it loses the inner types of nested outputs: Schema field type Type after OnDemandFeatureView.from_proto(odfv.to_proto()) on master Struct({a: Int64}) Struct({_value: String}) Array(Array(Int64)) Array(Array(String)) Array(Struct({a: Int64})) Array(Struct({_value: String})) _parse_features_from_proto now returns Field.from_proto(feature) for each feature. To reproduce, add description="val plus one" to a Field in the schema of an @on_demand_feature_view with a RequestSource, in a repo with the local provider and the SQLite online store, and run feast apply. On master it stops after "Applying changes for project repro" with SpecifiedFeaturesNotPresentError. With this change it prints "Created on demand feature view plus_one", and store.get_on_demand_feature_view("plus_one").features[0].description is 'val plus one'. Which issue(s) this PR fixes: Fixes #3617. The stale bot closed it in 2025 without a fix. It reports the first half; the registry round-trip has no issue. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc test_schema_field_metadata_survives_inference_and_proto_round_trip in tests/unit/test_on_demand_feature_view.py checks that the description and tags survive infer_features, that a proto round-trip returns the original fields, including Struct and nested Array types, and that a wrong type still raises SpecifiedFeaturesNotPresentError. It fails on master. test_on_demand_feature_view.py and test_on_demand_python_transformation.py pass, and ruff is clean. ODFVs that are already registered with Struct or nested outputs now load with their real inner types instead of _value: String.

Open Graph Description: What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_...

X Description: What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_...

Opengraph URL: https://github.com/feast-dev/feast/pull/7091

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:29a492be-b187-69f2-c86c-ba832948c1ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9940:312218:161AD65:1D881A2:6AFEBBFB
html-safe-noncebe3b15c4cfda53c34634dc653637a0a2449e5dd0488fe33a298b16cebb961806
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTQwOjMxMjIxODoxNjFBRDY1OjFEODgxQTI6NkFGRUJCRkIiLCJ2aXNpdG9yX2lkIjoiMTUxMDcyNDQwODUxNDEwMDIxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac66dda98846714be341f06d7bc947908892d49112a2b288fcdccc39e1418baa89
hovercard-subject-tagpull_request:5076027630
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7091/files
twitter:imagehttps://avatars.githubusercontent.com/u/7221855?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7221855?s=400&v=4
og:image:altWhat this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee1ce4c46d35aa8463a597a1bbffd4f0a456edb38
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7091/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7091%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7091%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7091/files
Reloadhttps://github.com/feast-dev/feast/pull/7091/files
Reloadhttps://github.com/feast-dev/feast/pull/7091/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Revinand:fix/odfv-field-description-inferencehttps://github.com/Revinand/feast/tree/fix/odfv-field-description-inference
Conversation 1 https://github.com/feast-dev/feast/pull/7091
Commits 2 https://github.com/feast-dev/feast/pull/7091/commits
Checks 1 https://github.com/feast-dev/feast/pull/7091/checks
Files changed https://github.com/feast-dev/feast/pull/7091/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7091/files
fix: Keep description, tags and nested types of ODFV schema fields https://github.com/feast-dev/feast/pull/7091/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7091/files
e9a61b0 fix: Keep description, tags and nested types of ODFV schema fields Revinand Oct 29, 2026 https://github.com/feast-dev/feast/pull/7091/commits/e9a61b0791d4763c6ccf35157ba65a0c34632873
d4c291b Merge branch 'master' into fix/odfv-field-description-inference shuchu Nov 4, 2026 https://github.com/feast-dev/feast/pull/7091/commits/d4c291bccc1ffef37554f4dcc59f92396adb9532
Clear filters https://github.com/feast-dev/feast/pull/7091/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7091/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7091/files
on_demand_feature_view.py https://github.com/feast-dev/feast/pull/7091/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
test_on_demand_feature_view.py https://github.com/feast-dev/feast/pull/7091/files#diff-70d7d8f2062ae11aceb8e9865fe444a237507c18b7a5f20eda1d4fb809b10f30
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/on_demand_feature_view.pyhttps://github.com/feast-dev/feast/pull/7091/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
View file https://github.com/Revinand/feast/blob/d4c291bccc1ffef37554f4dcc59f92396adb9532/sdk/python/feast/on_demand_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7091/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7091/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7091/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7091/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7091/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_feature_view.pyhttps://github.com/feast-dev/feast/pull/7091/files#diff-70d7d8f2062ae11aceb8e9865fe444a237507c18b7a5f20eda1d4fb809b10f30
View file https://github.com/Revinand/feast/blob/d4c291bccc1ffef37554f4dcc59f92396adb9532/sdk/python/tests/unit/test_on_demand_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7091/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7091/files#diff-70d7d8f2062ae11aceb8e9865fe444a237507c18b7a5f20eda1d4fb809b10f30
https://github.com/feast-dev/feast/pull/7091/files#diff-70d7d8f2062ae11aceb8e9865fe444a237507c18b7a5f20eda1d4fb809b10f30
https://github.com/feast-dev/feast/pull/7091/files#diff-70d7d8f2062ae11aceb8e9865fe444a237507c18b7a5f20eda1d4fb809b10f30
https://github.com/feast-dev/feast/pull/7091/files#diff-70d7d8f2062ae11aceb8e9865fe444a237507c18b7a5f20eda1d4fb809b10f30
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.