Title: fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast · GitHub
Open Graph Title: fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast
X Title: fix: Keep description, tags and nested types of ODFV schema fields by Revinand · Pull Request #7091 · feast-dev/feast
Description: What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_exists_in_inferred checks specified_feature in inferred_features, which uses Field.__eq__ and compares the description, tags and vector settings. The inferred fields carry only a name and a type, and a scalar field with a description never matches. The check now compares the name and the type. With only that change, feast apply succeeds, but the view read back from the registry has an empty description. _parse_features_from_proto builds each Field from the name, the value type and the vector settings instead of calling Field.from_proto, which FeatureView and StreamFeatureView use. Besides the description and tags, it loses the inner types of nested outputs: Schema field type Type after OnDemandFeatureView.from_proto(odfv.to_proto()) on master Struct({a: Int64}) Struct({_value: String}) Array(Array(Int64)) Array(Array(String)) Array(Struct({a: Int64})) Array(Struct({_value: String})) _parse_features_from_proto now returns Field.from_proto(feature) for each feature. To reproduce, add description="val plus one" to a Field in the schema of an @on_demand_feature_view with a RequestSource, in a repo with the local provider and the SQLite online store, and run feast apply. On master it stops after "Applying changes for project repro" with SpecifiedFeaturesNotPresentError. With this change it prints "Created on demand feature view plus_one", and store.get_on_demand_feature_view("plus_one").features[0].description is 'val plus one'. Which issue(s) this PR fixes: Fixes #3617. The stale bot closed it in 2025 without a fix. It reports the first half; the registry round-trip has no issue. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc test_schema_field_metadata_survives_inference_and_proto_round_trip in tests/unit/test_on_demand_feature_view.py checks that the description and tags survive infer_features, that a proto round-trip returns the original fields, including Struct and nested Array types, and that a wrong type still raises SpecifiedFeaturesNotPresentError. It fails on master. test_on_demand_feature_view.py and test_on_demand_python_transformation.py pass, and ruff is clean. ODFVs that are already registered with Struct or nested outputs now load with their real inner types instead of _value: String.
Open Graph Description: What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_...
X Description: What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_...
Opengraph URL: https://github.com/feast-dev/feast/pull/7091
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:29a492be-b187-69f2-c86c-ba832948c1ad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9940:312218:161AD65:1D881A2:6AFEBBFB |
| html-safe-nonce | be3b15c4cfda53c34634dc653637a0a2449e5dd0488fe33a298b16cebb961806 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTQwOjMxMjIxODoxNjFBRDY1OjFEODgxQTI6NkFGRUJCRkIiLCJ2aXNpdG9yX2lkIjoiMTUxMDcyNDQwODUxNDEwMDIxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 66dda98846714be341f06d7bc947908892d49112a2b288fcdccc39e1418baa89 |
| hovercard-subject-tag | pull_request:5076027630 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7091/files |
| twitter:image | https://avatars.githubusercontent.com/u/7221855?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7221855?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: An on-demand feature view cannot have schema fields with a description or tags. feast apply fails on such a view with SpecifiedFeaturesNotPresentError. _feature_... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e1ce4c46d35aa8463a597a1bbffd4f0a456edb38 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width