René's URL Explorer Experiment


Title: feat: Add --gc-freeze option to feast serve by aborgatin · Pull Request #7089 · feast-dev/feast · GitHub

Open Graph Title: feat: Add --gc-freeze option to feast serve by aborgatin · Pull Request #7089 · feast-dev/feast

X Title: feat: Add --gc-freeze option to feast serve by aborgatin · Pull Request #7089 · feast-dev/feast

Description: What this PR does / why we need it: Adds an opt-in feast serve --gc-freeze flag, also available as feature_server.gc_freeze in feature_store.yaml. Full GC collections in a feature server worker walk the registry, feature definitions and protobuf classes that live for the whole process. Each one blocks the event loop for 50–75 ms, and the requests waiting at that moment look like slow online store reads. With the flag, the server runs gc.collect() and gc.freeze() in the gunicorn master after the app is built and before the workers fork. Workers inherit the frozen state, including the ones restarted by --max-requests. On Windows, where the server runs on uvicorn without gunicorn, it freezes after get_app. Off by default, so nothing changes for current users. Also adds a short "Garbage collection pauses" section to the performance tuning guide and the flag to the Python feature server reference. Which issue(s) this PR fixes: Fixes #7088 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit tests check the call order (collect, freeze, then the gunicorn run) for the flag and the config, and that nothing is frozen by default. Manual test: one worker, 15 req/s for 10 min. Requests over 50 ms went from 16 of 8,991 to 0 of 8,933, p99.9 from 61 to 29 ms. Also tested on a Kubernetes deployment with 0.65.0 and --max-requests, with the same result. Details in #7088.

Open Graph Description: What this PR does / why we need it: Adds an opt-in feast serve --gc-freeze flag, also available as feature_server.gc_freeze in feature_store.yaml. Full GC collections in a feature server worker wal...

X Description: What this PR does / why we need it: Adds an opt-in feast serve --gc-freeze flag, also available as feature_server.gc_freeze in feature_store.yaml. Full GC collections in a feature server worker wal...

Opengraph URL: https://github.com/feast-dev/feast/pull/7089

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4bbc39b9-5dd2-5e90-11b1-bc3068d72d9b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id965E:1325C0:DB44EF:1210BE5:6AFE9268
html-safe-nonce25faf3f4da762e2bb5762fda9bafd0985d432442564f26ed9a088b8409c93234
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjVFOjEzMjVDMDpEQjQ0RUY6MTIxMEJFNTo2QUZFOTI2OCIsInZpc2l0b3JfaWQiOiI0ODE1MjEzMjQxNzk1Nzc3MTI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5c8e384b9a69ef8c7170611119dd20a1dd65805b0cca7db2462f1897efc903e6
hovercard-subject-tagpull_request:5065787082
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7089/files
twitter:imagehttps://avatars.githubusercontent.com/u/43031807?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43031807?s=400&v=4
og:image:altWhat this PR does / why we need it: Adds an opt-in feast serve --gc-freeze flag, also available as feature_server.gc_freeze in feature_store.yaml. Full GC collections in a feature server worker wal...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7089/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7089%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7089%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7089/files
Reloadhttps://github.com/feast-dev/feast/pull/7089/files
Reloadhttps://github.com/feast-dev/feast/pull/7089/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
aborgatin:feat/serve-gc-freezehttps://github.com/aborgatin/feast/tree/feat/serve-gc-freeze
Conversation 4 https://github.com/feast-dev/feast/pull/7089
Commits 3 https://github.com/feast-dev/feast/pull/7089/commits
Checks 27 https://github.com/feast-dev/feast/pull/7089/checks
Files changed https://github.com/feast-dev/feast/pull/7089/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7089/files
feat: Add --gc-freeze option to feast serve https://github.com/feast-dev/feast/pull/7089/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/7089/files
bf59320 feat: Add --gc-freeze option to feast serve aborgatin Oct 28, 2026 https://github.com/feast-dev/feast/pull/7089/commits/bf593206571791775286a890d631f7a1f00f3457
4688541 Merge branch 'master' into feat/serve-gc-freeze aborgatin Nov 5, 2026 https://github.com/feast-dev/feast/pull/7089/commits/4688541dbc0826f9d8568ee1ebbbb20f2711eccb
cf86e1c Merge branch 'master' into feat/serve-gc-freeze aborgatin Nov 5, 2026 https://github.com/feast-dev/feast/pull/7089/commits/cf86e1c26a65f38001a81fe2d83139e9a7bce440
Clear filters https://github.com/feast-dev/feast/pull/7089/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7089/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7089/files
online-server-performance-tuning.md https://github.com/feast-dev/feast/pull/7089/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
python-feature-server.md https://github.com/feast-dev/feast/pull/7089/files#diff-e0f08582504cb3b6776117cc7b9e3ce82f07568e1a9d831f89b3027322909bb9
serve.py https://github.com/feast-dev/feast/pull/7089/files#diff-c83250fee981cae6660d6861e46709f6813ba216111d670d5c6279989a5cffaf
feature_server.py https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
feature_store.py https://github.com/feast-dev/feast/pull/7089/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
base_config.py https://github.com/feast-dev/feast/pull/7089/files#diff-d30cafde4bb641a4c1a28c0b30e490b13a858cd6bd35cc936b931e235fa96e37
test_feature_server_gc_freeze.py https://github.com/feast-dev/feast/pull/7089/files#diff-ed59299931fb655f4da2845bdab2a71c1e992bc2be75a642a9044a6d32bbbb63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/online-server-performance-tuning.mdhttps://github.com/feast-dev/feast/pull/7089/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/docs/how-to-guides/online-server-performance-tuning.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7089/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/7089/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/feature-servers/python-feature-server.mdhttps://github.com/feast-dev/feast/pull/7089/files#diff-e0f08582504cb3b6776117cc7b9e3ce82f07568e1a9d831f89b3027322909bb9
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/docs/reference/feature-servers/python-feature-server.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7089/files#diff-e0f08582504cb3b6776117cc7b9e3ce82f07568e1a9d831f89b3027322909bb9
https://github.com/feast-dev/feast/pull/7089/files#diff-e0f08582504cb3b6776117cc7b9e3ce82f07568e1a9d831f89b3027322909bb9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/cli/serve.pyhttps://github.com/feast-dev/feast/pull/7089/files#diff-c83250fee981cae6660d6861e46709f6813ba216111d670d5c6279989a5cffaf
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/sdk/python/feast/cli/serve.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7089/files#diff-c83250fee981cae6660d6861e46709f6813ba216111d670d5c6279989a5cffaf
https://github.com/feast-dev/feast/pull/7089/files#diff-c83250fee981cae6660d6861e46709f6813ba216111d670d5c6279989a5cffaf
https://github.com/feast-dev/feast/pull/7089/files#diff-c83250fee981cae6660d6861e46709f6813ba216111d670d5c6279989a5cffaf
https://github.com/feast-dev/feast/pull/7089/files#diff-c83250fee981cae6660d6861e46709f6813ba216111d670d5c6279989a5cffaf
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_server.pyhttps://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/sdk/python/feast/feature_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/7089/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/7089/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7089/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7089/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7089/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/feature_servers/base_config.pyhttps://github.com/feast-dev/feast/pull/7089/files#diff-d30cafde4bb641a4c1a28c0b30e490b13a858cd6bd35cc936b931e235fa96e37
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/sdk/python/feast/infra/feature_servers/base_config.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7089/files#diff-d30cafde4bb641a4c1a28c0b30e490b13a858cd6bd35cc936b931e235fa96e37
https://github.com/feast-dev/feast/pull/7089/files#diff-d30cafde4bb641a4c1a28c0b30e490b13a858cd6bd35cc936b931e235fa96e37
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_feature_server_gc_freeze.pyhttps://github.com/feast-dev/feast/pull/7089/files#diff-ed59299931fb655f4da2845bdab2a71c1e992bc2be75a642a9044a6d32bbbb63
View file https://github.com/aborgatin/feast/blob/cf86e1c26a65f38001a81fe2d83139e9a7bce440/sdk/python/tests/unit/test_feature_server_gc_freeze.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7089/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/7089/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.