René's URL Explorer Experiment


Title: fix: Key registry proto caches on the proto, not its id() by jiwidi · Pull Request #7085 · feast-dev/feast · GitHub

Open Graph Title: fix: Key registry proto caches on the proto, not its id() by jiwidi · Pull Request #7085 · feast-dev/feast

X Title: fix: Key registry proto caches on the proto, not its id() by jiwidi · Pull Request #7085 · feast-dev/feast

Description: What this PR does / why we need it: proto_registry_utils caches its results by id(registry_proto) and version_id. SqlRegistry leaves version_id empty. After a registry proto is freed, a new proto can get the same id(), and the cache then returns objects from the old registry. In our case write_to_online_store validated a vector against a feature view from an earlier FeatureStore and rejected valid rows. The caches now keep a reference to the proto and compare it by identity. The version_id and project keys are unchanged. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit: two live registry protos that share one id() (patched in the module) each get their own value from all three cache decorators. The test fails on the old code on every run. The existing registry cache tests pass unchanged. Misc Found while running a streaming writer against the Milvus online store; independent of the Milvus online store PRs.

Open Graph Description: What this PR does / why we need it: proto_registry_utils caches its results by id(registry_proto) and version_id. SqlRegistry leaves version_id empty. After a registry proto is freed, a new proto c...

X Description: What this PR does / why we need it: proto_registry_utils caches its results by id(registry_proto) and version_id. SqlRegistry leaves version_id empty. After a registry proto is freed, a new proto c...

Opengraph URL: https://github.com/feast-dev/feast/pull/7085

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23a7424d-e8d6-8214-9cb5-8da57e3b10b6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAFA:2979B2:E9F035:13DC347:6AFE9256
html-safe-noncecd23c40a1f9f2374c9a049013a02663585f3445fff62bae8c7bf203041569e94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUZBOjI5NzlCMjpFOUYwMzU6MTNEQzM0Nzo2QUZFOTI1NiIsInZpc2l0b3JfaWQiOiI1NTk3NDA3OTE0MDM0NjMxMjU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc35c81847abadfb84357aa1ca6c4e06b3e63fd0dd5cd7e5c7dc72439727ff9b1
hovercard-subject-tagpull_request:5049407921
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7085/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: proto_registry_utils caches its results by id(registry_proto) and version_id. SqlRegistry leaves version_id empty. After a registry proto is freed, a new proto c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7085/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7085%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7085%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7085/files
Reloadhttps://github.com/feast-dev/feast/pull/7085/files
Reloadhttps://github.com/feast-dev/feast/pull/7085/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:fix/registry-cache-proto-identityhttps://github.com/jiwidi/feast/tree/fix/registry-cache-proto-identity
Conversation 3 https://github.com/feast-dev/feast/pull/7085
Commits 4 https://github.com/feast-dev/feast/pull/7085/commits
Checks 23 https://github.com/feast-dev/feast/pull/7085/checks
Files changed https://github.com/feast-dev/feast/pull/7085/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7085/files
fix: Key registry proto caches on the proto, not its id() https://github.com/feast-dev/feast/pull/7085/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/7085/files
97ef1fa fix: Key registry proto caches on the proto, not its id() jiwidi Oct 26, 2026 https://github.com/feast-dev/feast/pull/7085/commits/97ef1fabaa17ab059cd4800054ec9e17d89298d5
3d1e110 style: Fix the import block spacing in proto_registry_utils jiwidi Oct 28, 2026 https://github.com/feast-dev/feast/pull/7085/commits/3d1e11059c56bb8f89fa62fcc87d1815c44d1bec
f7d5168 test: Make the registry cache id-reuse test deterministic jiwidi Oct 29, 2026 https://github.com/feast-dev/feast/pull/7085/commits/f7d5168162fcb8c9941ecb1616ce8aad43bc9a9c
ce071f1 Merge branch 'master' into fix/registry-cache-proto-identity shuchu Nov 4, 2026 https://github.com/feast-dev/feast/pull/7085/commits/ce071f1c8eb37269ba0c2bb5492b231c8a1af95d
Clear filters https://github.com/feast-dev/feast/pull/7085/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7085/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7085/files
proto_registry_utils.py https://github.com/feast-dev/feast/pull/7085/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
test_proto_registry_utils.py https://github.com/feast-dev/feast/pull/7085/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/registry/proto_registry_utils.pyhttps://github.com/feast-dev/feast/pull/7085/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
View file https://github.com/jiwidi/feast/blob/ce071f1c8eb37269ba0c2bb5492b231c8a1af95d/sdk/python/feast/infra/registry/proto_registry_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7085/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7085/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7085/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7085/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/registry/test_proto_registry_utils.pyhttps://github.com/feast-dev/feast/pull/7085/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
View file https://github.com/jiwidi/feast/blob/ce071f1c8eb37269ba0c2bb5492b231c8a1af95d/sdk/python/tests/unit/infra/registry/test_proto_registry_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7085/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7085/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
https://github.com/feast-dev/feast/pull/7085/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
https://github.com/feast-dev/feast/pull/7085/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
Please reload this pagehttps://github.com/feast-dev/feast/pull/7085/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.