René's URL Explorer Experiment


Title: fix: Break event timestamp ties by created timestamp in Milvus write batches by jiwidi · Pull Request #7084 · feast-dev/feast · GitHub

Open Graph Title: fix: Break event timestamp ties by created timestamp in Milvus write batches by jiwidi · Pull Request #7084 · feast-dev/feast

X Title: fix: Break event timestamp ties by created timestamp in Milvus write batches by jiwidi · Pull Request #7084 · feast-dev/feast

Description: What this PR does / why we need it: When a batch holds two rows for one entity, the Milvus store keeps one of them. It kept the row with the latest event timestamp and, on a tie, the first row of the batch, whatever its created timestamp. The offline stores break such a tie on the created timestamp, and the Redis online store writes rows in order so the last one wins. A correction that carries the same event timestamp and a newer created timestamp was lost. Rows for one entity in a batch Before After different event timestamps latest event timestamp wins unchanged same event timestamp, different created timestamps first row wins latest created timestamp wins same event and created timestamps first row wins last row of the batch wins This orders rows within one batch. The Redis store also skips a row whose event timestamp is older than the stored one; in Milvus that needs a read before every write and is left for a later PR. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit (Milvus Lite): the four cases of the table, with the rows in both orders; a batch with two entities keeps both. Server: two rows with the same event timestamp; the one with the newer created timestamp is read back with Strong consistency. Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). The server test in sdk/python/tests/integration/online_store/test_milvus_remote.py passes against a local Milvus 3.0.2 server. The existing Milvus unit and server tests pass unchanged. Misc Part of a stack that adds to the Milvus online store the update and delete functionality the Redis online store has, following #6882, #6895, #6917, #6921 and #6940. The other PRs of the stack are #7082 (row deletion) and #7083 (partition options). mutation_timeout and a schema mismatch check follow once these merge.

Open Graph Description: What this PR does / why we need it: When a batch holds two rows for one entity, the Milvus store keeps one of them. It kept the row with the latest event timestamp and, on a tie, the first row of t...

X Description: What this PR does / why we need it: When a batch holds two rows for one entity, the Milvus store keeps one of them. It kept the row with the latest event timestamp and, on a tie, the first row of t...

Opengraph URL: https://github.com/feast-dev/feast/pull/7084

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c00439b9-c126-382d-1724-9bcd041705f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9654:10CB0:DF2398:12502EB:6AFE9266
html-safe-nonceaf310dfcf5a175cc45061e70e12be098e39eacf0d3c716483e1c942837ecdd1a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjU0OjEwQ0IwOkRGMjM5ODoxMjUwMkVCOjZBRkU5MjY2IiwidmlzaXRvcl9pZCI6Ijg0MDA1MTQ1MjYyODg2NTYzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca2b40c270b8a76e91d0c2eebef0537b784a82089f3295db0ad88e47d3adf645f
hovercard-subject-tagpull_request:5049407344
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7084/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: When a batch holds two rows for one entity, the Milvus store keeps one of them. It kept the row with the latest event timestamp and, on a tie, the first row of t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7084/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7084%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7084%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7084/files
Reloadhttps://github.com/feast-dev/feast/pull/7084/files
Reloadhttps://github.com/feast-dev/feast/pull/7084/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:fix/milvus-write-tie-breakhttps://github.com/jiwidi/feast/tree/fix/milvus-write-tie-break
Conversation 5 https://github.com/feast-dev/feast/pull/7084
Commits 6 https://github.com/feast-dev/feast/pull/7084/commits
Checks 22 https://github.com/feast-dev/feast/pull/7084/checks
Files changed https://github.com/feast-dev/feast/pull/7084/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7084/files
fix: Break event timestamp ties by created timestamp in Milvus write batches https://github.com/feast-dev/feast/pull/7084/files#top
Show all changes 6 commits https://github.com/feast-dev/feast/pull/7084/files
050c297 fix: Break event timestamp ties by created timestamp in Milvus write … jiwidi Oct 28, 2026 https://github.com/feast-dev/feast/pull/7084/commits/050c297e33db280a966008db3e788dcf4d90cd23
411f2e3 test: Cover a Milvus write batch with several entities jiwidi Oct 28, 2026 https://github.com/feast-dev/feast/pull/7084/commits/411f2e3c57081f61b2b979f5588cc341064dc047
47b55ee Merge branch 'master' into fix/milvus-write-tie-break jiwidi Nov 4, 2026 https://github.com/feast-dev/feast/pull/7084/commits/47b55eeab2b2f8571f787649a74b35b5f6269e6f
cc887bd Merge branch 'master' into fix/milvus-write-tie-break jiwidi Nov 5, 2026 https://github.com/feast-dev/feast/pull/7084/commits/cc887bd05ffab1080605fdff3a8b77c37739c305
3ad7ebd Merge branch 'master' into fix/milvus-write-tie-break jiwidi Nov 6, 2026 https://github.com/feast-dev/feast/pull/7084/commits/3ad7ebdd56dcd66a058d9327248044f5fdf7a03a
58efdec Merge branch 'master' into fix/milvus-write-tie-break shuchu Nov 6, 2026 https://github.com/feast-dev/feast/pull/7084/commits/58efdec475687d70ba3aaa509bc237b166546cc6
Clear filters https://github.com/feast-dev/feast/pull/7084/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7084/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7084/files
milvus.py https://github.com/feast-dev/feast/pull/7084/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_remote.py https://github.com/feast-dev/feast/pull/7084/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/7084/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.pyhttps://github.com/feast-dev/feast/pull/7084/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
View file https://github.com/jiwidi/feast/blob/58efdec475687d70ba3aaa509bc237b166546cc6/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7084/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7084/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7084/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/online_store/test_milvus_remote.pyhttps://github.com/feast-dev/feast/pull/7084/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
View file https://github.com/jiwidi/feast/blob/58efdec475687d70ba3aaa509bc237b166546cc6/sdk/python/tests/integration/online_store/test_milvus_remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7084/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7084/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
https://github.com/feast-dev/feast/pull/7084/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_milvus_online_store.pyhttps://github.com/feast-dev/feast/pull/7084/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
View file https://github.com/jiwidi/feast/blob/58efdec475687d70ba3aaa509bc237b166546cc6/sdk/python/tests/unit/infra/online_store/test_milvus_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7084/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7084/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/pull/7084/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
Please reload this pagehttps://github.com/feast-dev/feast/pull/7084/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.