René's URL Explorer Experiment


Title: feat: Add row deletion to the Milvus online store by jiwidi · Pull Request #7082 · feast-dev/feast · GitHub

Open Graph Title: feat: Add row deletion to the Milvus online store by jiwidi · Pull Request #7082 · feast-dev/feast

X Title: feat: Add row deletion to the Milvus online store by jiwidi · Pull Request #7082 · feast-dev/feast

Description: What this PR does / why we need it: The Redis online store can remove rows: delete_entity_values removes the rows of an entity and delete_table removes the rows of a feature view. The Milvus online store has nothing between upsert and drop_collection, so a row cannot be removed when its entity leaves the data set, for example a product that is no longer sold. This PR adds MilvusOnlineStore.online_delete, which deletes by entity key or by filter: Call Behaviour entity_keys=[...] Deletes by primary key, with the same serialized entity key that writes and reads use. filters=ComparisonFilter(...) or CompoundFilter(...) Deletes the rows the filter selects, through the existing MilvusFilterTranslator. entity_keys=[] Deletes nothing. both or neither ValueError. a filter with an empty group, at any level ValueError, so a mistake cannot delete more rows than it names. missing collection Returns without creating it. from feast.filter_models import ComparisonFilter online_store.online_delete(config, feature_view, entity_keys=[entity_key]) online_store.online_delete( config, feature_view, filters=ComparisonFilter(type="eq", key="brand_id", value="acme") ) It works on every collection Feast created, whichever settings created it. No tombstone is kept: a later write creates the row again, and Feast does not order a delete against writes from other processes. The method is store-level, like the Redis delete methods; a FeatureStore-level API can follow once more stores implement it. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit (Milvus Lite): delete by entity key leaves the other rows; delete by filter; a deleted row can be written again. Unit (mocked client): both or neither selector and a filter with an empty group are rejected before any call; a missing collection is neither created nor queried; an empty key list does not even connect. Server: delete by key and by filter are visible to the next Strong read; the row can be written again. Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). The server test in sdk/python/tests/integration/online_store/test_milvus_remote.py passes against a local Milvus 3.0.2 server. The existing Milvus unit and server tests pass unchanged. Misc Part of a stack that adds to the Milvus online store the update and delete functionality the Redis online store has, following #6882, #6895, #6917, #6921 and #6940. The other PRs of the stack are #7083 (partition options) and #7084 (tie-break in write batches). mutation_timeout and a schema mismatch check follow once these merge.

Open Graph Description: What this PR does / why we need it: The Redis online store can remove rows: delete_entity_values removes the rows of an entity and delete_table removes the rows of a feature view. The Milvus online...

X Description: What this PR does / why we need it: The Redis online store can remove rows: delete_entity_values removes the rows of an entity and delete_table removes the rows of a feature view. The Milvus online...

Opengraph URL: https://github.com/feast-dev/feast/pull/7082

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ce484a2e-4930-7971-cb76-7738625cfbf4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9686:342711:19BF67:22785F:6AFE926A
html-safe-nonce9a664e1c5e8c89fadaac8cf460fa0565e57b26c780e46d6dff3a646cd2ab053c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Njg2OjM0MjcxMToxOUJGNjc6MjI3ODVGOjZBRkU5MjZBIiwidmlzaXRvcl9pZCI6IjU1NzcyMDAzMTYyNDUyNTA2NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1941aaaa0f2c7405c9d561092059d4fb6e83301827ab1fc4beefbcaf91851c75
hovercard-subject-tagpull_request:5049406210
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7082/files
twitter:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10882086?s=400&v=4
og:image:altWhat this PR does / why we need it: The Redis online store can remove rows: delete_entity_values removes the rows of an entity and delete_table removes the rows of a feature view. The Milvus online...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7082/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7082%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7082%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7082/files
Reloadhttps://github.com/feast-dev/feast/pull/7082/files
Reloadhttps://github.com/feast-dev/feast/pull/7082/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
jiwidi:feat/milvus-online-deletehttps://github.com/jiwidi/feast/tree/feat/milvus-online-delete
Conversation 5 https://github.com/feast-dev/feast/pull/7082
Commits 5 https://github.com/feast-dev/feast/pull/7082/commits
Checks 23 https://github.com/feast-dev/feast/pull/7082/checks
Files changed https://github.com/feast-dev/feast/pull/7082/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7082/files
feat: Add row deletion to the Milvus online store https://github.com/feast-dev/feast/pull/7082/files#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/7082/files
f41159d feat: Add row deletion to the Milvus online store jiwidi Oct 28, 2026 https://github.com/feast-dev/feast/pull/7082/commits/f41159d038241b16a71c3d8094184bc4a83dd82b
cb241ef test: Cover online_delete with an empty entity key list jiwidi Oct 28, 2026 https://github.com/feast-dev/feast/pull/7082/commits/cb241ef0f3df3da917ba1a3db2fea5d43b8524b5
b611fa7 fix: Reject an empty group anywhere in the Milvus deletion filter jiwidi Oct 29, 2026 https://github.com/feast-dev/feast/pull/7082/commits/b611fa71fe7afc490f4ac8d114f439e6f19f2d45
408fc54 ci: Re-run the checks after a macOS runner timeout jiwidi Oct 29, 2026 https://github.com/feast-dev/feast/pull/7082/commits/408fc5479c9f7c765d4dda94c4e048966e31182d
dd64a31 Merge branch 'master' into feat/milvus-online-delete shuchu Nov 4, 2026 https://github.com/feast-dev/feast/pull/7082/commits/dd64a31c7e91ac23807d8c46b046717ab91d6616
Clear filters https://github.com/feast-dev/feast/pull/7082/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7082/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7082/files
milvus.md https://github.com/feast-dev/feast/pull/7082/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
milvus.py https://github.com/feast-dev/feast/pull/7082/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_remote.py https://github.com/feast-dev/feast/pull/7082/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/7082/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/milvus.mdhttps://github.com/feast-dev/feast/pull/7082/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
View file https://github.com/jiwidi/feast/blob/dd64a31c7e91ac23807d8c46b046717ab91d6616/docs/reference/online-stores/milvus.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7082/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7082/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7082/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.pyhttps://github.com/feast-dev/feast/pull/7082/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
View file https://github.com/jiwidi/feast/blob/dd64a31c7e91ac23807d8c46b046717ab91d6616/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7082/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7082/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7082/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7082/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7082/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/integration/online_store/test_milvus_remote.pyhttps://github.com/feast-dev/feast/pull/7082/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
View file https://github.com/jiwidi/feast/blob/dd64a31c7e91ac23807d8c46b046717ab91d6616/sdk/python/tests/integration/online_store/test_milvus_remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7082/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7082/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_milvus_online_store.pyhttps://github.com/feast-dev/feast/pull/7082/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
View file https://github.com/jiwidi/feast/blob/dd64a31c7e91ac23807d8c46b046717ab91d6616/sdk/python/tests/unit/infra/online_store/test_milvus_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7082/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7082/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/pull/7082/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/pull/7082/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
Please reload this pagehttps://github.com/feast-dev/feast/pull/7082/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.