René's URL Explorer Experiment


Title: fix: Refresh pre-computed vectors for pushes with source field mappings by chandlerok · Pull Request #7076 · feast-dev/feast · GitHub

Open Graph Title: fix: Refresh pre-computed vectors for pushes with source field mappings by chandlerok · Pull Request #7076 · feast-dev/feast

X Title: fix: Refresh pre-computed vectors for pushes with source field mappings by chandlerok · Pull Request #7076 · feast-dev/feast

Description: What this PR does / why we need it: precompute_online=True must survive a store that takes pushes whose columns are named by the source. push() hands the frame to _precompute_for_push before ingestion has applied batch_source.field_mapping, so deriving entity keys from the raw frame found no join keys (raw_driver_id vs driver_id). The online row was written, the push hook returned early, and the pre-computed vector stayed stale — or stayed missing for a new entity. This PR maps the pushed frame the same way ingestion does (batch_source.field_mapping) before extracting the distinct entity keys, so the refresh follows the write. The rest of the pushed-entity refresh — the entity_keys parameter on precompute_feature_service, the _precompute_for_push hook, and bare-name matching in _try_precomputed_fast_path — is already on master (the follow-ups to #6463, including #7077). After merging master, the net diff here is the field-mapping fix and its regression test. Which issue(s) this PR fixes: Fixes #7074 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New unit tests: test_maps_source_columns_before_building_entity_keys — the push hook derives entity keys from the field-mapped frame. test_push_with_field_mapping_refreshes_precomputed_vector — public push → get_online_features regression: push score=0.5, read 0.5, push score=0.9 to the same entity under raw_driver_id, read 0.9. Fails without the fix. Locally: test_precomputed_feature_vectors.py (72 tests) and tests/unit/infra/online_store + test_feature_server.py (531 tests) pass; ruff check, ruff format --check and mypy are clean. Misc @ntkathole @franciscojavierarceo — conflicts are resolved by merging master, and the note about source field mappings is addressed above. 🤖 Generated with Claude Code

Open Graph Description: What this PR does / why we need it: precompute_online=True must survive a store that takes pushes whose columns are named by the source. push() hands the frame to _precompute_for_push before ingest...

X Description: What this PR does / why we need it: precompute_online=True must survive a store that takes pushes whose columns are named by the source. push() hands the frame to _precompute_for_push before ingest...

Opengraph URL: https://github.com/feast-dev/feast/pull/7076

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:258546a4-556c-5cdc-bbfa-b8ef37910569
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98FA:340002:EEA367:1462D3C:6AFE955C
html-safe-noncea6602c4aac9b227dbdaad1d3073227f081df7ef40b20d7365acaac4cae97acfc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEZBOjM0MDAwMjpFRUEzNjc6MTQ2MkQzQzo2QUZFOTU1QyIsInZpc2l0b3JfaWQiOiI1MDI1MTkzMzg1NDQzMzY2MjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7585c0ccc6dc283348012ea014e680d878ea7fe1afe133eb08c10959dec72d72
hovercard-subject-tagpull_request:5026101632
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7076/files
twitter:imagehttps://avatars.githubusercontent.com/u/45566625?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45566625?s=400&v=4
og:image:altWhat this PR does / why we need it: precompute_online=True must survive a store that takes pushes whose columns are named by the source. push() hands the frame to _precompute_for_push before ingest...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7076/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7076%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7076%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7076/files
Reloadhttps://github.com/feast-dev/feast/pull/7076/files
Reloadhttps://github.com/feast-dev/feast/pull/7076/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
chandlerok:fix/precompute-refresh-pushed-entitieshttps://github.com/chandlerok/feast/tree/fix/precompute-refresh-pushed-entities
Conversation 6 https://github.com/feast-dev/feast/pull/7076
Commits 8 https://github.com/feast-dev/feast/pull/7076/commits
Checks 23 https://github.com/feast-dev/feast/pull/7076/checks
Files changed 2 https://github.com/feast-dev/feast/pull/7076/files
fix: Refresh pre-computed vectors for pushes with source field mappings https://github.com/feast-dev/feast/pull/7076/files#top
Show all changes 8 commits https://github.com/feast-dev/feast/pull/7076/files
984def1 feat: Refresh pre-computed vectors for pushed entities only chandlerok Oct 26, 2026 https://github.com/feast-dev/feast/pull/7076/commits/984def18dbb5c5cd6ce6495a709c7257a34c1265
5262d64 fix: Match pre-computed vector names when full_feature_names is False chandlerok Oct 26, 2026 https://github.com/feast-dev/feast/pull/7076/commits/5262d64487ce40cca5c37b6d4449be4d11409cf8
8ea9cd9 chore: Retrigger CI chandlerok Oct 29, 2026 https://github.com/feast-dev/feast/pull/7076/commits/8ea9cd91ef7d533dd6e65c6ee8e13086815f613a
07667a7 Merge branch 'master' into fix/precompute-refresh-pushed-entities chandlerok Nov 17, 2026 https://github.com/feast-dev/feast/pull/7076/commits/07667a76c7d3c3bdafb7cc665cf5bdcccee59d74
8f5b6e5 fix: Preserve vector refreshes for pushes with field mappings chandlerok Nov 17, 2026 https://github.com/feast-dev/feast/pull/7076/commits/8f5b6e58741ddc56337afc89054239aba46a4576
d39de95 chore: Retrigger CI chandlerok Nov 17, 2026 https://github.com/feast-dev/feast/pull/7076/commits/d39de95ea19ea38e54a0493383d1daf2eb38b875
8ef0d5d chore: Retrigger CI chandlerok Nov 18, 2026 https://github.com/feast-dev/feast/pull/7076/commits/8ef0d5d06a5d6b90bf3f7af1d3488bcfca661f8c
0f1c844 Merge branch 'master' into fix/precompute-refresh-pushed-entities ntkathole Nov 18, 2026 https://github.com/feast-dev/feast/pull/7076/commits/0f1c84411f94cb79c882a7d126fe6c1a4f6878ec
Clear filters https://github.com/feast-dev/feast/pull/7076/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7076/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7076/files
feature_store.py https://github.com/feast-dev/feast/pull/7076/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
test_precomputed_feature_vectors.py https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/7076/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/chandlerok/feast/blob/0f1c84411f94cb79c882a7d126fe6c1a4f6878ec/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7076/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7076/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/7076/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_precomputed_feature_vectors.pyhttps://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
View file https://github.com/chandlerok/feast/blob/0f1c84411f94cb79c882a7d126fe6c1a4f6878ec/sdk/python/tests/unit/test_precomputed_feature_vectors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7076/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/7076/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
Please reload this pagehttps://github.com/feast-dev/feast/pull/7076/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.