René's URL Explorer Experiment


Title: perf: Key registry proto caches on version_id so a refresh does not rebuild objects by chandlerok · Pull Request #7073 · feast-dev/feast · GitHub

Open Graph Title: perf: Key registry proto caches on version_id so a refresh does not rebuild objects by chandlerok · Pull Request #7073 · feast-dev/feast

X Title: perf: Key registry proto caches on version_id so a refresh does not rebuild objects by chandlerok · Pull Request #7073 · feast-dev/feast

Description: What this PR does / why we need it: The registry_proto_cache decorators in proto_registry_utils keyed on id(registry_proto) as well as version_id. A registry refresh parses a new proto object, so every refresh missed the cache and rebuilt every object from proto even when the registry had not changed. With 14 feature services that rebuild is about 35 ms per refresh, most of it typeguard checks in Field.__init__. Measured locally with a file registry, refresh plus list_feature_services(allow_cache=True): per refresh before 34.9 ms after 0.1 ms Changes: Key the three cache decorators on version_id alone. A registry without a version_id falls back to object identity, which is today's behavior. Cache get_feature_service per version with the existing registry_proto_cache_name decorator. get_online_features calls it on every request and it rebuilt the FeatureService from proto each time, about 2 ms per call. Stamp SqlRegistry.proto() and SnowflakeRegistry.proto() with a version_id. Neither set one, so for those registries the caches would have kept falling back to object identity and missing on every refresh. The value is the sha1 of the deterministic serialization, stable across refreshes and different after any apply or delete. On a 421 KB proto the hash costs 0.2 ms. The file, S3, GCS, Azure, and HDFS stores already stamp a uuid on each write. Profiled effect on get_online_features with a file registry, 100 entities, 4 feature views: a warm read has no from_proto or typeguard frames left on the registry side. The first read after a refresh costs 14.2 ms against 19.6 ms with the old object-identity key, and the same 5 ms saving now applies to SQL-registry deployments once per cache refresh. No behavior change for callers. Cached objects were already shared between calls on the same proto object. Which issue(s) this PR fixes: Refs #7072 (proposal 3) Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit tests cover a re-parsed proto with the same version_id hitting the cache, a new version_id missing it, registries without a version_id staying per-object, get_feature_service returning the cached object, and a SQL registry whose version_id is stable across proto() calls and refreshes and changes after an apply. sdk/python/tests/unit/infra/registry passes locally (164 tests; three modules skip collection for missing optional dependencies).

Open Graph Description: What this PR does / why we need it: The registry_proto_cache decorators in proto_registry_utils keyed on id(registry_proto) as well as version_id. A registry refresh parses a new proto object, so e...

X Description: What this PR does / why we need it: The registry_proto_cache decorators in proto_registry_utils keyed on id(registry_proto) as well as version_id. A registry refresh parses a new proto object, so e...

Opengraph URL: https://github.com/feast-dev/feast/pull/7073

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93101f82-3b7e-df66-dc8d-624f34aa28e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA956:1B2C16:1012DA1:15D66AE:6AFE9878
html-safe-nonce0a849d9e49230c45456ed6aa8bc1cc6c293169d701e81834d3c33b0215db6d0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTU2OjFCMkMxNjoxMDEyREExOjE1RDY2QUU6NkFGRTk4NzgiLCJ2aXNpdG9yX2lkIjoiNDk4NzA5MDA3MTk3NTc5NDgwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccbb6aa1a4b5bdd638d9feb1f99deb6e9fb4e116a7006f8202f7677face382207
hovercard-subject-tagpull_request:5025709632
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7073/files
twitter:imagehttps://avatars.githubusercontent.com/u/45566625?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45566625?s=400&v=4
og:image:altWhat this PR does / why we need it: The registry_proto_cache decorators in proto_registry_utils keyed on id(registry_proto) as well as version_id. A registry refresh parses a new proto object, so e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7073/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7073%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7073%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7073/files
Reloadhttps://github.com/feast-dev/feast/pull/7073/files
Reloadhttps://github.com/feast-dev/feast/pull/7073/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
chandlerokhttps://github.com/chandlerok
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
chandlerok:perf/online-response-arrow-and-registry-cachehttps://github.com/chandlerok/feast/tree/perf/online-response-arrow-and-registry-cache
Conversation 7 https://github.com/feast-dev/feast/pull/7073
Commits 3 https://github.com/feast-dev/feast/pull/7073/commits
Checks 22 https://github.com/feast-dev/feast/pull/7073/checks
Files changed https://github.com/feast-dev/feast/pull/7073/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7073/files
perf: Key registry proto caches on version_id so a refresh does not rebuild objects https://github.com/feast-dev/feast/pull/7073/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/7073/files
7deb605 perf: Key registry proto caches on version_id so a refresh does not r… chandlerok Oct 26, 2026 https://github.com/feast-dev/feast/pull/7073/commits/7deb605f08b4d239ca887d489a5b9d6e3f6439e1
a74e783 perf: Stamp SQL and Snowflake registry protos with a content-hash ver… chandlerok Oct 26, 2026 https://github.com/feast-dev/feast/pull/7073/commits/a74e7830f4d1968a6e035a4342b84b2c6a0ea2a9
87deb2f Merge branch 'master' into perf/online-response-arrow-and-registry-cache shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7073/commits/87deb2fb6b21f51955f73340547c5e1c4a7d1a52
Clear filters https://github.com/feast-dev/feast/pull/7073/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7073/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7073/files
proto_registry_utils.py https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
snowflake.py https://github.com/feast-dev/feast/pull/7073/files#diff-d30055e36a0d91416fa2c53782809c120e5d63b886ab4aceda70ba92407bbad2
sql.py https://github.com/feast-dev/feast/pull/7073/files#diff-c6193043c77bd411f332b1a92fc0d92f4f3011787438f1515454a2854b10beda
test_proto_registry_utils.py https://github.com/feast-dev/feast/pull/7073/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
test_sql_registry.py https://github.com/feast-dev/feast/pull/7073/files#diff-012108ddb480dcae8037d27c9826769dcea359e2c87ea799b5b1e105026b92d0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/registry/proto_registry_utils.pyhttps://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
View file https://github.com/feast-dev/feast/blob/87deb2fb6b21f51955f73340547c5e1c4a7d1a52/sdk/python/feast/infra/registry/proto_registry_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7073/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/pull/7073/files#diff-0da2fb3694cff37219d3787d0b9037fa87c0299de63a5e2d1828ad860a2a5cfb
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/registry/snowflake.pyhttps://github.com/feast-dev/feast/pull/7073/files#diff-d30055e36a0d91416fa2c53782809c120e5d63b886ab4aceda70ba92407bbad2
View file https://github.com/feast-dev/feast/blob/87deb2fb6b21f51955f73340547c5e1c4a7d1a52/sdk/python/feast/infra/registry/snowflake.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7073/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7073/files#diff-d30055e36a0d91416fa2c53782809c120e5d63b886ab4aceda70ba92407bbad2
https://github.com/feast-dev/feast/pull/7073/files#diff-d30055e36a0d91416fa2c53782809c120e5d63b886ab4aceda70ba92407bbad2
https://github.com/feast-dev/feast/pull/7073/files#diff-d30055e36a0d91416fa2c53782809c120e5d63b886ab4aceda70ba92407bbad2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/registry/sql.pyhttps://github.com/feast-dev/feast/pull/7073/files#diff-c6193043c77bd411f332b1a92fc0d92f4f3011787438f1515454a2854b10beda
View file https://github.com/feast-dev/feast/blob/87deb2fb6b21f51955f73340547c5e1c4a7d1a52/sdk/python/feast/infra/registry/sql.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7073/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7073/files#diff-c6193043c77bd411f332b1a92fc0d92f4f3011787438f1515454a2854b10beda
https://github.com/feast-dev/feast/pull/7073/files#diff-c6193043c77bd411f332b1a92fc0d92f4f3011787438f1515454a2854b10beda
https://github.com/feast-dev/feast/pull/7073/files#diff-c6193043c77bd411f332b1a92fc0d92f4f3011787438f1515454a2854b10beda
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/registry/test_proto_registry_utils.pyhttps://github.com/feast-dev/feast/pull/7073/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
View file https://github.com/feast-dev/feast/blob/87deb2fb6b21f51955f73340547c5e1c4a7d1a52/sdk/python/tests/unit/infra/registry/test_proto_registry_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7073/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7073/files#diff-5cd62fdbdb629abb3f381b54964ee0542e830be052266b8bbafe6928e53ee497
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/registry/test_sql_registry.pyhttps://github.com/feast-dev/feast/pull/7073/files#diff-012108ddb480dcae8037d27c9826769dcea359e2c87ea799b5b1e105026b92d0
View file https://github.com/feast-dev/feast/blob/87deb2fb6b21f51955f73340547c5e1c4a7d1a52/sdk/python/tests/unit/infra/registry/test_sql_registry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7073/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7073/files#diff-012108ddb480dcae8037d27c9826769dcea359e2c87ea799b5b1e105026b92d0
Please reload this pagehttps://github.com/feast-dev/feast/pull/7073/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.