René's URL Explorer Experiment


Title: fix: Preserve colliding source timestamps in Dask retrieval by AryanRG · Pull Request #7071 · feast-dev/feast · GitHub

Open Graph Title: fix: Preserve colliding source timestamps in Dask retrieval by AryanRG · Pull Request #7071 · feast-dev/feast

X Title: fix: Preserve colliding source timestamps in Dask retrieval by AryanRG · Pull Request #7071 · feast-dev/feast

Description: What this PR does / why we need it: When a source created timestamp shares a name with a request column, Dask historical retrieval can read the request value instead. This can include a backfill created after the query time or remove a request column from the result. Keep the source timestamp under a temporary name that cannot collide with request or feature columns. Regression tests cover timestamp filtering, preserved request data and multiple feature views. Which issue(s) this PR fixes: No existing issue. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Focused tests and neighboring Dask tests pass, along with scoped Ruff and mypy checks. The regression uses local Parquet files through the public FeatureStore API.

Open Graph Description: What this PR does / why we need it: When a source created timestamp shares a name with a request column, Dask historical retrieval can read the request value instead. This can include a backfill cr...

X Description: What this PR does / why we need it: When a source created timestamp shares a name with a request column, Dask historical retrieval can read the request value instead. This can include a backfill cr...

Opengraph URL: https://github.com/feast-dev/feast/pull/7071

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a8a0e828-681b-5ec5-44d8-deab3fc2551b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90EC:11F29A:DCFA49:121CFBA:6AFE8F9E
html-safe-nonceab4c70b4a9e7cb9570fcf2bcdd232353ede4edbc0cca941b5d4535c0866baa76
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEVDOjExRjI5QTpEQ0ZBNDk6MTIxQ0ZCQTo2QUZFOEY5RSIsInZpc2l0b3JfaWQiOiI4MDEwMzM5MjMyNjI1MTAyNzUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5f61602316243d19c3c117ed6e4aef9ad978cdcde421f22a0b3b1129421f7a82
hovercard-subject-tagpull_request:5013588959
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7071/files
twitter:imagehttps://avatars.githubusercontent.com/u/51299383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/51299383?s=400&v=4
og:image:altWhat this PR does / why we need it: When a source created timestamp shares a name with a request column, Dask historical retrieval can read the request value instead. This can include a backfill cr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7071/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7071%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7071%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7071/files
Reloadhttps://github.com/feast-dev/feast/pull/7071/files
Reloadhttps://github.com/feast-dev/feast/pull/7071/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
AryanRG:fix/dask-created-timestamp-collisionhttps://github.com/AryanRG/feast/tree/fix/dask-created-timestamp-collision
Conversation 1 https://github.com/feast-dev/feast/pull/7071
Commits 2 https://github.com/feast-dev/feast/pull/7071/commits
Checks 1 https://github.com/feast-dev/feast/pull/7071/checks
Files changed https://github.com/feast-dev/feast/pull/7071/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7071/files
fix: Preserve colliding source timestamps in Dask retrieval https://github.com/feast-dev/feast/pull/7071/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7071/files
4bb21b2 fix: Preserve colliding source timestamps in Dask retrieval AryanRG Oct 26, 2026 https://github.com/feast-dev/feast/pull/7071/commits/4bb21b216625455cb6cb01e7244bdc88f34fe429
b8a5bfe Merge branch 'master' into fix/dask-created-timestamp-collision shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7071/commits/b8a5bfe6f2a425c5d02ee6f3ade117b064329ac8
Clear filters https://github.com/feast-dev/feast/pull/7071/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7071/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7071/files
dask.py https://github.com/feast-dev/feast/pull/7071/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
test_dask_created_timestamp_collision.py https://github.com/feast-dev/feast/pull/7071/files#diff-d3b915aa83bbd5c4832dc3c6e091d4ff8b8552df0b2e1916d0a7470dbd2dfd43
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/dask.pyhttps://github.com/feast-dev/feast/pull/7071/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
View file https://github.com/AryanRG/feast/blob/b8a5bfe6f2a425c5d02ee6f3ade117b064329ac8/sdk/python/feast/infra/offline_stores/dask.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7071/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7071/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/7071/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/test_dask_created_timestamp_collision.pyhttps://github.com/feast-dev/feast/pull/7071/files#diff-d3b915aa83bbd5c4832dc3c6e091d4ff8b8552df0b2e1916d0a7470dbd2dfd43
View file https://github.com/AryanRG/feast/blob/b8a5bfe6f2a425c5d02ee6f3ade117b064329ac8/sdk/python/tests/unit/infra/offline_stores/test_dask_created_timestamp_collision.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7071/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.