René's URL Explorer Experiment


Title: fix: Validate entity column types in feast dbt import by NopeCharon · Pull Request #7067 · feast-dev/feast · GitHub

Open Graph Title: fix: Validate entity column types in feast dbt import by NopeCharon · Pull Request #7067 · feast-dev/feast

X Title: fix: Validate entity column types in feast dbt import by NopeCharon · Pull Request #7067 · feast-dev/feast

Description: What this PR does / why we need it: feast dbt import only checks that the entity columns exist. Their type is never looked at: A model whose entity column is declared FLOAT64, BOOLEAN, BYTES or TIMESTAMP imports silently, and Feast creates an entity keyed on a floating point, boolean, binary or timestamp value. A model with an ARRAY<...> entity column crashes the whole import with an unhandled ValueError: Entity driver_id has type ValueType.STRING, which does not match the inferred type Array(...) raised from FeatureView.__init__. With this PR, the import maps each entity column's dbt type through the existing map_dbt_type_to_feast_type mapping and then: Array entity column: the model is skipped with a warning (Model '...' has array entity column(s): ... Skipping.). This matches how models missing an entity or timestamp column are handled. Any type other than String, Int32 or Int64: a warning names the dbt type and the Feast type it maps to, and the model is still imported. For example: Warning: Model 'driver_features' entity column 'conv_rate' has type 'float64' (Feast type Float64), which may not be suitable as an entity key. Recommended types: STRING, INT64. Importing anyway. This also flags Snowflake's NUMBER(38,0), which the mapping turns into Float64. No data_type: columns without one default to STRING and do not warn. The models used for the summary and for --output code generation are now collected as they are processed, instead of being recomputed afterwards from column presence. Otherwise a skipped model would still be written into the generated file. The dbt how-to documents the check and the two new warnings in its Requirements and Troubleshooting sections. Which issue(s) this PR fixes: Fixes #5876 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit tests: the new sdk/python/tests/unit/dbt/test_entity_column_type.py builds manifests and runs feast dbt import through the CLI. It covers: a warning for FLOAT64, NUMBER(38,0), BOOLEAN, BYTES and TIMESTAMP, with the model still imported no warning for STRING, VARCHAR(36), INT64, INTEGER, NUMBER(10,0) and an undeclared type with several entity columns, only the unsuitable one warns a model with an ARRAY entity column is skipped, and with --output it is left out of the generated file while the other model is kept Seven of these cases fail on master (the array case with the ValueError above). All 50 tests in tests/unit/dbt pass. Integration tests: make test-python-integration-dbt (dbt-core + dbt-duckdb) passes, 84 tests. Manual tests: ran feast dbt import --dry-run against the integration project's generated manifest with -e driver_id (no warning) and -e conv_rate (warning shown). Static checks: scoped ruff check, ruff format --check and mypy are clean.

Open Graph Description: What this PR does / why we need it: feast dbt import only checks that the entity columns exist. Their type is never looked at: A model whose entity column is declared FLOAT64, BOOLEAN, BYTES or TI...

X Description: What this PR does / why we need it: feast dbt import only checks that the entity columns exist. Their type is never looked at: A model whose entity column is declared FLOAT64, BOOLEAN, BYTES or TI...

Opengraph URL: https://github.com/feast-dev/feast/pull/7067

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:52e26faa-1b0a-283a-5775-2b7f5e4dfcc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96A0:20741A:D9E118:11F0FAE:6AFE926B
html-safe-noncebda7f875b239832442e868a5f8c53cf7b668311bdf41d1deb07d0e8d52f143e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkEwOjIwNzQxQTpEOUUxMTg6MTFGMEZBRTo2QUZFOTI2QiIsInZpc2l0b3JfaWQiOiI4MTc2NjI2Njk5NzQwMjg3NTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8800f15cf0c221c466fa86800e705910b7a162d50e705b24dbc1e28c274a7024
hovercard-subject-tagpull_request:4986206425
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7067/files
twitter:imagehttps://avatars.githubusercontent.com/u/115794254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/115794254?s=400&v=4
og:image:altWhat this PR does / why we need it: feast dbt import only checks that the entity columns exist. Their type is never looked at: A model whose entity column is declared FLOAT64, BOOLEAN, BYTES or TI...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7067/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7067%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7067%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7067/files
Reloadhttps://github.com/feast-dev/feast/pull/7067/files
Reloadhttps://github.com/feast-dev/feast/pull/7067/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
NopeCharon:fix/dbt-entity-column-type-warninghttps://github.com/NopeCharon/feast/tree/fix/dbt-entity-column-type-warning
Conversation 2 https://github.com/feast-dev/feast/pull/7067
Commits 2 https://github.com/feast-dev/feast/pull/7067/commits
Checks 23 https://github.com/feast-dev/feast/pull/7067/checks
Files changed https://github.com/feast-dev/feast/pull/7067/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7067/files
fix: Validate entity column types in feast dbt import https://github.com/feast-dev/feast/pull/7067/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7067/files
e34f438 fix: Validate entity column types in feast dbt import NopeCharon Oct 23, 2026 https://github.com/feast-dev/feast/pull/7067/commits/e34f4386767b3542dcccc78c6d97d98322951e1e
b5e1dc7 Merge branch 'master' into fix/dbt-entity-column-type-warning shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7067/commits/b5e1dc75561af03fdfbb12374ba2fcbd7946b494
Clear filters https://github.com/feast-dev/feast/pull/7067/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7067/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7067/files
dbt-integration.md https://github.com/feast-dev/feast/pull/7067/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
dbt_import.py https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
test_entity_column_type.py https://github.com/feast-dev/feast/pull/7067/files#diff-8ba2edbfb33d8382ca522a35ffd39d2f9db933c34ab41e13e34e0c67ab1d8f16
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/dbt-integration.mdhttps://github.com/feast-dev/feast/pull/7067/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
View file https://github.com/NopeCharon/feast/blob/b5e1dc75561af03fdfbb12374ba2fcbd7946b494/docs/how-to-guides/dbt-integration.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7067/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7067/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
https://github.com/feast-dev/feast/pull/7067/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
https://github.com/feast-dev/feast/pull/7067/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/cli/dbt_import.pyhttps://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
View file https://github.com/NopeCharon/feast/blob/b5e1dc75561af03fdfbb12374ba2fcbd7946b494/sdk/python/feast/cli/dbt_import.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7067/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7067/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/dbt/test_entity_column_type.pyhttps://github.com/feast-dev/feast/pull/7067/files#diff-8ba2edbfb33d8382ca522a35ffd39d2f9db933c34ab41e13e34e0c67ab1d8f16
View file https://github.com/NopeCharon/feast/blob/b5e1dc75561af03fdfbb12374ba2fcbd7946b494/sdk/python/tests/unit/dbt/test_entity_column_type.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7067/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/7067/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.