René's URL Explorer Experiment


Title: fix: add watch verb on clusterroles and clusterrolebindings for feast-operator by ryder777777 · Pull Request #7062 · feast-dev/feast · GitHub

Open Graph Title: fix: add watch verb on clusterroles and clusterrolebindings for feast-operator by ryder777777 · Pull Request #7062 · feast-dev/feast

X Title: fix: add watch verb on clusterroles and clusterrolebindings for feast-operator by ryder777777 · Pull Request #7062 · feast-dev/feast

Description: What this PR does / why we need it: controller-runtime's default cached client starts informers (List + Watch) the first time Get/List is called on a resource type. Currently, the Feast Operator's manager-role ClusterRole grants get and list on clusterroles and clusterrolebindings in rbac.authorization.k8s.io, but omits watch, causing the informer reflectors to fail with Failed to watch *v1.ClusterRole: ... cannot watch resource "clusterroles" and Failed to watch *v1.ClusterRoleBinding: ... cannot watch resource "clusterrolebindings". This PR adds the watch verb to clusterroles and clusterrolebindings in featurestore_controller.go's kubebuilder RBAC markers and synced manifests (config/rbac/role.yaml, dist/install.yaml, and bundle/manifests/feast-operator.clusterserviceversion.yaml). Which issue(s) this PR fixes: Fixes #7061 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change

Open Graph Description: What this PR does / why we need it: controller-runtime's default cached client starts informers (List + Watch) the first time Get/List is called on a resource type. Currently, the Feast Operato...

X Description: What this PR does / why we need it: controller-runtime's default cached client starts informers (List + Watch) the first time Get/List is called on a resource type. Currently, the Feast Ope...

Opengraph URL: https://github.com/feast-dev/feast/pull/7062

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c752d48-0aff-ec8d-ff92-29ff855d4453
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA96:338EF9:DD66F3:12F6F7D:6AFE9279
html-safe-nonce9c84f36dc83718b9f743946ace949f4f9ffd0d96139891f831fdd5e44f5ad8a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTk2OjMzOEVGOTpERDY2RjM6MTJGNkY3RDo2QUZFOTI3OSIsInZpc2l0b3JfaWQiOiIxNTk0MDEyMTQ3MDA1ODk2ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace43f1ee5e260c3ba0c0cedd585b162cf4767466b548d774a2340238f153bbf12
hovercard-subject-tagpull_request:4968295674
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7062/files
twitter:imagehttps://avatars.githubusercontent.com/u/155237013?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/155237013?s=400&v=4
og:image:altWhat this PR does / why we need it: controller-runtime's default cached client starts informers (List + Watch) the first time Get/List is called on a resource type. Currently, the Feast Operato...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7062/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7062%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7062%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7062/files
Reloadhttps://github.com/feast-dev/feast/pull/7062/files
Reloadhttps://github.com/feast-dev/feast/pull/7062/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ryder777777:fix/operator-rbac-watch-clusterroles-7061https://github.com/ryder777777/feast/tree/fix/operator-rbac-watch-clusterroles-7061
Conversation 2 https://github.com/feast-dev/feast/pull/7062
Commits 3 https://github.com/feast-dev/feast/pull/7062/commits
Checks 1 https://github.com/feast-dev/feast/pull/7062/checks
Files changed https://github.com/feast-dev/feast/pull/7062/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7062/files
fix: add watch verb on clusterroles and clusterrolebindings for feast-operator https://github.com/feast-dev/feast/pull/7062/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/7062/files
f38a451 fix: add watch verb on clusterroles and clusterrolebindings for feast… ryder777777 Oct 22, 2026 https://github.com/feast-dev/feast/pull/7062/commits/f38a451da81beac558a272af0b80d6ef769e1870
03c8d43 chore: merge upstream master into fix/operator-rbac-watch-clusterrole… ryder777777 Nov 8, 2026 https://github.com/feast-dev/feast/pull/7062/commits/03c8d4339d06dada8525c62c11c4840f32235d9f
f1a31b0 Merge branch 'master' into fix/operator-rbac-watch-clusterroles-7061 shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7062/commits/f1a31b0e3839902476287e3eb925c0f06cb2047a
Clear filters https://github.com/feast-dev/feast/pull/7062/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7062/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7062/files
feast-operator.clusterserviceversion.yaml https://github.com/feast-dev/feast/pull/7062/files#diff-2df3d27ec8bd09f647858a863adb414f72381d47c546bcdf4a72cf160a35f8ff
role.yaml https://github.com/feast-dev/feast/pull/7062/files#diff-31b52fe62e84f3dfb9f36ae9086e16319de37775db725b35ab4b1182db168999
install.yaml https://github.com/feast-dev/feast/pull/7062/files#diff-9a160662c77106b5759918b6ee5293ab38814aca9c0eb035199c5b4397d1cfe4
featurestore_controller.go https://github.com/feast-dev/feast/pull/7062/files#diff-7e830390cdfbfed474f85aa10cbb2369b5e82f8191ffd97d9a635d463c9df16c
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yamlhttps://github.com/feast-dev/feast/pull/7062/files#diff-2df3d27ec8bd09f647858a863adb414f72381d47c546bcdf4a72cf160a35f8ff
View file https://github.com/ryder777777/feast/blob/f1a31b0e3839902476287e3eb925c0f06cb2047a/infra/feast-operator/bundle/manifests/feast-operator.clusterserviceversion.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7062/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7062/files#diff-2df3d27ec8bd09f647858a863adb414f72381d47c546bcdf4a72cf160a35f8ff
https://github.com/feast-dev/feast/pull/7062/files#diff-2df3d27ec8bd09f647858a863adb414f72381d47c546bcdf4a72cf160a35f8ff
https://github.com/feast-dev/feast/pull/7062/files#diff-2df3d27ec8bd09f647858a863adb414f72381d47c546bcdf4a72cf160a35f8ff
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/config/rbac/role.yamlhttps://github.com/feast-dev/feast/pull/7062/files#diff-31b52fe62e84f3dfb9f36ae9086e16319de37775db725b35ab4b1182db168999
View file https://github.com/ryder777777/feast/blob/f1a31b0e3839902476287e3eb925c0f06cb2047a/infra/feast-operator/config/rbac/role.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7062/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7062/files#diff-31b52fe62e84f3dfb9f36ae9086e16319de37775db725b35ab4b1182db168999
https://github.com/feast-dev/feast/pull/7062/files#diff-31b52fe62e84f3dfb9f36ae9086e16319de37775db725b35ab4b1182db168999
https://github.com/feast-dev/feast/pull/7062/files#diff-31b52fe62e84f3dfb9f36ae9086e16319de37775db725b35ab4b1182db168999
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/dist/install.yamlhttps://github.com/feast-dev/feast/pull/7062/files#diff-9a160662c77106b5759918b6ee5293ab38814aca9c0eb035199c5b4397d1cfe4
View file https://github.com/ryder777777/feast/blob/f1a31b0e3839902476287e3eb925c0f06cb2047a/infra/feast-operator/dist/install.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7062/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7062/files#diff-9a160662c77106b5759918b6ee5293ab38814aca9c0eb035199c5b4397d1cfe4
https://github.com/feast-dev/feast/pull/7062/files#diff-9a160662c77106b5759918b6ee5293ab38814aca9c0eb035199c5b4397d1cfe4
https://github.com/feast-dev/feast/pull/7062/files#diff-9a160662c77106b5759918b6ee5293ab38814aca9c0eb035199c5b4397d1cfe4
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/internal/controller/featurestore_controller.gohttps://github.com/feast-dev/feast/pull/7062/files#diff-7e830390cdfbfed474f85aa10cbb2369b5e82f8191ffd97d9a635d463c9df16c
View file https://github.com/ryder777777/feast/blob/f1a31b0e3839902476287e3eb925c0f06cb2047a/infra/feast-operator/internal/controller/featurestore_controller.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7062/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7062/files#diff-7e830390cdfbfed474f85aa10cbb2369b5e82f8191ffd97d9a635d463c9df16c
https://github.com/feast-dev/feast/pull/7062/files#diff-7e830390cdfbfed474f85aa10cbb2369b5e82f8191ffd97d9a635d463c9df16c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.