René's URL Explorer Experiment


Title: fix: Keep the baseline out of monitoring windows and align its overlay by Nitant28 · Pull Request #7057 · feast-dev/feast · GitHub

Open Graph Title: fix: Keep the baseline out of monitoring windows and align its overlay by Nitant28 · Pull Request #7057 · feast-dev/feast

X Title: fix: Keep the baseline out of monitoring windows and align its overlay by Nitant28 · Pull Request #7057 · feast-dev/feast

Description: What this PR does / why we need it: Fixes the monitoring UI problems described in #7054 (with screenshots). There is one commit for each cause. 1. fix: Keep the baseline out of the Monitoring pages' window views /monitoring/metrics/features returns the baseline row alongside the windows, dated by the day it was computed. The pages treated it as a window. A new pages/monitoring/metricSelection.ts holds the shared selection logic: latestWindowMetric(): the Monitoring tab now shows the newest window, not the baseline compared with itself. It shows the baseline on its own ("Baseline Distribution", no overlay) only when no window exists yet. windowGranularities(): the detail page's View options no longer include the raw "baseline" row (it keeps its "Baseline (all data)" option), and are ordered shortest window first, so the page opens on Daily. seriesForGranularity(): the detail page's Time-Series Analysis plots one granularity (the viewed one, or the shortest when the baseline is viewed) instead of every row on one line. 2. fix: Draw the Monitoring tab's baseline overlay on the window's bins The overlay drew baseline bin i behind window bin i, although every stored histogram has its own edges, and scaled both by raw counts, although the baseline has many more rows. A ×100 unit change drew the same bars as a clean day. alignBaselineToBins() (new, components/histogramAlignment.ts) moves each baseline bin's count onto the window's bins by overlap and scales it to the window's row count. Values are treated as uniform within a bin; a zero-width bin (the SQL backends' constant-column form) as a point. A constant window takes the whole baseline bin that contains its value, so a 0/1 flag compares against the baseline's share of zeros. The legend states the share of the baseline outside the window's range. A non-numeric baseline (left from before a feature changed type) is no longer overlaid. On master it throws TypeError: undefined is not iterable. Design notes Scaling instead of shares: scaling to the window's row count keeps the y-axis and tooltips in this window's rows. Why UI-only: /monitoring/metrics/features and the baseline's metric_date are unchanged. Changing either would change the REST response or the stored data (metric_date is part of FEATURE_METRICS_PK), which seems out of scope for a UI fix. Untouched: the categorical chart and the time-series component. If you'd prefer, the two commits split cleanly into two PRs (they share no files). Relation to #7056. I reported #7054 with this fix ready, and #7056 has since been opened for it too. Both take the same overall approach. In case it helps you choose or combine them, the differences I see are: Constant columns: SQL backends store a constant column as one zero-width bin. Here that bin is treated as a point, so the overlay still works when either side is constant. #7056 skips zero-width bins. Partial overlap: here the baseline is scaled by its full row count, and the legend reports the share outside the window's range (39% in the ×100 case in #7054). #7056 renormalizes the overlapping part to 100%, so that share isn't visible. Detail page default: here window lengths are ordered shortest first, so the page opens on Daily. #7056 keeps the alphabetical order, so it opens on Biweekly. Tests: 19 here, including 3 render tests that fail on master. #7056 has 9 unit tests. I'm happy to go with whichever you prefer, or to fold anything useful from #7056 into this one. Which issue(s) this PR fixes: Fixes #7054 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change 19 new jest tests: metricSelection.test.ts (6): uses the rows /monitoring/metrics/features returns after a feast monitor run on the demo. Covers the latest window, baseline only, empty windows, granularity order, and single-granularity series. histogramAlignment.test.ts (10): edges, scaling, a shift past the baseline's range, zero-width bins on either side, a constant 0/1 window, edge values, an empty baseline, a missing last edge. HistogramChart.test.tsx (3, render): all three fail on master. A baseline with 100× the rows draws window bars 1.6 px tall against 160 px baseline bars. A window above the baseline's range still gets full-height baseline bars. A categorical baseline throws. Local results (Windows, Node 20; .nvmrc pins 22, which CI uses): The new tests pass on this branch, rebased on master at e304a84. prettier --check, eslint, tsc and the build:lib type check pass, and so does the production build with CI=true. Full suite: 38 of 39 pass. The one failure is in FeastUISansProviders.test.tsx, which fails 1–3 of its tests per run on this machine: timeouts, and getByRole heading lookups right after navigation. It fails the same way on unmodified master ("Feature Views" and "Data Sources" headings not found). Manual: the steps in #7054 on the feast init demo, served by feast ui with this build. The screenshots below cover the tab after a fresh run, on a clean day and on a ×100 day, plus the detail page. Misc The overlay is approximate when values aren't uniform within a baseline bin. The stored histograms keep only bin counts, so some within-bin assumption is unavoidable. cc @jyejare

Open Graph Description: What this PR does / why we need it: Fixes the monitoring UI problems described in #7054 (with screenshots). There is one commit for each cause. 1. fix: Keep the baseline out of the Monitoring pages...

X Description: What this PR does / why we need it: Fixes the monitoring UI problems described in #7054 (with screenshots). There is one commit for each cause. 1. fix: Keep the baseline out of the Monitoring pages...

Opengraph URL: https://github.com/feast-dev/feast/pull/7057

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6b8acef3-145f-fc63-c58a-790457e0d9b3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB042:79CF9:32A4B1:434C13:6AFE98A8
html-safe-nonce631a328195bc64af59b35e022b8eaf5ecb6c9637a0c101f992115815a10aa8db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDQyOjc5Q0Y5OjMyQTRCMTo0MzRDMTM6NkFGRTk4QTgiLCJ2aXNpdG9yX2lkIjoiMzgxNjkwMzY0OTI0MjU1MjQ4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccb9a76bfb707646a82d1e27b7a2b70eb3a1a1a02dbe52c9f27816745247cfd20
hovercard-subject-tagpull_request:4947805082
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7057/files
twitter:imagehttps://avatars.githubusercontent.com/u/241639402?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/241639402?s=400&v=4
og:image:altWhat this PR does / why we need it: Fixes the monitoring UI problems described in #7054 (with screenshots). There is one commit for each cause. 1. fix: Keep the baseline out of the Monitoring pages...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7057/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7057%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7057%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7057/files
Reloadhttps://github.com/feast-dev/feast/pull/7057/files
Reloadhttps://github.com/feast-dev/feast/pull/7057/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Nitant28https://github.com/Nitant28
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Nitant28:fix/ui-monitoring-baseline-overlayhttps://github.com/Nitant28/feast/tree/fix/ui-monitoring-baseline-overlay
Conversation 3 https://github.com/feast-dev/feast/pull/7057
Commits 2 https://github.com/feast-dev/feast/pull/7057/commits
Checks 27 https://github.com/feast-dev/feast/pull/7057/checks
Files changed https://github.com/feast-dev/feast/pull/7057/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7057/files
fix: Keep the baseline out of monitoring windows and align its overlay https://github.com/feast-dev/feast/pull/7057/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7057/files
fe0102b fix: Keep the baseline out of the Monitoring pages' window views Nitant28 Oct 20, 2026 https://github.com/feast-dev/feast/pull/7057/commits/fe0102b3a6fbf34610a055269c0835dd799de52e
9d0a264 fix: Draw the Monitoring tab's baseline overlay on the window's bins Nitant28 Oct 20, 2026 https://github.com/feast-dev/feast/pull/7057/commits/9d0a264a523d20ed027ac0f956b14f6249b2d1ae
Clear filters https://github.com/feast-dev/feast/pull/7057/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7057/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7057/files
FeatureMonitoringTab.tsx https://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
FeatureMetricsDetail.tsx https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
HistogramChart.test.tsx https://github.com/feast-dev/feast/pull/7057/files#diff-3b0022b846aaf5c3e4f5edae64997fe50b7b0589c11f3ab5ad58adb535804b2c
HistogramChart.tsx https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
histogramAlignment.test.ts https://github.com/feast-dev/feast/pull/7057/files#diff-406edeb57bd62b6c00619d526998f8339af1aae923221656e36d617b47fb9d55
histogramAlignment.ts https://github.com/feast-dev/feast/pull/7057/files#diff-004430d0e286752494119719b441def2479253eec2380cac8854535003eaaa1d
metricSelection.test.ts https://github.com/feast-dev/feast/pull/7057/files#diff-8fd30c89ab623981a4d197e81474ff94b8a823ecef4036f8c51eb7f550bea596
metricSelection.ts https://github.com/feast-dev/feast/pull/7057/files#diff-4eb5b01c7b452f3bdae9cb23b49ad1652a0e75253602c97c01695d3d5b55f2d2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L11
ui/src/pages/features/FeatureMonitoringTab.tsxhttps://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
View file https://github.com/feast-dev/feast/blob/9d0a264a523d20ed027ac0f956b14f6249b2d1ae/ui/src/pages/features/FeatureMonitoringTab.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7057/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
https://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
https://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
https://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
https://github.com/feast-dev/feast/pull/7057/files#diff-74bb0e5474c9b6093eb0d2930d3af10cfbcd1ff6ef319aefb82edcbc96581c96
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L11
ui/src/pages/monitoring/FeatureMetricsDetail.tsxhttps://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
View file https://github.com/feast-dev/feast/blob/9d0a264a523d20ed027ac0f956b14f6249b2d1ae/ui/src/pages/monitoring/FeatureMetricsDetail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7057/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/pull/7057/files#diff-4a5818344ba63b5def0da5b70f81810bfd2a9ccec9d57421587aabfde2cd2946
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L11
ui/src/pages/monitoring/components/HistogramChart.test.tsxhttps://github.com/feast-dev/feast/pull/7057/files#diff-3b0022b846aaf5c3e4f5edae64997fe50b7b0589c11f3ab5ad58adb535804b2c
View file https://github.com/feast-dev/feast/blob/9d0a264a523d20ed027ac0f956b14f6249b2d1ae/ui/src/pages/monitoring/components/HistogramChart.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7057/{{ revealButtonHref }}
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L11
ui/src/pages/monitoring/components/HistogramChart.tsxhttps://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
View file https://github.com/feast-dev/feast/blob/9d0a264a523d20ed027ac0f956b14f6249b2d1ae/ui/src/pages/monitoring/components/HistogramChart.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7057/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
https://github.com/feast-dev/feast/pull/7057/files#diff-16533897fd69aa26c67af6c5a20aca5a25f85e3a76a377c9ecf1ddc725829e0a
Please reload this pagehttps://github.com/feast-dev/feast/pull/7057/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7057/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.