René's URL Explorer Experiment


Title: fix: Read None elements of UUID and Decimal lists as None by spicysharkco · Pull Request #7039 · feast-dev/feast · GitHub

Open Graph Title: fix: Read None elements of UUID and Decimal lists as None by spicysharkco · Pull Request #7039 · feast-dev/feast

X Title: fix: Read None elements of UUID and Decimal lists as None by spicysharkco · Pull Request #7039 · feast-dev/feast

Description: What this PR does / why we need it: A None inside a UUID_LIST, TIME_UUID_LIST or DECIMAL_LIST is written to the proto as "" (_LIST_NONE_DEFAULTS in type_map.py, because a repeated string field cannot hold None). feast_value_type_to_python_type then calls UUID("") or Decimal("") on it. So the write works and the read fails: fv = FeatureView(..., schema=[Field(name="u", dtype=Array(Uuid)), Field(name="dec", dtype=Array(Decimal))], ...) store.apply([entity, fv]) df = pd.DataFrame({"id": [1], "event_timestamp": [...], "u": [[str(u), None]], "dec": [["1.5", None]]}) store.write_to_online_store("fv", df) store.get_online_features(features=["fv:u", "fv:dec"], entity_rows=[{"id": 1}]).to_dict() # raises ValueError: badly formed hexadecimal UUID string # or decimal.InvalidOperation: [], # depending on which column is converted first With this change the same call returns {'u': [[UUID('...'), None]], 'dec': [[Decimal('1.5'), None]]}. The reader now maps "" to None for the three list types, the way the unix_timestamp_list_val branch maps its NULL_TIMESTAMP_INT_VALUE sentinel to None. The scalar and set branches are not touched. Cause: the list readers and the "" default. Which issue(s) this PR fixes: No issue, found while checking list conversions in type_map.py. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Added test_uuid_list_with_none_roundtrip, test_time_uuid_list_with_none_roundtrip and test_decimal_list_with_none_roundtrip to sdk/python/tests/unit/test_type_map.py. All three fail on master with the errors above and pass with the fix: pytest sdk/python/tests/unit/test_type_map.py -k with_none_roundtrip gives 3 passed. The rest of the file passes apart from TestSparkNativeTypeValidation (needs pyspark). ruff check and ruff format --check are clean on both files.

Open Graph Description: What this PR does / why we need it: A None inside a UUID_LIST, TIME_UUID_LIST or DECIMAL_LIST is written to the proto as "" (_LIST_NONE_DEFAULTS in type_map.py, because a repeated string ...

X Description: What this PR does / why we need it: A None inside a UUID_LIST, TIME_UUID_LIST or DECIMAL_LIST is written to the proto as "" (_LIST_NONE_DEFAULTS in type_map.py, because a repeated...

Opengraph URL: https://github.com/feast-dev/feast/pull/7039

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f10687f-6a4f-c3ce-7ea6-123291ad7923
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB284:84C13:DA8623:1202A1C:6AFE927B
html-safe-nonce2c25c02798c11d0a8e708a90a396a875bb18cabad42ce2b4dd8e58587befa92c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjg0Ojg0QzEzOkRBODYyMzoxMjAyQTFDOjZBRkU5MjdCIiwidmlzaXRvcl9pZCI6Ijc3MDQxMTQ1ODg0NzU2MjYxMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6098f9b904cb3533f32e7055d0b6b929ce03e099a57945938ace75e3ecca9bb1
hovercard-subject-tagpull_request:4914862353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7039/files
twitter:imagehttps://avatars.githubusercontent.com/u/321699413?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/321699413?s=400&v=4
og:image:altWhat this PR does / why we need it: A None inside a UUID_LIST, TIME_UUID_LIST or DECIMAL_LIST is written to the proto as "" (_LIST_NONE_DEFAULTS in type_map.py, because a repeated string ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7039/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7039%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7039%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7039/files
Reloadhttps://github.com/feast-dev/feast/pull/7039/files
Reloadhttps://github.com/feast-dev/feast/pull/7039/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
spicysharkco:fix/none-in-uuid-decimal-listshttps://github.com/spicysharkco/feast/tree/fix/none-in-uuid-decimal-lists
Conversation 1 https://github.com/feast-dev/feast/pull/7039
Commits 2 https://github.com/feast-dev/feast/pull/7039/commits
Checks 1 https://github.com/feast-dev/feast/pull/7039/checks
Files changed https://github.com/feast-dev/feast/pull/7039/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7039/files
fix: Read None elements of UUID and Decimal lists as None https://github.com/feast-dev/feast/pull/7039/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7039/files
442eb18 fix: Read None elements of UUID and Decimal lists as None spicysharkco Oct 19, 2026 https://github.com/feast-dev/feast/pull/7039/commits/442eb1808d669a51a64b2b14b908124983442421
ec86404 Merge branch 'master' into fix/none-in-uuid-decimal-lists shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7039/commits/ec864045b7634325abb08516577d999f992d7d95
Clear filters https://github.com/feast-dev/feast/pull/7039/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7039/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7039/files
type_map.py https://github.com/feast-dev/feast/pull/7039/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
test_type_map.py https://github.com/feast-dev/feast/pull/7039/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/type_map.pyhttps://github.com/feast-dev/feast/pull/7039/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
View file https://github.com/spicysharkco/feast/blob/ec864045b7634325abb08516577d999f992d7d95/sdk/python/feast/type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7039/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7039/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/pull/7039/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_type_map.pyhttps://github.com/feast-dev/feast/pull/7039/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
View file https://github.com/spicysharkco/feast/blob/ec864045b7634325abb08516577d999f992d7d95/sdk/python/tests/unit/test_type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7039/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7039/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/pull/7039/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/pull/7039/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/pull/7039/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.