René's URL Explorer Experiment


Title: feat: Warn when the dbt import timestamp field is not a timestamp type by luc-pimentel · Pull Request #7038 · feast-dev/feast · GitHub

Open Graph Title: feat: Warn when the dbt import timestamp field is not a timestamp type by luc-pimentel · Pull Request #7038 · feast-dev/feast

X Title: feat: Warn when the dbt import timestamp field is not a timestamp type by luc-pimentel · Pull Request #7038 · feast-dev/feast

Description: What this PR does / why we need it: feast dbt import checked only that the timestamp column exists. A column declared STRING or INT64 imported silently, and the resulting FeatureView fails at the first get_historical_features call with AttributeError: 'str' object has no attribute 'tzinfo'. The import now checks the column's dbt type through the existing dbt-to-Feast type mapping and prints one warning per model when it does not map to a timestamp type. The model is still imported. Columns with no data_type in schema.yml reach the CLI as STRING and get the same warning. Spellings the mapping does not know yet, such as Postgres timestamp with time zone or DATETIME2, also warn; extending the mapping is a separate change. The troubleshooting section of the dbt how-to documents the new message. Which issue(s) this PR fixes: Fixes #5871 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New CLI tests build a manifest and run feast dbt import --dry-run: the warning appears for STRING, INT64 and an undeclared type, and does not appear for TIMESTAMP or TIMESTAMP_NTZ(9); warned models still produce their DataSource and FeatureView. All 43 dbt unit tests pass. Scoped Ruff, formatting and mypy checks pass. The before/after reproduction on Feast 0.67.0 and master passes its controls. Misc AI-assisted implementation and tests.

Open Graph Description: What this PR does / why we need it: feast dbt import checked only that the timestamp column exists. A column declared STRING or INT64 imported silently, and the resulting FeatureView fails at the f...

X Description: What this PR does / why we need it: feast dbt import checked only that the timestamp column exists. A column declared STRING or INT64 imported silently, and the resulting FeatureView fails at the f...

Opengraph URL: https://github.com/feast-dev/feast/pull/7038

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:073d5d62-3a2a-e2cc-d6c5-be60289846b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0E4:20D634:DFBC46:12A7894:6AFE989F
html-safe-nonce81b2ed0bbc96eb92c4a47f5172d79dc21a63885685d7795ce33a927b684e9341
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEU0OjIwRDYzNDpERkJDNDY6MTJBNzg5NDo2QUZFOTg5RiIsInZpc2l0b3JfaWQiOiI2OTg3NTEyMTY3MTU1MDEzNzkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5e7ddc64920e228a464f0e8de2b17b07af6d3c9cb4710ef4e2c2ec1d9701892e
hovercard-subject-tagpull_request:4914646266
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7038/files
twitter:imagehttps://avatars.githubusercontent.com/u/154371376?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/154371376?s=400&v=4
og:image:altWhat this PR does / why we need it: feast dbt import checked only that the timestamp column exists. A column declared STRING or INT64 imported silently, and the resulting FeatureView fails at the f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7038/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7038%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7038%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7038/files
Reloadhttps://github.com/feast-dev/feast/pull/7038/files
Reloadhttps://github.com/feast-dev/feast/pull/7038/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
luc-pimentelhttps://github.com/luc-pimentel
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
luc-pimentel:fix/5871-dbt-timestamp-type-warninghttps://github.com/luc-pimentel/feast/tree/fix/5871-dbt-timestamp-type-warning
Conversation 2 https://github.com/feast-dev/feast/pull/7038
Commits 2 https://github.com/feast-dev/feast/pull/7038/commits
Checks 1 https://github.com/feast-dev/feast/pull/7038/checks
Files changed https://github.com/feast-dev/feast/pull/7038/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7038/files
feat: Warn when the dbt import timestamp field is not a timestamp type https://github.com/feast-dev/feast/pull/7038/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7038/files
5b9737d test: Cover the dbt import timestamp field type warning luc-pimentel Oct 15, 2026 https://github.com/feast-dev/feast/pull/7038/commits/5b9737d871dbc1234d20291f69c9d6582f66123b
46b60e0 feat: Warn when the dbt import timestamp field is not a timestamp type luc-pimentel Oct 15, 2026 https://github.com/feast-dev/feast/pull/7038/commits/46b60e0dad31856ba821742aa491cc54663fd81e
Clear filters https://github.com/feast-dev/feast/pull/7038/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7038/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7038/files
dbt-integration.md https://github.com/feast-dev/feast/pull/7038/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
dbt_import.py https://github.com/feast-dev/feast/pull/7038/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
test_timestamp_type.py https://github.com/feast-dev/feast/pull/7038/files#diff-5c9c6d7c21bdc21bf3e8180864489a9ec65cf3bc8a24fb14e534e6e4ed8e7f05
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/dbt-integration.mdhttps://github.com/feast-dev/feast/pull/7038/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
View file https://github.com/feast-dev/feast/blob/46b60e0dad31856ba821742aa491cc54663fd81e/docs/how-to-guides/dbt-integration.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7038/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7038/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
https://github.com/feast-dev/feast/pull/7038/files#diff-8819bdeb2dd1de47f96e2ccfab1d25fc3343fc63f73ed782d4304846bfb5eaea
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/cli/dbt_import.pyhttps://github.com/feast-dev/feast/pull/7038/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
View file https://github.com/feast-dev/feast/blob/46b60e0dad31856ba821742aa491cc54663fd81e/sdk/python/feast/cli/dbt_import.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7038/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7038/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7038/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7038/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/pull/7038/files#diff-2a90acce132e8d0b8b04c11277bd5814eb3b241f92343b3fcafba17ee1a88483
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/dbt/test_timestamp_type.pyhttps://github.com/feast-dev/feast/pull/7038/files#diff-5c9c6d7c21bdc21bf3e8180864489a9ec65cf3bc8a24fb14e534e6e4ed8e7f05
View file https://github.com/feast-dev/feast/blob/46b60e0dad31856ba821742aa491cc54663fd81e/sdk/python/tests/unit/dbt/test_timestamp_type.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7038/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.