René's URL Explorer Experiment


Title: fix: Compare aggregations, mode and tiling in StreamFeatureView equality by vidigoat · Pull Request #7034 · feast-dev/feast · GitHub

Open Graph Title: fix: Compare aggregations, mode and tiling in StreamFeatureView equality by vidigoat · Pull Request #7034 · feast-dev/feast

X Title: fix: Compare aggregations, mode and tiling in StreamFeatureView equality by vidigoat · Pull Request #7034 · feast-dev/feast

Description: What this PR does / why we need it: StreamFeatureView.__eq__ returns early when neither view has a udf: if not self.udf: return not other.udf so for UDF-less stream feature views (the common case for aggregation-only views) mode, timestamp_field, udf_string and aggregations are never compared. enable_tiling and tiling_hop_size are not compared at all, although both are serialized to the proto. As a result, two stream feature views with different aggregations compare equal: a = StreamFeatureView(..., aggregations=[Aggregation(column="f", function="sum", time_window=timedelta(hours=1))]) b = StreamFeatureView(..., aggregations=[Aggregation(column="f", function="max", time_window=timedelta(days=7))]) a == b # True on master a.to_proto() == b.to_proto() # False The SQL registry relies on this equality: _apply_object skips the write when existing_obj == obj, and apply_feature_view uses != to raise FeatureViewPinConflict when a pinned version is combined with a modified definition. On current master those paths happen to still work, because the registry copy of a stream feature view lists the join key in features (fixed in #7033) and that difference makes FeatureView.__eq__ return False. With #7033 applied and without this change, I reproduced end to end with a SQLite-backed SQL registry that: re-applying the view with aggregations changed from sum/1h to max/7d is silently skipped (the registry keeps sum/1h), and pinning version="v0" while also changing the aggregations does not raise FeatureViewPinConflict. So this should land before (or together with) #7033. The fix compares these fields regardless of whether a UDF is set, and adds enable_tiling and tiling_hop_size. mode and udf_string are compared in normalized form (mode_to_string(...), and None treated as ""), matching how to_proto() writes them. Otherwise a view and its from_proto(to_proto(...)) copy would compare unequal, which would make every apply look like a change and create extra version snapshots. Which issue(s) this PR fixes: No existing issue; found while working on #7033. I searched open and closed issues and PRs for a duplicate. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change test_stream_feature_view_equality_with_udf covers the UDF branches (only one view has a udf, or both have different udfs). New parametrized test test_stream_feature_view_equality_without_udf (aggregations, mode, timestamp_field, enable_tiling, tiling_hop_size): all 5 cases fail on master and pass with this change; the existing round-trip test test_stream_feature_view_initialization_with_optional_fields_omitted still passes thanks to the normalization above. Manual end-to-end check with a SQLite-backed SQL registry, both with and without #7033 applied: changed aggregations are written, the pin conflict is raised, and re-applying an unchanged view twice creates no new version snapshot. ruff check, ruff format --check and mypy feast pass. Misc Developed with Claude Code (AI) on my behalf. 🤖 Generated with Claude Code

Open Graph Description: What this PR does / why we need it: StreamFeatureView.__eq__ returns early when neither view has a udf: if not self.udf: return not other.udf so for UDF-less stream feature views (the common ca...

X Description: What this PR does / why we need it: StreamFeatureView.__eq__ returns early when neither view has a udf: if not self.udf: return not other.udf so for UDF-less stream feature views (the common ca...

Opengraph URL: https://github.com/feast-dev/feast/pull/7034

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e4bcdaef-a076-ddb0-4660-decedf805dd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4BA:1EECAE:E9BAD6:13F0821:6AFE9568
html-safe-noncebb4a4218f75c31d15231c7a44ef2f8316f7acd1509923a8d356b97c5f0c2d8fe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEJBOjFFRUNBRTpFOUJBRDY6MTNGMDgyMTo2QUZFOTU2OCIsInZpc2l0b3JfaWQiOiI4NDI4NjMyNDE1NDc5NDM2NjQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccb70c1308917bb071056beea1ac0df3e7fbb256ab7177c2ed289624a8bcec0ec
hovercard-subject-tagpull_request:4907650725
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7034/files
twitter:imagehttps://avatars.githubusercontent.com/u/219086731?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/219086731?s=400&v=4
og:image:altWhat this PR does / why we need it: StreamFeatureView.__eq__ returns early when neither view has a udf: if not self.udf: return not other.udf so for UDF-less stream feature views (the common ca...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7034/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7034%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7034%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7034/files
Reloadhttps://github.com/feast-dev/feast/pull/7034/files
Reloadhttps://github.com/feast-dev/feast/pull/7034/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
vidigoat:fix/stream-feature-view-eqhttps://github.com/vidigoat/feast/tree/fix/stream-feature-view-eq
Conversation 2 https://github.com/feast-dev/feast/pull/7034
Commits 2 https://github.com/feast-dev/feast/pull/7034/commits
Checks 23 https://github.com/feast-dev/feast/pull/7034/checks
Files changed https://github.com/feast-dev/feast/pull/7034/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7034/files
fix: Compare aggregations, mode and tiling in StreamFeatureView equality https://github.com/feast-dev/feast/pull/7034/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7034/files
6699bbe fix: Compare aggregations, mode and tiling in StreamFeatureView equality vidigoat Oct 18, 2026 https://github.com/feast-dev/feast/pull/7034/commits/6699bbe86ab503db31acb6ff30feb4e3f5353734
170090e test: Cover UDF branches of StreamFeatureView equality vidigoat Oct 18, 2026 https://github.com/feast-dev/feast/pull/7034/commits/170090e943360bb4d3b862b3537cc0204b9c85b4
Clear filters https://github.com/feast-dev/feast/pull/7034/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7034/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7034/files
stream_feature_view.py https://github.com/feast-dev/feast/pull/7034/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
test_stream_feature_view.py https://github.com/feast-dev/feast/pull/7034/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/stream_feature_view.pyhttps://github.com/feast-dev/feast/pull/7034/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
View file https://github.com/vidigoat/feast/blob/170090e943360bb4d3b862b3537cc0204b9c85b4/sdk/python/feast/stream_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7034/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7034/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
https://github.com/feast-dev/feast/pull/7034/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_stream_feature_view.pyhttps://github.com/feast-dev/feast/pull/7034/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
View file https://github.com/vidigoat/feast/blob/170090e943360bb4d3b862b3537cc0204b9c85b4/sdk/python/tests/unit/test_stream_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7034/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7034/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
Please reload this pagehttps://github.com/feast-dev/feast/pull/7034/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.