René's URL Explorer Experiment


Title: fix: Keep entity columns out of StreamFeatureView proto features by vidigoat · Pull Request #7033 · feast-dev/feast · GitHub

Open Graph Title: fix: Keep entity columns out of StreamFeatureView proto features by vidigoat · Pull Request #7033 · feast-dev/feast

X Title: fix: Keep entity columns out of StreamFeatureView proto features by vidigoat · Pull Request #7033 · feast-dev/feast

Description: What this PR does / why we need it: StreamFeatureView.to_proto() serializes spec.features from self.schema, and schema includes the entity (join key) columns. FeatureView.to_proto_spec() uses self.features, so every other feature view type keeps join keys only in spec.entity_columns. Because of this mismatch, a stream feature view loaded back from the registry lists its join key as a feature. Repro with the local provider (file offline store, SQLite online store): driver = Entity(name="driver", join_keys=["driver_id"], value_type=ValueType.INT64) src = FileSource(name="src", path=path, timestamp_field="event_timestamp") push = PushSource(name="push", batch_source=src) sfv = StreamFeatureView( name="driver_sfv", entities=[driver], ttl=timedelta(days=1), schema=[Field(name="driver_id", dtype=Int64), Field(name="conv_rate", dtype=Float32)], source=push, timestamp_field="event_timestamp", ) store.apply([driver, src, push, sfv]) [f.name for f in sfv.features] # ['conv_rate'] [f.name for f in store.get_stream_feature_view("driver_sfv").features] # ['conv_rate', 'driver_id'] svc = FeatureService(name="svc", features=[store.get_stream_feature_view("driver_sfv")]) store.apply([svc]) store.get_historical_features(entity_df=entity_df, features=svc) # ValueError: The column label 'driver_id' is not unique. The same spec.features field is read by the Go feature server (NewFeatureViewFromStreamFeatureViewProto) and the UI, so they also see the join key as a feature. This PR serializes self.features instead of self.schema, the same as FeatureView.to_proto_spec(). from_proto already restores entity_columns from spec.entity_columns, so nothing is lost. With the change, the registry copy above has features ['conv_rate'] and the historical retrieval returns the expected frame. A registry written by an earlier version keeps the extra column until the next feast apply. That apply reports the stream feature view as updated and rewrites spec.features. I checked this locally: apply on master, then re-apply with this change. If you would rather also filter entity columns out on the read side for registries that are never re-applied, I can add that here. Merge order: please merge #7034 first (or together with this). Today the extra join key in the registry copy happens to make StreamFeatureView.__eq__ return False; once this PR removes it, the existing __eq__ short-circuit for UDF-less views makes the SQL registry skip writes when only aggregations change. #7034 fixes that equality. Which issue(s) this PR fixes: No existing issue. I found this while checking feature view proto round-trips, and searched open and closed issues and PRs for a duplicate before opening this. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New test test_stream_feature_view_serialization_excludes_entity_columns_from_features in sdk/python/tests/unit/test_stream_feature_view.py defines the join key in schema. It checks that spec.features and spec.entity_columns are disjoint and that from_proto(to_proto(sfv)) == sfv. It fails on master (['dummy_field', 'driver_id'] == ['dummy_field']) and passes with this change. Manual test: the repro above, end to end, with the local provider. Misc Developed with Claude Code (AI) under my direction; the new unit test fails on master and passes with this change.

Open Graph Description: What this PR does / why we need it: StreamFeatureView.to_proto() serializes spec.features from self.schema, and schema includes the entity (join key) columns. FeatureView.to_proto_spec() uses self....

X Description: What this PR does / why we need it: StreamFeatureView.to_proto() serializes spec.features from self.schema, and schema includes the entity (join key) columns. FeatureView.to_proto_spec() uses self....

Opengraph URL: https://github.com/feast-dev/feast/pull/7033

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:db258d2b-c617-c18a-ead5-68d3b5fe1a95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97AE:247D07:DFCB25:1323168:6AFE9261
html-safe-nonce27cbe15c8d11734e0fd2f38ed2d7bab16ac880310f290fe9b757ab3628ddf4f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0FFOjI0N0QwNzpERkNCMjU6MTMyMzE2ODo2QUZFOTI2MSIsInZpc2l0b3JfaWQiOiI4NjA2MDg1OTYwMDQ1NTk3MjgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfb19f43f8a794351746782a09e4c62ca2eee7cd0a0a9ca837269cc66d390a800
hovercard-subject-tagpull_request:4907397013
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7033/files
twitter:imagehttps://avatars.githubusercontent.com/u/219086731?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/219086731?s=400&v=4
og:image:altWhat this PR does / why we need it: StreamFeatureView.to_proto() serializes spec.features from self.schema, and schema includes the entity (join key) columns. FeatureView.to_proto_spec() uses self....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7033/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7033%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7033%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7033/files
Reloadhttps://github.com/feast-dev/feast/pull/7033/files
Reloadhttps://github.com/feast-dev/feast/pull/7033/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
vidigoat:fix/stream-feature-view-entity-columnshttps://github.com/vidigoat/feast/tree/fix/stream-feature-view-entity-columns
Conversation 2 https://github.com/feast-dev/feast/pull/7033
Commits 2 https://github.com/feast-dev/feast/pull/7033/commits
Checks 1 https://github.com/feast-dev/feast/pull/7033/checks
Files changed https://github.com/feast-dev/feast/pull/7033/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7033/files
fix: Keep entity columns out of StreamFeatureView proto features https://github.com/feast-dev/feast/pull/7033/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7033/files
05a2956 fix: Keep entity columns out of StreamFeatureView proto features vidigoat Oct 18, 2026 https://github.com/feast-dev/feast/pull/7033/commits/05a29566fa8d483b87f9aabe6ce184ac3b6f9642
0537138 Merge branch 'master' into fix/stream-feature-view-entity-columns shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7033/commits/0537138783b8315b2b6bacf66cea4fbf28d70485
Clear filters https://github.com/feast-dev/feast/pull/7033/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7033/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7033/files
stream_feature_view.py https://github.com/feast-dev/feast/pull/7033/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
test_stream_feature_view.py https://github.com/feast-dev/feast/pull/7033/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/stream_feature_view.pyhttps://github.com/feast-dev/feast/pull/7033/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
View file https://github.com/vidigoat/feast/blob/0537138783b8315b2b6bacf66cea4fbf28d70485/sdk/python/feast/stream_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7033/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7033/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
https://github.com/feast-dev/feast/pull/7033/files#diff-2e4720ca136985a5a5d96582142a0aefa591c64c7ad8d90f8c179bda294da252
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_stream_feature_view.pyhttps://github.com/feast-dev/feast/pull/7033/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
View file https://github.com/vidigoat/feast/blob/0537138783b8315b2b6bacf66cea4fbf28d70485/sdk/python/tests/unit/test_stream_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7033/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7033/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
https://github.com/feast-dev/feast/pull/7033/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
https://github.com/feast-dev/feast/pull/7033/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
https://github.com/feast-dev/feast/pull/7033/files#diff-587b779c4c13bd578856e3d62322115aa8b7ad2078b1f6a3bd04d9ba49ceb892
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.