René's URL Explorer Experiment


Title: fix: Serialize UUID and TimeUuid entity keys by MohammadHijjawi97 · Pull Request #7032 · feast-dev/feast · GitHub

Open Graph Title: fix: Serialize UUID and TimeUuid entity keys by MohammadHijjawi97 · Pull Request #7032 · feast-dev/feast

X Title: fix: Serialize UUID and TimeUuid entity keys by MohammadHijjawi97 · Pull Request #7032 · feast-dev/feast

Description: What this PR does / why we need it: An entity whose join key is a Uuid or TimeUuid can be applied, but materializing its feature view fails, because _serialize_val in key_encoding_utils.py only handles string, bytes, int32, int64 and unix timestamp values. The features never reach the online store, so they cannot be served. This affects every online store that builds its keys with serialize_entity_key (SQLite, Redis, DynamoDB, ...). Reproduction (local provider, FileSource, SQLite online store): session = Entity(name="session", join_keys=["session_id"], value_type=ValueType.UUID) fv = FeatureView( name="fv", entities=[session], schema=[Field(name="session_id", dtype=Uuid), Field(name="score", dtype=Float32)], source=FileSource(path="s.parquet", timestamp_field="event_timestamp"), ttl=timedelta(days=1), ) store.apply([session, fv]) store.materialize(now - timedelta(days=1), now) store.get_online_features( features=["fv:score"], entity_rows=[{"session_id": u1}, {"session_id": str(u2)}] ).to_dict() Before: File ".../feast/infra/online_stores/sqlite.py", line 332, in online_write_batch entity_key_bin = serialize_entity_key( File ".../feast/infra/key_encoding_utils.py", line 181, in serialize_entity_key val_bytes, value_type = _serialize_val( ValueError: Value type not supported for feast feature store: uuid_val: "8b97f8f4-af3b-40e2-9b57-d2c02d0a6687" After: {'session_id': [UUID('0d41a235-...'), UUID('e1f8e126-...')], 'score': [1.0, 2.0]} (same result with a TimeUuid entity) The fix encodes uuid_val and time_uuid_val as their UTF-8 string with the UUID / TIME_UUID value type tags, the same way string keys are encoded, and _deserialize_value decodes them back so deserialize_entity_key round-trips. Existing key types are encoded exactly as before. This covers the Python serialization path. Which issue(s) this PR fixes: No existing issue; found while using a UUID join key. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Added test_serialize_deserialize_uuid_entity (Uuid and TimeUuid) to sdk/python/tests/unit/infra/test_key_encoding_utils.py; both cases fail without the change and pass with it (16/16 in that file). ruff check, ruff format --check and mypy on the changed module pass. Misc

Open Graph Description: What this PR does / why we need it: An entity whose join key is a Uuid or TimeUuid can be applied, but materializing its feature view fails, because _serialize_val in key_encoding_utils.py only han...

X Description: What this PR does / why we need it: An entity whose join key is a Uuid or TimeUuid can be applied, but materializing its feature view fails, because _serialize_val in key_encoding_utils.py only han...

Opengraph URL: https://github.com/feast-dev/feast/pull/7032

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:764f2396-4099-40c6-20b1-2b3d5369f78b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id977A:19DC88:DE52F2:130C12C:6AFE925F
html-safe-nonce06ca19d667309d303aac86c69c33cb79c442d9b72197ff9c4715e0ce9c07b99e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzdBOjE5REM4ODpERTUyRjI6MTMwQzEyQzo2QUZFOTI1RiIsInZpc2l0b3JfaWQiOiIxMzE1OTA2MjI4NTQxNTY4OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47a3e62ebec40a74553e05a98155351e7632ee81418cdb091620f9c33d44fe90
hovercard-subject-tagpull_request:4904974292
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7032/files
twitter:imagehttps://avatars.githubusercontent.com/u/51020382?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/51020382?s=400&v=4
og:image:altWhat this PR does / why we need it: An entity whose join key is a Uuid or TimeUuid can be applied, but materializing its feature view fails, because _serialize_val in key_encoding_utils.py only han...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7032/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7032%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7032%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7032/files
Reloadhttps://github.com/feast-dev/feast/pull/7032/files
Reloadhttps://github.com/feast-dev/feast/pull/7032/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
MohammadHijjawi97:fix-uuid-entity-key-serializationhttps://github.com/MohammadHijjawi97/feast/tree/fix-uuid-entity-key-serialization
Conversation 2 https://github.com/feast-dev/feast/pull/7032
Commits 2 https://github.com/feast-dev/feast/pull/7032/commits
Checks 22 https://github.com/feast-dev/feast/pull/7032/checks
Files changed https://github.com/feast-dev/feast/pull/7032/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7032/files
fix: Serialize UUID and TimeUuid entity keys https://github.com/feast-dev/feast/pull/7032/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/7032/files
d6bff50 fix: Serialize UUID and TimeUuid entity keys MohammadHijjawi97 Oct 17, 2026 https://github.com/feast-dev/feast/pull/7032/commits/d6bff5051ea86dbc529b66df33016fb04054b62a
7008335 Merge branch 'master' into fix-uuid-entity-key-serialization shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/7032/commits/7008335bf262dda9385c3560c48bcdb7f3209712
Clear filters https://github.com/feast-dev/feast/pull/7032/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7032/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7032/files
key_encoding_utils.py https://github.com/feast-dev/feast/pull/7032/files#diff-8c00934423ce1474b7ad2d80f77815e7722111b77440792adaf7d6378203f6ff
test_key_encoding_utils.py https://github.com/feast-dev/feast/pull/7032/files#diff-d7d45a0d49b0b90d701f73a2e480cd8bc70aca85e5b2cd6cade1ba1afbff5617
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/key_encoding_utils.pyhttps://github.com/feast-dev/feast/pull/7032/files#diff-8c00934423ce1474b7ad2d80f77815e7722111b77440792adaf7d6378203f6ff
View file https://github.com/MohammadHijjawi97/feast/blob/7008335bf262dda9385c3560c48bcdb7f3209712/sdk/python/feast/infra/key_encoding_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7032/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7032/files#diff-8c00934423ce1474b7ad2d80f77815e7722111b77440792adaf7d6378203f6ff
https://github.com/feast-dev/feast/pull/7032/files#diff-8c00934423ce1474b7ad2d80f77815e7722111b77440792adaf7d6378203f6ff
https://github.com/feast-dev/feast/pull/7032/files#diff-8c00934423ce1474b7ad2d80f77815e7722111b77440792adaf7d6378203f6ff
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/test_key_encoding_utils.pyhttps://github.com/feast-dev/feast/pull/7032/files#diff-d7d45a0d49b0b90d701f73a2e480cd8bc70aca85e5b2cd6cade1ba1afbff5617
View file https://github.com/MohammadHijjawi97/feast/blob/7008335bf262dda9385c3560c48bcdb7f3209712/sdk/python/tests/unit/infra/test_key_encoding_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7032/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7032/files#diff-d7d45a0d49b0b90d701f73a2e480cd8bc70aca85e5b2cd6cade1ba1afbff5617
https://github.com/feast-dev/feast/pull/7032/files#diff-d7d45a0d49b0b90d701f73a2e480cd8bc70aca85e5b2cd6cade1ba1afbff5617
https://github.com/feast-dev/feast/pull/7032/files#diff-d7d45a0d49b0b90d701f73a2e480cd8bc70aca85e5b2cd6cade1ba1afbff5617
Please reload this pagehttps://github.com/feast-dev/feast/pull/7032/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.