René's URL Explorer Experiment


Title: feat: Add native_numeric_types to the Milvus online store by simonhearne · Pull Request #7025 · feast-dev/feast · GitHub

Open Graph Title: feat: Add native_numeric_types to the Milvus online store by simonhearne · Pull Request #7025 · feast-dev/feast

X Title: feat: Add native_numeric_types to the Milvus online store by simonhearne · Pull Request #7025 · feast-dev/feast

Description: What this PR does / why we need it: The Milvus online store stores numeric and bool features as VARCHAR unless enable_openai_compatible_store is set. Range filters (gt, gte, lt, lte) on those fields compare strings, so "9" > "100" is true. The flag that fixes this is shared with the SQLite, Postgres and Elasticsearch stores, and its name doesn't say that it controls numeric storage. This PR adds native_numeric_types as a Milvus-specific name for the same behaviour. Either flag stores numeric and bool features as native INT32, INT64, FLOAT, DOUBLE and BOOL fields. The warning logged for numeric range filters on VARCHAR collections now points to the new flag. online_store: type: milvus native_numeric_types: true The docs describe the migration: set the flag, run feast teardown and feast apply, then materialize again. Collections that haven't been recreated keep working, because Feast detects the storage type of each collection. If you would rather not add a Milvus-only alias for a cross-store flag, I can reduce this PR to the docs and the updated warning. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit (Milvus Lite): field types with the default config, with native_numeric_types and with enable_openai_compatible_store; a gt filter compares numerically; values round-trip. Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). The existing server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py pass against a local Milvus 2.6.0, a local Milvus 3.0.2 server and Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged. Misc Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus, following #6882, #6895, #6917, #6921 and #6940.

Open Graph Description: What this PR does / why we need it: The Milvus online store stores numeric and bool features as VARCHAR unless enable_openai_compatible_store is set. Range filters (gt, gte, lt, lte) on those field...

X Description: What this PR does / why we need it: The Milvus online store stores numeric and bool features as VARCHAR unless enable_openai_compatible_store is set. Range filters (gt, gte, lt, lte) on those field...

Opengraph URL: https://github.com/feast-dev/feast/pull/7025

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a1f8ca0-b4c4-2841-2a4e-3e5ea35fad88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98AA:2EA5E9:EEBAC2:13B08A5:6AFE99CC
html-safe-nonceb83e68035aabd7059d685ec5bbfef3ac7718e1933ca540ad63b94e3d9c7922b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEFBOjJFQTVFOTpFRUJBQzI6MTNCMDhBNTo2QUZFOTlDQyIsInZpc2l0b3JfaWQiOiI1MTQwMzA1MzgwOTIzODQwOTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8ef4ee2839650a0b1d64bc397465058d4874f30bd58a74763d2952fe327e9a47
hovercard-subject-tagpull_request:4886043304
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7025/files
twitter:imagehttps://avatars.githubusercontent.com/u/496189?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/496189?s=400&v=4
og:image:altWhat this PR does / why we need it: The Milvus online store stores numeric and bool features as VARCHAR unless enable_openai_compatible_store is set. Range filters (gt, gte, lt, lte) on those field...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7025/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7025%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7025%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7025/files
Reloadhttps://github.com/feast-dev/feast/pull/7025/files
Reloadhttps://github.com/feast-dev/feast/pull/7025/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
simonhearnehttps://github.com/simonhearne
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
simonhearne:feat/milvus-native-numeric-typeshttps://github.com/simonhearne/feast/tree/feat/milvus-native-numeric-types
Conversation 6 https://github.com/feast-dev/feast/pull/7025
Commits 4 https://github.com/feast-dev/feast/pull/7025/commits
Checks 23 https://github.com/feast-dev/feast/pull/7025/checks
Files changed https://github.com/feast-dev/feast/pull/7025/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7025/files
feat: Add native_numeric_types to the Milvus online store https://github.com/feast-dev/feast/pull/7025/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/7025/files
fadb832 feat: Add native_numeric_types to the Milvus online store simonhearne Sep 28, 2026 https://github.com/feast-dev/feast/pull/7025/commits/fadb832e3d703ef5048f529303d673210c38b157
675a536 Merge branch 'master' into feat/milvus-native-numeric-types simonhearne Oct 21, 2026 https://github.com/feast-dev/feast/pull/7025/commits/675a536ba2ae397ca90ae38f309b5ba4c312a271
206309f docs: Add migration warning and correct VARCHAR filter behaviour simonhearne Oct 23, 2026 https://github.com/feast-dev/feast/pull/7025/commits/206309f38e4101649d7d5c0aa923d79487d1a382
19ba48c Merge branch 'master' into feat/milvus-native-numeric-types simonhearne Oct 30, 2026 https://github.com/feast-dev/feast/pull/7025/commits/19ba48c7dc76884edb9c32e0da8504dd67cb81b9
Clear filters https://github.com/feast-dev/feast/pull/7025/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7025/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7025/files
milvus.md https://github.com/feast-dev/feast/pull/7025/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
milvus.py https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/7025/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/milvus.mdhttps://github.com/feast-dev/feast/pull/7025/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
View file https://github.com/simonhearne/feast/blob/19ba48c7dc76884edb9c32e0da8504dd67cb81b9/docs/reference/online-stores/milvus.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7025/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7025/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7025/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7025/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/7025/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.pyhttps://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
View file https://github.com/simonhearne/feast/blob/19ba48c7dc76884edb9c32e0da8504dd67cb81b9/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7025/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/7025/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_milvus_online_store.pyhttps://github.com/feast-dev/feast/pull/7025/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
View file https://github.com/simonhearne/feast/blob/19ba48c7dc76884edb9c32e0da8504dd67cb81b9/sdk/python/tests/unit/infra/online_store/test_milvus_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7025/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7025/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/pull/7025/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
https://github.com/feast-dev/feast/pull/7025/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
Please reload this pagehttps://github.com/feast-dev/feast/pull/7025/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.