René's URL Explorer Experiment


Title: fix: Keep the metrics server running when a Gunicorn worker exits by aborgatin · Pull Request #7012 · feast-dev/feast · GitHub

Open Graph Title: fix: Keep the metrics server running when a Gunicorn worker exits by aborgatin · Pull Request #7012 · feast-dev/feast

X Title: fix: Keep the metrics server running when a Gunicorn worker exits by aborgatin · Pull Request #7012 · feast-dev/feast

Description: What this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing's registry of child processes, and at worker exit multiprocessing.util._exit_function terminates every daemon process in it. So the first worker restart (--max-requests, worker timeout, reload) sends SIGTERM to the master's metrics server, and /metrics stops responding until feast serve is restarted. Every worker exit also logs AssertionError: can only join a child process. Details and steps to reproduce in #7011. When the metrics process is started, this registers an os.register_at_fork(after_in_child=...) hook that removes it from the registry in every child forked from that process. An at-fork hook rather than a Gunicorn hook, so it also covers workers that exit before post_worker_init (e.g. a worker that fails to boot). Workers no longer terminate the metrics server; the master still terminates it on its own exit. Tested with the steps from #7011 (--max-requests 3): macOS, Python 3.12: /metrics returns 200 after the worker restarts (000 before the change), no AssertionError. Linux (python:3.12-slim, 0.67.0 with this metrics.py): 0.67.0 as released: /metrics 000 after the first worker exit. With the change, 2 workers: 19 worker exits, /metrics answered all 300 checks, no AssertionError; after stopping feast serve no metrics process is left. Which issue(s) this PR fixes: Fixes #7011 Checks I've made sure the tests are passing. (pytest sdk/python/tests/unit/test_metrics.py: 127 passed; ruff check and ruff format --check pass; mypy feast reports no errors in metrics.py) My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests – TestMetricsProcessSurvivesForkedChildExit: start_metrics_server registers a daemon stand-in process (fork context, so it starts instantly on every platform), a forked child runs multiprocessing.util._exit_function() as a worker does at exit, then the test checks the process is still alive (before the change it is terminated with -SIGTERM). The /metrics HTTP checks are the end-to-end runs above. Integration tests 🤖 Generated with Claude Code

Open Graph Description: What this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing's ...

X Description: What this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing&#3...

Opengraph URL: https://github.com/feast-dev/feast/pull/7012

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b911d6a8-861e-5ac9-3305-be3b5c2ce248
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAF4:61466:DF5E4B:13163F1:6AFE9256
html-safe-nonceaf1e4fcfcd74ff14026c3101e57ad16af6653e9429b425caf247bf3e241df1ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUY0OjYxNDY2OkRGNUU0QjoxMzE2M0YxOjZBRkU5MjU2IiwidmlzaXRvcl9pZCI6IjMxOTM5OTQwODQwNTgzMDUxMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8ba75a456e6a4143c90824d8fc451767c68f06a1a12b7e9391d62541adc92f54
hovercard-subject-tagpull_request:4858353431
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7012/files
twitter:imagehttps://avatars.githubusercontent.com/u/43031807?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43031807?s=400&v=4
og:image:altWhat this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing's ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7012/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7012%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7012%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7012/files
Reloadhttps://github.com/feast-dev/feast/pull/7012/files
Reloadhttps://github.com/feast-dev/feast/pull/7012/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
aborgatin:fix/metrics-process-worker-exithttps://github.com/aborgatin/feast/tree/fix/metrics-process-worker-exit
Conversation 4 https://github.com/feast-dev/feast/pull/7012
Commits 4 https://github.com/feast-dev/feast/pull/7012/commits
Checks 23 https://github.com/feast-dev/feast/pull/7012/checks
Files changed https://github.com/feast-dev/feast/pull/7012/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7012/files
fix: Keep the metrics server running when a Gunicorn worker exits https://github.com/feast-dev/feast/pull/7012/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/7012/files
1f0df5e fix: Keep the metrics server running when a Gunicorn worker exits aborgatin Oct 14, 2026 https://github.com/feast-dev/feast/pull/7012/commits/1f0df5e644164e07f62e9fa30e9d959231a51338
2d0d723 test: Wait for the metrics server before forking in the worker-exit test aborgatin Oct 14, 2026 https://github.com/feast-dev/feast/pull/7012/commits/2d0d723d9644ff934f33142a6ff6fd8f27a134be
0e58508 test: Use an instant stand-in process in the worker-exit test aborgatin Oct 14, 2026 https://github.com/feast-dev/feast/pull/7012/commits/0e58508e19a528b3e8d4e4c6418d68f70a962f4d
125f4e8 test: Check active_children() in the forked child instead of running … aborgatin Oct 16, 2026 https://github.com/feast-dev/feast/pull/7012/commits/125f4e824662742b1ac358dc0bbb2abec73afbec
Clear filters https://github.com/feast-dev/feast/pull/7012/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7012/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7012/files
metrics.py https://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
test_metrics.py https://github.com/feast-dev/feast/pull/7012/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/metrics.pyhttps://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
View file https://github.com/aborgatin/feast/blob/125f4e824662742b1ac358dc0bbb2abec73afbec/sdk/python/feast/metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7012/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/7012/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_metrics.pyhttps://github.com/feast-dev/feast/pull/7012/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
View file https://github.com/aborgatin/feast/blob/125f4e824662742b1ac358dc0bbb2abec73afbec/sdk/python/tests/unit/test_metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7012/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7012/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/7012/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/7012/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/7012/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
Please reload this pagehttps://github.com/feast-dev/feast/pull/7012/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.