René's URL Explorer Experiment


Title: fix: Keep the metrics server running when a Gunicorn worker exits by aborgatin · Pull Request #7012 · feast-dev/feast · GitHub

Open Graph Title: fix: Keep the metrics server running when a Gunicorn worker exits by aborgatin · Pull Request #7012 · feast-dev/feast

X Title: fix: Keep the metrics server running when a Gunicorn worker exits by aborgatin · Pull Request #7012 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing's ...

X Description: What this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing&#3...

Opengraph URL: https://github.com/feast-dev/feast/pull/7012

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:642a3c97-3b54-716e-e29b-70bd4e71f3ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC440:2A4404:DD0E43:12344BB:6AFE926C
html-safe-nonce80190bef38c97f159a9119cae73c17f3e3b2ba1f8f123635f5162a39608c46f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDQwOjJBNDQwNDpERDBFNDM6MTIzNDRCQjo2QUZFOTI2QyIsInZpc2l0b3JfaWQiOiI0MDQ5NjA4MDk1NDg2MDg3Nzg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac19854559d8b4446e40548bf4b1fa21d21ec37646eda35ca6e9220744879b9621
hovercard-subject-tagpull_request:4858353431
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7012/commits
twitter:imagehttps://opengraph.githubassets.com/cf43e9c9c3d5731ec4fee7afc43ac9b96f89a75572bbbd9481b88c54915de1a9/feast-dev/feast/pull/7012
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf43e9c9c3d5731ec4fee7afc43ac9b96f89a75572bbbd9481b88c54915de1a9/feast-dev/feast/pull/7012
og:image:altWhat this PR does / why we need it: Since #6855 the metrics server runs in a multiprocessing.Process(daemon=True) started in the Gunicorn master. Every forked worker inherits multiprocessing's ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaborgatin
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7012/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7012%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7012%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7012/commits
Reloadhttps://github.com/feast-dev/feast/pull/7012/commits
Reloadhttps://github.com/feast-dev/feast/pull/7012/commits
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
aborgatin:fix/metrics-process-worker-exithttps://github.com/aborgatin/feast/tree/fix/metrics-process-worker-exit
Conversationhttps://github.com/feast-dev/feast/pull/7012
Commits4 (4)https://github.com/feast-dev/feast/pull/7012/commits
Checkshttps://github.com/feast-dev/feast/pull/7012/checks
Files changedhttps://github.com/feast-dev/feast/pull/7012/files
fix: Keep the metrics server running when a Gunicorn worker exitshttps://github.com/feast-dev/feast/pull/7012/commits#top
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
aborgatin:fix/metrics-process-worker-exithttps://github.com/aborgatin/feast/tree/fix/metrics-process-worker-exit
fix: Keep the metrics server running when a Gunicorn worker exitshttps://github.com/feast-dev/feast/pull/7012/commits/1f0df5e644164e07f62e9fa30e9d959231a51338
ntkatholehttps://github.com/feast-dev/feast/commits?author=ntkathole
1f0df5ehttps://github.com/feast-dev/feast/pull/7012/commits/1f0df5e644164e07f62e9fa30e9d959231a51338
https://github.com/feast-dev/feast/tree/1f0df5e644164e07f62e9fa30e9d959231a51338
test: Wait for the metrics server before forking in the worker-exit testhttps://github.com/feast-dev/feast/pull/7012/commits/2d0d723d9644ff934f33142a6ff6fd8f27a134be
ntkatholehttps://github.com/feast-dev/feast/commits?author=ntkathole
2d0d723https://github.com/feast-dev/feast/pull/7012/commits/2d0d723d9644ff934f33142a6ff6fd8f27a134be
https://github.com/feast-dev/feast/tree/2d0d723d9644ff934f33142a6ff6fd8f27a134be
test: Use an instant stand-in process in the worker-exit testhttps://github.com/feast-dev/feast/pull/7012/commits/0e58508e19a528b3e8d4e4c6418d68f70a962f4d
ntkatholehttps://github.com/feast-dev/feast/commits?author=ntkathole
0e58508https://github.com/feast-dev/feast/pull/7012/commits/0e58508e19a528b3e8d4e4c6418d68f70a962f4d
https://github.com/feast-dev/feast/tree/0e58508e19a528b3e8d4e4c6418d68f70a962f4d
test: Check active_children() in the forked child instead of running _exit_functionhttps://github.com/feast-dev/feast/pull/7012/commits/125f4e824662742b1ac358dc0bbb2abec73afbec
ntkatholehttps://github.com/feast-dev/feast/commits?author=ntkathole
125f4e8https://github.com/feast-dev/feast/pull/7012/commits/125f4e824662742b1ac358dc0bbb2abec73afbec
https://github.com/feast-dev/feast/tree/125f4e824662742b1ac358dc0bbb2abec73afbec
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.