René's URL Explorer Experiment


Title: fix: Keep an ODFV output that shares its name with a source feature by luc-pimentel · Pull Request #7009 · feast-dev/feast · GitHub

Open Graph Title: fix: Keep an ODFV output that shares its name with a source feature by luc-pimentel · Pull Request #7009 · feast-dev/feast

X Title: fix: Keep an ODFV output that shares its name with a source feature by luc-pimentel · Pull Request #7009 · feast-dev/feast

Description: What this PR does / why we need it: Since 0.62.0 (#6140) get_historical_features fetches every feature of an on demand feature view's source view, requested or not. When one of those source features has the same name as the ODFV output, which schema inference over a wider table produces without anyone noticing, the result is wrong in two ways: default names: the frame has two revenue_plus_one columns, the source value and the transformed one full_feature_names=True: only customer_stats__revenue_plus_one comes back and the ODFV output is silently missing. get_online_features drops it the same way. 0.51.0 through 0.61.0 return the transformed value once in both modes. Two mechanisms. RetrievalJob.to_arrow appended the ODFV column next to the same-named source column. With full names, transform_arrow and transform_dict copy the source column to a short-name alias for the UDF, the UDF returns its output under that same short name, and the alias cleanup drops it. The fix skips the ODFV's own output names in the alias cleanup (all three transform paths) and makes to_arrow replace a same-named column instead of appending a second one. The unrequested-output filter from #6140 is untouched. Unrequested source-view features are still returned with the result, as they have been since 0.62.0; that is left as is here and may deserve its own issue. Open PR #6900 touches the same cleanup loop for python-mode full names online and composes with this change. Which issue(s) this PR fixes: Fixes #5534 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc New tests in tests/unit/test_on_demand_pandas_transformation.py: offline retrieval in pandas and python mode with default and full names, and online retrieval with both naming modes, all with a source feature named like the ODFV output. They fail on master (5 of 6) and pass with the fix. uv run pytest sdk/python/tests/unit/test_on_demand_pandas_transformation.py -q 15 passed Before and after on the setup above (a parquet with revenue and revenue_plus_one = -999, a FeatureView declaring both, a pandas ODFV computing revenue_plus_one = revenue + 1, request customer_stats:revenue and revenue_plus_one:revenue_plus_one): default names full_feature_names=True 0.67.0 two revenue_plus_one columns: [-999, -999, -999] and [11, 21, 31] customer_stats__revenue_plus_one = [-999, ...], ODFV output absent this branch revenue_plus_one = [11, 21, 31] revenue_plus_one__revenue_plus_one = [11, 21, 31]

Open Graph Description: What this PR does / why we need it: Since 0.62.0 (#6140) get_historical_features fetches every feature of an on demand feature view's source view, requested or not. When one of those source fea...

X Description: What this PR does / why we need it: Since 0.62.0 (#6140) get_historical_features fetches every feature of an on demand feature view's source view, requested or not. When one of those source...

Opengraph URL: https://github.com/feast-dev/feast/pull/7009

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:26e8f1e0-f2b7-c8c0-a158-26629e516047
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE25A:178215:67E424:8BC2A5:6AFEA865
html-safe-nonceec5d1579b15df004db1df1a8c62a3743c798d7215e8bb168619b69f48a7df015
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjVBOjE3ODIxNTo2N0U0MjQ6OEJDMkE1OjZBRkVBODY1IiwidmlzaXRvcl9pZCI6IjI4OTYzMTY5NjU5OTM3NTI2NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3173135d1d3954e09c656c6caac22ba70bcdc286b8370ca132be95aa7ff1cf9d
hovercard-subject-tagpull_request:4851822996
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7009/files
twitter:imagehttps://avatars.githubusercontent.com/u/154371376?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/154371376?s=400&v=4
og:image:altWhat this PR does / why we need it: Since 0.62.0 (#6140) get_historical_features fetches every feature of an on demand feature view's source view, requested or not. When one of those source fea...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7009/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7009%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7009%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7009/files
Reloadhttps://github.com/feast-dev/feast/pull/7009/files
Reloadhttps://github.com/feast-dev/feast/pull/7009/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
luc-pimentelhttps://github.com/luc-pimentel
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
luc-pimentel:fix/5534-odfv-output-name-collisionhttps://github.com/luc-pimentel/feast/tree/fix/5534-odfv-output-name-collision
Conversation 3 https://github.com/feast-dev/feast/pull/7009
Commits 3 https://github.com/feast-dev/feast/pull/7009/commits
Checks 1 https://github.com/feast-dev/feast/pull/7009/checks
Files changed https://github.com/feast-dev/feast/pull/7009/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7009/files
fix: Keep an ODFV output that shares its name with a source feature https://github.com/feast-dev/feast/pull/7009/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/7009/files
6f0f161 test: cover an ODFV output that shares its name with a source feature luc-pimentel Oct 14, 2026 https://github.com/feast-dev/feast/pull/7009/commits/6f0f161bdfe3631741bfdcfd1f6abf12eb4ec30f
08cf3ac fix: Keep an ODFV output that shares its name with a source feature luc-pimentel Oct 14, 2026 https://github.com/feast-dev/feast/pull/7009/commits/08cf3ac2b9416c0a6c4157f5686decc36536edd0
fdcd851 test: Cover both refs requested and the ibis path under an ODFV name … luc-pimentel Oct 23, 2026 https://github.com/feast-dev/feast/pull/7009/commits/fdcd851f810f9843aee7f3b713914b4358bcf97a
Clear filters https://github.com/feast-dev/feast/pull/7009/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7009/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7009/files
offline_store.py https://github.com/feast-dev/feast/pull/7009/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
on_demand_feature_view.py https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
test_on_demand_pandas_transformation.py https://github.com/feast-dev/feast/pull/7009/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L23
sdk/python/feast/infra/offline_stores/offline_store.pyhttps://github.com/feast-dev/feast/pull/7009/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
View file https://github.com/feast-dev/feast/blob/fdcd851f810f9843aee7f3b713914b4358bcf97a/sdk/python/feast/infra/offline_stores/offline_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7009/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7009/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/7009/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/on_demand_feature_view.pyhttps://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
View file https://github.com/feast-dev/feast/blob/fdcd851f810f9843aee7f3b713914b4358bcf97a/sdk/python/feast/on_demand_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7009/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/7009/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_pandas_transformation.pyhttps://github.com/feast-dev/feast/pull/7009/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
View file https://github.com/feast-dev/feast/blob/fdcd851f810f9843aee7f3b713914b4358bcf97a/sdk/python/tests/unit/test_on_demand_pandas_transformation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7009/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7009/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/7009/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/7009/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/7009/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.