René's URL Explorer Experiment


Title: fix: Infer the entity timestamp column with the Polars backend by YHC66 · Pull Request #7004 · feast-dev/feast · GitHub

Open Graph Title: fix: Infer the entity timestamp column with the Polars backend by YHC66 · Pull Request #7004 · feast-dev/feast

X Title: fix: Infer the entity timestamp column with the Polars backend by YHC66 · Pull Request #7004 · feast-dev/feast

Description: What this PR does / why we need it: Another small follow-up to #6965 / #6992 for the local compute engine's Polars backend. LocalJoinNode converts context.entity_df to a backend DataFrame and then infers the entity timestamp column from that DataFrame's dtypes: entity_df = self.backend.from_arrow(pa.Table.from_pandas(context.entity_df)) entity_schema = dict(zip(entity_df.columns, entity_df.dtypes)) entity_ts_col = infer_entity_timestamp_column(entity_schema) infer_event_timestamp_from_entity_df falls back to "the only datetime column" when there is no event_timestamp column, and it detects datetime columns with pandas' is_datetime64_any_dtype. That check does not recognise polars dtypes, so with backend: polars an entity_df whose timestamp column has another name raises: EntityTimestampInferenceException: Please provide an entity_df with a column named event_timestamp representing the time of events. The same entity_df works with the pandas backend. context.entity_df is a pandas DataFrame at this point (it is passed to pa.Table.from_pandas on the line above), so the schema for the inference is now taken from it. Nothing changes for the pandas backend. A new parametrized test joins against an entity_df with a ts column on both backends; the polars case uses pytest.importorskip("polars"), so it is skipped where polars isn't installed. Which issue(s) this PR fixes: No existing issue; found while comparing the local nodes' output between the two backends. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Local results (Python 3.12): Setup Result master + polars 2.0.0, new test the polars case fails with EntityTimestampInferenceException, the pandas case passes this branch + polars 2.0.0 tests/unit/infra/compute_engines: 196 passed this branch + polars 1.34.0 local/test_nodes.py: 17 passed this branch, polars not installed 192 passed, 4 skipped ruff check, ruff format --check and mypy on local/nodes.py pass. Misc With this in, the join, dedup, filter and aggregation nodes gave the same output on both backends for the inputs I compared (with and without an entity_df, several inputs, TTL and expression filters, the supported aggregation functions).

Open Graph Description: What this PR does / why we need it: Another small follow-up to #6965 / #6992 for the local compute engine's Polars backend. LocalJoinNode converts context.entity_df to a backend DataFrame and t...

X Description: What this PR does / why we need it: Another small follow-up to #6965 / #6992 for the local compute engine's Polars backend. LocalJoinNode converts context.entity_df to a backend DataFrame a...

Opengraph URL: https://github.com/feast-dev/feast/pull/7004

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:54bb452c-912e-379e-05fd-f1d8366112c3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EFC:262F52:FE6097:14D1CF3:6AFE9831
html-safe-noncedb9ff94ac9be69057ce8d72c5905aed1757832cebf296fbd112bab8030bbde68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUZDOjI2MkY1MjpGRTYwOTc6MTREMUNGMzo2QUZFOTgzMSIsInZpc2l0b3JfaWQiOiI4NDkwNTE5MzgwOTMxNTQ5MjMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2f09a4b6946da1a4b71015364671ab25b7098007caf307c7fcaac2e7cae4752c
hovercard-subject-tagpull_request:4847041303
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7004/files
twitter:imagehttps://avatars.githubusercontent.com/u/122972532?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/122972532?s=400&v=4
og:image:altWhat this PR does / why we need it: Another small follow-up to #6965 / #6992 for the local compute engine's Polars backend. LocalJoinNode converts context.entity_df to a backend DataFrame and t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7004/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7004%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7004%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7004/files
Reloadhttps://github.com/feast-dev/feast/pull/7004/files
Reloadhttps://github.com/feast-dev/feast/pull/7004/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
YHC66https://github.com/YHC66
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
YHC66:fix-polars-backend-entity-ts-inferencehttps://github.com/YHC66/feast/tree/fix-polars-backend-entity-ts-inference
Conversation 1 https://github.com/feast-dev/feast/pull/7004
Commits 1 https://github.com/feast-dev/feast/pull/7004/commits
Checks 27 https://github.com/feast-dev/feast/pull/7004/checks
Files changed 2 https://github.com/feast-dev/feast/pull/7004/files
fix: Infer the entity timestamp column with the Polars backend https://github.com/feast-dev/feast/pull/7004/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/7004/files
986abac fix: Infer the entity timestamp column with the Polars backend YHC66 Oct 13, 2026 https://github.com/feast-dev/feast/pull/7004/commits/986abac160c2313471bb2ee6686cdaa485f5c403
Clear filters https://github.com/feast-dev/feast/pull/7004/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7004/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7004/files
nodes.py https://github.com/feast-dev/feast/pull/7004/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
test_nodes.py https://github.com/feast-dev/feast/pull/7004/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/local/nodes.pyhttps://github.com/feast-dev/feast/pull/7004/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
View file https://github.com/feast-dev/feast/blob/986abac160c2313471bb2ee6686cdaa485f5c403/sdk/python/feast/infra/compute_engines/local/nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7004/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7004/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
https://github.com/feast-dev/feast/pull/7004/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/compute_engines/local/test_nodes.pyhttps://github.com/feast-dev/feast/pull/7004/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
View file https://github.com/feast-dev/feast/blob/986abac160c2313471bb2ee6686cdaa485f5c403/sdk/python/tests/unit/infra/compute_engines/local/test_nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7004/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7004/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/7004/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
Please reload this pagehttps://github.com/feast-dev/feast/pull/7004/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.