René's URL Explorer Experiment


Title: feat: Add SavedDatasetLanceStorage by haoxu0 · Pull Request #7001 · feast-dev/feast · GitHub

Open Graph Title: feat: Add SavedDatasetLanceStorage by haoxu0 · Pull Request #7001 · feast-dev/feast

X Title: feat: Add SavedDatasetLanceStorage by haoxu0 · Pull Request #7001 · feast-dev/feast

Description: What this PR does / why we need it: Adds SavedDatasetLanceStorage, so an existing Lance dataset can be recorded as a saved dataset without moving or rewriting it. This is the path for a dataset produced outside Feast. create_saved_dataset takes a RetrievalJob, executes it and persists the result, which is wrong for an embedding dataset that a Ray or Spark job already wrote to Lance. BaseRegistry.apply_saved_dataset records metadata only, and that is what this storage class is for: storage = SavedDatasetLanceStorage(LanceFormat(version=7), uri="s3://bucket/embeddings") registry.apply_saved_dataset( SavedDataset( name="poi_embeddings_v7", features=[], join_keys=[], storage=storage, tags={"model": "clip-vit-l-14", "recall_at_10": "0.9137"}, ), project, ) The format must pin a version SavedDatasetLanceStorage rejects an unpinned LanceFormat. A saved dataset addressing whatever version is latest at read time does not identify the rows it was created from, so a measurement recorded against it stops being attributable. version is preferable to tag, since a tag can be moved afterwards. Note that LanceSource defaults table_format to an unpinned LanceFormat rather than None, so from_data_source on a plain source raises rather than silently recording a drifting reference. Dispatch Lance is the fourth class to claim the custom_storage oneof field, after postgres, clickhouse and couchbase. to_proto therefore goes through SavedDatasetStorage._custom_storage_proto (#6988) so the payload records the writing class; otherwise from_proto would resolve by import order. Verified that a Lance payload reads back as SavedDatasetLanceStorage with all four claimants registered, across several import orders: [postgres clickhouse couchbase lance] claimants=4 -> SavedDatasetLanceStorage version=7 [lance postgres clickhouse couchbase] claimants=4 -> SavedDatasetLanceStorage version=7 [clickhouse lance couchbase postgres] claimants=4 -> SavedDatasetLanceStorage version=7 LanceSource is also registered in _DATA_SOURCE_TO_SAVED_DATASET_STORAGE, so SavedDatasetStorage.from_data_source resolves it. Which issue(s) this PR fixes: N/A. Follows #6988, which made the shared custom_storage field safe for a fourth claimant. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change sdk/python/tests/unit/infra/data_sources/test_saved_dataset_lance_storage.py, 14 tests: round trip by uri and by namespace+table, the payload recording the storage class, an unpinned format refused, a wrong-typed format refused, uri and table exclusivity, a table without namespace_impl refused, to_data_source and from_data_source preserving the pin, a non-Lance source refused, the _DATA_SOURCE_TO_SAVED_DATASET_STORAGE registration, and dispatch with all four custom_storage claimants present. Against master: ruff check and ruff format --check clean, and mypy feast reports the same 24 pre-existing errors as origin/master, none added. The adjacent merged suites (tests/unit/infra/data_sources/, tests/unit/test_table_format.py, tests/unit/test_saved_dataset_storage_dispatch.py) show an identical set of failures to clean master, all in test_mlflow_dataset_source.py from a missing local dependency.

Open Graph Description: What this PR does / why we need it: Adds SavedDatasetLanceStorage, so an existing Lance dataset can be recorded as a saved dataset without moving or rewriting it. This is the path for a dataset pro...

X Description: What this PR does / why we need it: Adds SavedDatasetLanceStorage, so an existing Lance dataset can be recorded as a saved dataset without moving or rewriting it. This is the path for a dataset pro...

Opengraph URL: https://github.com/feast-dev/feast/pull/7001

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6e64c3da-c229-8cd8-8f4c-1d685d8866af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD0C:2EA5E9:EF661A:13BECDB:6AFE9A01
html-safe-nonce52121c73498d27edda20b55e056bdf792aac2bb5ffc9bc2e9b6626a06110dcb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDBDOjJFQTVFOTpFRjY2MUE6MTNCRUNEQjo2QUZFOUEwMSIsInZpc2l0b3JfaWQiOiIxODUxMDk2NTAzNjgzMDI5NTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd105336b24df21c925ab9f258585a00f03f9886a5feee480238f850e4cc390ef
hovercard-subject-tagpull_request:4839690229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/7001/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altWhat this PR does / why we need it: Adds SavedDatasetLanceStorage, so an existing Lance dataset can be recorded as a saved dataset without moving or rewriting it. This is the path for a dataset pro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/7001/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7001%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F7001%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/7001/files
Reloadhttps://github.com/feast-dev/feast/pull/7001/files
Reloadhttps://github.com/feast-dev/feast/pull/7001/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:feat/saved-dataset-lance-storagehttps://github.com/haoxu0/feast/tree/feat/saved-dataset-lance-storage
Conversation 1 https://github.com/feast-dev/feast/pull/7001
Commits 1 https://github.com/feast-dev/feast/pull/7001/commits
Checks 23 https://github.com/feast-dev/feast/pull/7001/checks
Files changed https://github.com/feast-dev/feast/pull/7001/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7001/files
feat: Add SavedDatasetLanceStorage https://github.com/feast-dev/feast/pull/7001/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/7001/files
e72dd18 feat: Add SavedDatasetLanceStorage haoxu0 Oct 13, 2026 https://github.com/feast-dev/feast/pull/7001/commits/e72dd182ebfee467a3e418a32c86c257ef68c726
Clear filters https://github.com/feast-dev/feast/pull/7001/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7001/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/7001/files
lance_source.py https://github.com/feast-dev/feast/pull/7001/files#diff-de55de91f24b10043a4361da7e06d46f1eb87f3f9f9150e1cb9a0e544f39cfdf
saved_dataset.py https://github.com/feast-dev/feast/pull/7001/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
test_saved_dataset_lance_storage.py https://github.com/feast-dev/feast/pull/7001/files#diff-695c94f29560503adccc850b934595c607994d10e86a04dd393dc5ac98e4caaf
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/data_sources/contrib/lance/lance_source.pyhttps://github.com/feast-dev/feast/pull/7001/files#diff-de55de91f24b10043a4361da7e06d46f1eb87f3f9f9150e1cb9a0e544f39cfdf
View file https://github.com/haoxu0/feast/blob/e72dd182ebfee467a3e418a32c86c257ef68c726/sdk/python/feast/infra/data_sources/contrib/lance/lance_source.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7001/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7001/files#diff-de55de91f24b10043a4361da7e06d46f1eb87f3f9f9150e1cb9a0e544f39cfdf
https://github.com/feast-dev/feast/pull/7001/files#diff-de55de91f24b10043a4361da7e06d46f1eb87f3f9f9150e1cb9a0e544f39cfdf
https://github.com/feast-dev/feast/pull/7001/files#diff-de55de91f24b10043a4361da7e06d46f1eb87f3f9f9150e1cb9a0e544f39cfdf
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/saved_dataset.pyhttps://github.com/feast-dev/feast/pull/7001/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
View file https://github.com/haoxu0/feast/blob/e72dd182ebfee467a3e418a32c86c257ef68c726/sdk/python/feast/saved_dataset.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7001/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/7001/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
https://github.com/feast-dev/feast/pull/7001/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/data_sources/test_saved_dataset_lance_storage.pyhttps://github.com/feast-dev/feast/pull/7001/files#diff-695c94f29560503adccc850b934595c607994d10e86a04dd393dc5ac98e4caaf
View file https://github.com/haoxu0/feast/blob/e72dd182ebfee467a3e418a32c86c257ef68c726/sdk/python/tests/unit/infra/data_sources/test_saved_dataset_lance_storage.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/7001/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/7001/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.