| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0b0f2ea6-863c-fef2-8c26-f68bd3cacdd9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED04:69118:2571CE7:33EA6DF:697C956C |
| html-safe-nonce | 8f929deeec3162c1f00fb5757c597d35226db6d9320836c462452bb95a9eff57 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDA0OjY5MTE4OjI1NzFDRTc6MzNFQTZERjo2OTdDOTU2QyIsInZpc2l0b3JfaWQiOiI0NzczMjE3MzAwNjU4Mjk2MTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cd8642ba84b08fd31a41a73132705eadb84e224986fbc4f7c9fbbc070724564a |
| hovercard-subject-tag | pull_request:417716234 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/700/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2c2b4d6a136e334210340c5bf8e628b87d70429cc55c063790c3b66ba51ce3f5/feast-dev/feast/pull/700 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2c2b4d6a136e334210340c5bf8e628b87d70429cc55c063790c3b66ba51ce3f5/feast-dev/feast/pull/700 |
| og:image:alt | What this PR does / why we need it:
Adds .proto to the package of Java generated proto code in order to differentiate it from non-proto code.
Example: feast.core.CoreServiceGrpc to feast.proto.core... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | woop |
| hostname | github.com |
| expected-hostname | github.com |
| None | f30e23787c843d478679169eb69bc1bf04c9aaf526e14cad93570a516ad7b047 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0bf17967680d17d40933881af78023e6675fa045 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/700#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F700 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F700 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/700 |
| Reload | https://github.com/feast-dev/feast/pull/700 |
| Reload | https://github.com/feast-dev/feast/pull/700 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
66
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/700#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| woop:adjust-proto-packages | https://github.com/woop/feast/tree/adjust-proto-packages |
|
Add .proto to packages of Protobuf generated Java classes
| https://github.com/feast-dev/feast/pull/700#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| woop:adjust-proto-packages | https://github.com/woop/feast/tree/adjust-proto-packages |
|
Conversation
6
| https://github.com/feast-dev/feast/pull/700 |
|
Commits
5
| https://github.com/feast-dev/feast/pull/700/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/700/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/700/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/woop |
| woop | https://github.com/woop |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#issue-617881321 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| #684 | https://github.com/feast-dev/feast/issues/684 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| https://github.com/woop |
| woop | https://github.com/woop |
| davidheryanto | https://github.com/davidheryanto |
| khorshuheng | https://github.com/khorshuheng |
| pradithya | https://github.com/pradithya |
| zhilingc | https://github.com/zhilingc |
| code owners | https://github.com/feast-dev/feast/blob/561b62152a7869dc505576d4e063e820cc71b718/.github/CODEOWNERS#L4 |
| May 14, 2020 02:44 | https://github.com/feast-dev/feast/pull/700#event-3334619613 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
needs-kind
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334619763 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
compat/breaking
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Acompat%2Fbreaking |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334619938 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334620043 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
kind/housekeeping
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334620180 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
needs-kind
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334620200 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334620515 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#event-3334620968 |
| https://github.com/woop |
| woop | https://github.com/woop |
| force-pushed | https://github.com/feast-dev/feast/compare/83e76495f8019e545f726fbcfd28a280b3a08998..39ace306a276213119fcb2778aab7d8dad355140 |
| 83e7649 | https://github.com/feast-dev/feast/commit/83e76495f8019e545f726fbcfd28a280b3a08998 |
| 39ace30 | https://github.com/feast-dev/feast/commit/39ace306a276213119fcb2778aab7d8dad355140 |
|
Compare
| https://github.com/feast-dev/feast/compare/83e76495f8019e545f726fbcfd28a280b3a08998..39ace306a276213119fcb2778aab7d8dad355140 |
| May 14, 2020 02:46 | https://github.com/feast-dev/feast/pull/700#event-3334623239 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| May 14, 2020 | https://github.com/feast-dev/feast/pull/700#issuecomment-628425552 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#issuecomment-629625961 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| woop | https://github.com/woop |
| May 16, 2020 20:25 | https://github.com/feast-dev/feast/pull/700#commits-pushed-a9e385c |
|
| https://github.com/woop |
| Add .proto to protobuf java package | https://github.com/feast-dev/feast/pull/700/commits/a9e385cb8063488f81618c600908a713374a5e93 |
| a9e385c | https://github.com/feast-dev/feast/pull/700/commits/a9e385cb8063488f81618c600908a713374a5e93 |
|
| https://github.com/woop |
| Update dependencies on proto generated Java classes | https://github.com/feast-dev/feast/pull/700/commits/00895764a9da9c9794e5a7e01abbc301c79f0792 |
| 0089576 | https://github.com/feast-dev/feast/pull/700/commits/00895764a9da9c9794e5a7e01abbc301c79f0792 |
|
| https://github.com/woop |
| Remove io.grpc.vendor from pom.xml | https://github.com/feast-dev/feast/pull/700/commits/8d93b412194cfc4b13b38315827a96d8d6430f7f |
| 8d93b41 | https://github.com/feast-dev/feast/pull/700/commits/8d93b412194cfc4b13b38315827a96d8d6430f7f |
|
| https://github.com/woop |
| Remove vendor from pom.xml | https://github.com/feast-dev/feast/pull/700/commits/4fa3954f1646cdc02c0c2af62eb9f591449df654 |
| 4fa3954 | https://github.com/feast-dev/feast/pull/700/commits/4fa3954f1646cdc02c0c2af62eb9f591449df654 |
| https://github.com/woop |
| woop | https://github.com/woop |
| force-pushed | https://github.com/feast-dev/feast/compare/436c8b4bb6093a6dbdc31e5e581956636ecf2535..4fa3954f1646cdc02c0c2af62eb9f591449df654 |
| 436c8b4 | https://github.com/feast-dev/feast/commit/436c8b4bb6093a6dbdc31e5e581956636ecf2535 |
| 4fa3954 | https://github.com/feast-dev/feast/commit/4fa3954f1646cdc02c0c2af62eb9f591449df654 |
|
Compare
| https://github.com/feast-dev/feast/compare/436c8b4bb6093a6dbdc31e5e581956636ecf2535..4fa3954f1646cdc02c0c2af62eb9f591449df654 |
| May 16, 2020 12:26 | https://github.com/feast-dev/feast/pull/700#event-3343549079 |
|
| https://github.com/woop |
| Fix formatting on JobUpdateTask | https://github.com/feast-dev/feast/pull/700/commits/8c6180f193ff236336fdbef3f7fcacac9fedf9c0 |
| 8c6180f | https://github.com/feast-dev/feast/pull/700/commits/8c6180f193ff236336fdbef3f7fcacac9fedf9c0 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#issuecomment-629640811 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#event-3343580482 |
| https://github.com/ches |
| ches | https://github.com/ches |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#issuecomment-629649177 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| @woop | https://github.com/woop |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| ches | https://github.com/ches |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#event-3343621745 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
May 16, 2020
| https://github.com/feast-dev/feast/pull/700#pullrequestreview-413078819 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/700/files/8c6180f193ff236336fdbef3f7fcacac9fedf9c0 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#issuecomment-629650354 |
| ches | https://github.com/feast-dev/feast/pull/700#pullrequestreview-413078819 |
| woop | https://github.com/feast-dev/feast/pull/700 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 14cae74 | https://github.com/feast-dev/feast/commit/14cae741068b4e18a56aaea211099564d78a703b |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#event-3343629125 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 16, 2020 | https://github.com/feast-dev/feast/pull/700#issuecomment-629652268 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
| @woop | https://github.com/woop |
| @mrzzy | https://github.com/mrzzy |
| single commit (well it's 4 now) | https://github.com/feast-dev/feast/pull/693/commits |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
|
Expand Go and Java SDK Test Coverage
#720
| https://github.com/feast-dev/feast/pull/720 |
|
Fix Go and Java SDK Regressions
#729
| https://github.com/feast-dev/feast/pull/729 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F700 |
|
| https://github.com/ches |
|
ches
| https://github.com/ches |
|
| https://github.com/feast-dev/feast/pull/700/files/8c6180f193ff236336fdbef3f7fcacac9fedf9c0 |
|
| https://github.com/davidheryanto |
|
davidheryanto
| https://github.com/davidheryanto |
|
| https://github.com/khorshuheng |
|
khorshuheng
| https://github.com/khorshuheng |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
| https://github.com/ches |
|
ches
| https://github.com/ches |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
compat/breaking
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Acompat%2Fbreaking |
|
kind/housekeeping
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
|
Package conflicts exist between proto and non-proto modules.
| https://github.com/feast-dev/feast/issues/684 |
| Please reload this page | https://github.com/feast-dev/feast/pull/700 |
|
| https://github.com/woop |
|
| https://github.com/zhilingc |
|
| https://github.com/ches |
|
| https://github.com/feast-ci-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |