René's URL Explorer Experiment


Title: fix: Apply on demand feature views in SparkRetrievalJob.to_spark_df() by shanalyb · Pull Request #6993 · feast-dev/feast · GitHub

Open Graph Title: fix: Apply on demand feature views in SparkRetrievalJob.to_spark_df() by shanalyb · Pull Request #6993 · feast-dev/feast

X Title: fix: Apply on demand feature views in SparkRetrievalJob.to_spark_df() by shanalyb · Pull Request #6993 · feast-dev/feast

Description: What this PR does / why we need it: SparkRetrievalJob.to_spark_df() returns the raw query result, while on demand feature views are applied only in RetrievalJob.to_arrow(). The Spark DataFrame therefore has no ODFV columns, and neither do persist() and to_feast_df(), which build on it. to_spark_df() now computes the requested ODFV features on the executors with mapInArrow. SparkRetrievalJob subclasses now override _to_spark_df_internal() instead of to_spark_df(). Added test_to_spark_df_applies_odfvs. Which issue(s) this PR fixes: Related to #5475 (no new spark modes) and #6359. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change

Open Graph Description: What this PR does / why we need it: SparkRetrievalJob.to_spark_df() returns the raw query result, while on demand feature views are applied only in RetrievalJob.to_arrow(). The Spark DataFrame ther...

X Description: What this PR does / why we need it: SparkRetrievalJob.to_spark_df() returns the raw query result, while on demand feature views are applied only in RetrievalJob.to_arrow(). The Spark DataFrame ther...

Opengraph URL: https://github.com/feast-dev/feast/pull/6993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5a11f0da-37a0-c141-d7e1-b5aa936583d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC4D2:1EBFF3:E4509:12D14C:6AFE9275
html-safe-nonced8623505c4217e674ba3d8c533333ac39c354a0d2dfe3d155e825412d5c1bafa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEQyOjFFQkZGMzpFNDUwOToxMkQxNEM6NkFGRTkyNzUiLCJ2aXNpdG9yX2lkIjoiOTIyMDEyMjE1Mjg2MTA3ODEzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0145fcbe8a9e9221afa78f147f42eb1371c6240feadf2130682204bfd307725a
hovercard-subject-tagpull_request:4815180790
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6993/files
twitter:imagehttps://avatars.githubusercontent.com/u/52510405?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52510405?s=400&v=4
og:image:altWhat this PR does / why we need it: SparkRetrievalJob.to_spark_df() returns the raw query result, while on demand feature views are applied only in RetrievalJob.to_arrow(). The Spark DataFrame ther...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6993/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6993%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6993%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6993/files
Reloadhttps://github.com/feast-dev/feast/pull/6993/files
Reloadhttps://github.com/feast-dev/feast/pull/6993/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
shanalyb:fix/spark-odfv-to-spark-dfhttps://github.com/shanalyb/feast/tree/fix/spark-odfv-to-spark-df
Conversation 5 https://github.com/feast-dev/feast/pull/6993
Commits 5 https://github.com/feast-dev/feast/pull/6993/commits
Checks 1 https://github.com/feast-dev/feast/pull/6993/checks
Files changed https://github.com/feast-dev/feast/pull/6993/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6993/files
fix: Apply on demand feature views in SparkRetrievalJob.to_spark_df() https://github.com/feast-dev/feast/pull/6993/files#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/6993/files
3b5655a fix: Apply on demand feature views in SparkRetrievalJob.to_spark_df() shanalyb Oct 10, 2026 https://github.com/feast-dev/feast/pull/6993/commits/3b5655a67aac56b4ed007203d7147a84efc3f4cb
b6e2cbf fix: Map PdfBytes, ImageBytes, Uuid, TimeUuid and ZonedTimestamp to S… shanalyb Oct 11, 2026 https://github.com/feast-dev/feast/pull/6993/commits/b6e2cbf7c2a186c8fb5aa42ed3444b76f3ebec26
c02d9ab refactor: Move Spark on demand feature view application into a class shanalyb Oct 13, 2026 https://github.com/feast-dev/feast/pull/6993/commits/c02d9ab4e1f885f0bc0a4e5e2c10b2ce9206917a
848ecd0 refactor: Share the on demand feature selection between to_arrow and … shanalyb Oct 15, 2026 https://github.com/feast-dev/feast/pull/6993/commits/848ecd03f43bae72223fe3d01dcb11f5ff75261a
1f1bb16 Merge branch 'master' into fix/spark-odfv-to-spark-df shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/6993/commits/1f1bb166e83294dfe84c65532f0d6a530a151200
Clear filters https://github.com/feast-dev/feast/pull/6993/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6993/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6993/files
job.py https://github.com/feast-dev/feast/pull/6993/files#diff-c0c00ee6dfdc0dc77fc68ff136a3229bef126abcaa11f56d87a17b34b458f815
nodes.py https://github.com/feast-dev/feast/pull/6993/files#diff-ef3c9f42859de83e0118dbc9b53b79509853421c612aa0cf630f2f894ecd3538
spark.py https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
offline_store.py https://github.com/feast-dev/feast/pull/6993/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
test_spark.py https://github.com/feast-dev/feast/pull/6993/files#diff-64a2d9d6d7262639e74ee108efbf3957b9ffae33f16deefe5a57e85b77b656e4
test_type_map.py https://github.com/feast-dev/feast/pull/6993/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/spark/job.pyhttps://github.com/feast-dev/feast/pull/6993/files#diff-c0c00ee6dfdc0dc77fc68ff136a3229bef126abcaa11f56d87a17b34b458f815
View file https://github.com/shanalyb/feast/blob/1f1bb166e83294dfe84c65532f0d6a530a151200/sdk/python/feast/infra/compute_engines/spark/job.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6993/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6993/files#diff-c0c00ee6dfdc0dc77fc68ff136a3229bef126abcaa11f56d87a17b34b458f815
https://github.com/feast-dev/feast/pull/6993/files#diff-c0c00ee6dfdc0dc77fc68ff136a3229bef126abcaa11f56d87a17b34b458f815
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/spark/nodes.pyhttps://github.com/feast-dev/feast/pull/6993/files#diff-ef3c9f42859de83e0118dbc9b53b79509853421c612aa0cf630f2f894ecd3538
View file https://github.com/shanalyb/feast/blob/1f1bb166e83294dfe84c65532f0d6a530a151200/sdk/python/feast/infra/compute_engines/spark/nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6993/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3c9f42859de83e0118dbc9b53b79509853421c612aa0cf630f2f894ecd3538
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3c9f42859de83e0118dbc9b53b79509853421c612aa0cf630f2f894ecd3538
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.pyhttps://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
View file https://github.com/shanalyb/feast/blob/1f1bb166e83294dfe84c65532f0d6a530a151200/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6993/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6993/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L23
sdk/python/feast/infra/offline_stores/offline_store.pyhttps://github.com/feast-dev/feast/pull/6993/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
View file https://github.com/shanalyb/feast/blob/1f1bb166e83294dfe84c65532f0d6a530a151200/sdk/python/feast/infra/offline_stores/offline_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6993/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6993/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/6993/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/6993/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
https://github.com/feast-dev/feast/pull/6993/files#diff-cbbed5979161d9e73b4d7c30000ec163d9d0e334ec79c27e4b90734877e6af38
Please reload this pagehttps://github.com/feast-dev/feast/pull/6993/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.