René's URL Explorer Experiment


Title: fix: Apply point-in-time filter correctly with the Polars backend by YHC66 · Pull Request #6992 · feast-dev/feast · GitHub

Open Graph Title: fix: Apply point-in-time filter correctly with the Polars backend by YHC66 · Pull Request #6992 · feast-dev/feast

X Title: fix: Apply point-in-time filter correctly with the Polars backend by YHC66 · Pull Request #6992 · feast-dev/feast

Description: What this PR does / why we need it: Follow-up to #6965 (the filter node I mentioned in its Misc section). LocalFilterNode applies the point-in-time and TTL filters with pandas-style boolean indexing: df = df[df[timestamp_column] <= df[ENTITY_TS_ALIAS]] With the Polars backend df is a pl.DataFrame, and polars treats a boolean Series passed to DataFrame.__getitem__ as a column selection, not a row mask. So with backend: polars: without a TTL, nothing is raised: every row is kept, including feature rows newer than the entity timestamp, and columns are dropped instead (which ones depends on the mask values); with a TTL, the next line usually fails with ColumnNotFoundError, because the timestamp column was dropped by the first step. I checked this on polars 0.20.31, 1.34.0 and 2.0.0; the behaviour is the same on all three. polars is not installed in CI, so this path has no coverage. The fix adds a small filter_by_mask(df, mask) method to DataFrameBackend (df[mask] for pandas, df.filter(mask) for polars) and uses it for both filters in LocalFilterNode. The pandas path is unchanged in behaviour. A new parametrized test runs the point-in-time filter with and without a TTL on both backends; the polars cases use pytest.importorskip("polars"), so they are skipped where polars isn't installed. Which issue(s) this PR fixes: No existing issue; found while testing #6965. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Local results (Python 3.12, CI requirements): Setup Result master + polars 2.0.0 / 1.34.0 / 0.20.31, new test the 2 polars cases fail (all 4 rows returned, entity_id column missing) this branch + polars 2.0.0 tests/unit/infra/compute_engines: 194 passed this branch + polars 1.34.0 / 0.20.31 local/test_nodes.py: 15 passed this branch, polars not installed 191 passed, 3 skipped ruff check, ruff format --check and mypy on the changed packages pass. Misc filter_by_mask is a new abstract method on DataFrameBackend. The two backends in the repo implement it; an out-of-tree backend would need to add it too. If you'd rather avoid that, I can give the base class a default implementation instead.

Open Graph Description: What this PR does / why we need it: Follow-up to #6965 (the filter node I mentioned in its Misc section). LocalFilterNode applies the point-in-time and TTL filters with pandas-style boolean indexin...

X Description: What this PR does / why we need it: Follow-up to #6965 (the filter node I mentioned in its Misc section). LocalFilterNode applies the point-in-time and TTL filters with pandas-style boolean indexin...

Opengraph URL: https://github.com/feast-dev/feast/pull/6992

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a3a13621-30b0-f4d7-2573-a2727d42be49
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9842:5B76F:F714BC:15029FD:6AFE982A
html-safe-noncee169afbb4ef4db5210bb5c1dcda5d1eabddd5351fce58493a3b88610bbed5eb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODQyOjVCNzZGOkY3MTRCQzoxNTAyOUZEOjZBRkU5ODJBIiwidmlzaXRvcl9pZCI6IjgxNzUwNDQxOTc1NjUyNDEzODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac24d6d746c349a485e6000f75d5cac9514e81d94e6b1fb568aa6342b107aac338
hovercard-subject-tagpull_request:4813044364
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6992/files
twitter:imagehttps://avatars.githubusercontent.com/u/122972532?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/122972532?s=400&v=4
og:image:altWhat this PR does / why we need it: Follow-up to #6965 (the filter node I mentioned in its Misc section). LocalFilterNode applies the point-in-time and TTL filters with pandas-style boolean indexin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6992/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6992%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6992%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6992/files
Reloadhttps://github.com/feast-dev/feast/pull/6992/files
Reloadhttps://github.com/feast-dev/feast/pull/6992/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
YHC66:fix-polars-backend-point-in-time-filterhttps://github.com/YHC66/feast/tree/fix-polars-backend-point-in-time-filter
Conversation 2 https://github.com/feast-dev/feast/pull/6992
Commits 2 https://github.com/feast-dev/feast/pull/6992/commits
Checks 32 https://github.com/feast-dev/feast/pull/6992/checks
Files changed https://github.com/feast-dev/feast/pull/6992/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6992/files
fix: Apply point-in-time filter correctly with the Polars backend https://github.com/feast-dev/feast/pull/6992/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6992/files
d4716aa fix: Apply point-in-time filter correctly with the Polars backend YHC66 Oct 10, 2026 https://github.com/feast-dev/feast/pull/6992/commits/d4716aa2a66c8a62e534fbddced0c82a0025bb7b
5913d4d Merge branch 'master' into fix-polars-backend-point-in-time-filter haoxu0 Oct 13, 2026 https://github.com/feast-dev/feast/pull/6992/commits/5913d4db90ce4f547648c58534e31b41adffccd2
Clear filters https://github.com/feast-dev/feast/pull/6992/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6992/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6992/files
base.py https://github.com/feast-dev/feast/pull/6992/files#diff-58cf88c96e8724860646120871e259fdc058fe17d7deed887c7f7c13d8316fc9
pandas_backend.py https://github.com/feast-dev/feast/pull/6992/files#diff-917fa63d7e6c7d9ac4d2396bd8d638f238866b7e2507cd3216de633af17b25bb
polars_backend.py https://github.com/feast-dev/feast/pull/6992/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
nodes.py https://github.com/feast-dev/feast/pull/6992/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
test_nodes.py https://github.com/feast-dev/feast/pull/6992/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/backends/base.pyhttps://github.com/feast-dev/feast/pull/6992/files#diff-58cf88c96e8724860646120871e259fdc058fe17d7deed887c7f7c13d8316fc9
View file https://github.com/YHC66/feast/blob/5913d4db90ce4f547648c58534e31b41adffccd2/sdk/python/feast/infra/compute_engines/backends/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6992/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6992/files#diff-58cf88c96e8724860646120871e259fdc058fe17d7deed887c7f7c13d8316fc9
https://github.com/feast-dev/feast/pull/6992/files#diff-58cf88c96e8724860646120871e259fdc058fe17d7deed887c7f7c13d8316fc9
https://github.com/feast-dev/feast/pull/6992/files#diff-58cf88c96e8724860646120871e259fdc058fe17d7deed887c7f7c13d8316fc9
https://github.com/feast-dev/feast/pull/6992/files#diff-58cf88c96e8724860646120871e259fdc058fe17d7deed887c7f7c13d8316fc9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/backends/pandas_backend.pyhttps://github.com/feast-dev/feast/pull/6992/files#diff-917fa63d7e6c7d9ac4d2396bd8d638f238866b7e2507cd3216de633af17b25bb
View file https://github.com/YHC66/feast/blob/5913d4db90ce4f547648c58534e31b41adffccd2/sdk/python/feast/infra/compute_engines/backends/pandas_backend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6992/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6992/files#diff-917fa63d7e6c7d9ac4d2396bd8d638f238866b7e2507cd3216de633af17b25bb
https://github.com/feast-dev/feast/pull/6992/files#diff-917fa63d7e6c7d9ac4d2396bd8d638f238866b7e2507cd3216de633af17b25bb
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/backends/polars_backend.pyhttps://github.com/feast-dev/feast/pull/6992/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
View file https://github.com/YHC66/feast/blob/5913d4db90ce4f547648c58534e31b41adffccd2/sdk/python/feast/infra/compute_engines/backends/polars_backend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6992/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6992/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
https://github.com/feast-dev/feast/pull/6992/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/local/nodes.pyhttps://github.com/feast-dev/feast/pull/6992/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
View file https://github.com/YHC66/feast/blob/5913d4db90ce4f547648c58534e31b41adffccd2/sdk/python/feast/infra/compute_engines/local/nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6992/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6992/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
https://github.com/feast-dev/feast/pull/6992/files#diff-2bd83cc19ff86d45bccb21f290302107ce03cff87ace4e600cda864645481f8d
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/compute_engines/local/test_nodes.pyhttps://github.com/feast-dev/feast/pull/6992/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
View file https://github.com/YHC66/feast/blob/5913d4db90ce4f547648c58534e31b41adffccd2/sdk/python/tests/unit/infra/compute_engines/local/test_nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6992/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6992/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/6992/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/6992/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/6992/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
Please reload this pagehttps://github.com/feast-dev/feast/pull/6992/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.