René's URL Explorer Experiment


Title: fix: Record which storage class wrote a custom_storage payload by haoxu0 · Pull Request #6988 · feast-dev/feast · GitHub

Open Graph Title: fix: Record which storage class wrote a custom_storage payload by haoxu0 · Pull Request #6988 · feast-dev/feast

X Title: fix: Record which storage class wrote a custom_storage payload by haoxu0 · Pull Request #6988 · feast-dev/feast

Description: What this PR does / why we need it: Three SavedDatasetStorage subclasses declare _proto_attr_name = "custom_storage": $ git grep -n '_proto_attr_name = "custom_storage"' sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse_source.py:161 sdk/python/feast/infra/offline_stores/contrib/couchbase_offline_store/couchbase_source.py:318 sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py:221 _StorageRegistry keys a flat dict on that name and the last definition wins (saved_dataset.py:26,31), so SavedDatasetStorage.from_proto resolved custom_storage to whichever module was imported last rather than to the class that wrote the payload. Writing a Postgres saved dataset and reading it back, with Couchbase also installed: wrote : SavedDatasetPostgreSQLStorage table_ref=public.my_saved_dataset oneof kind : custom_storage read back : raised KeyError: 'database' Reordering the three imports changes which class wins: postgres -> clickhouse -> couchbase -> SavedDatasetCouchbaseColumnarStorage couchbase -> postgres -> clickhouse -> SavedDatasetClickhouseStorage clickhouse -> couchbase -> postgres -> SavedDatasetPostgreSQLStorage Content cannot be used to disambiguate, because PostgreSQL and Clickhouse serialize identical configurations: postgres {name, query, table} clickhouse {name, query, table} couchbase {name, query, database, scope, collection} SavedDatasetStorage now records its concrete class path in the CustomSourceOptions.configuration JSON and resolves that on read through the existing get_saved_dataset_storage_class_from_path. The proto documents that field as owned by the implementer: Serialized configuration information for the data source. The implementer of the custom data source is responsible for serializing and deserializing data from bytes and every claimant already reads it by explicit key, so the extra key is ignored by older readers. This mirrors how DataSource.from_proto already handles CUSTOM_SOURCE, via data_source_class_type (data_source.py:343), without a proto change. Which issue(s) this PR fixes: Fixes #6946 Behavior this does not fix Payloads written before this key existed still cannot be disambiguated: the bytes of the competing classes are identical and the information was never stored, so no reader can recover it. Those now raise naming the competing classes rather than silently mis-dispatching. A field with a single claimant is unaffected and keeps reading untagged payloads, so existing single-extra installs do not change behavior. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change sdk/python/tests/unit/test_saved_dataset_storage_dispatch.py, 8 tests: the three real in-tree classes round-trip to themselves (parametrized, importorskip per extra) two synthetic claimants sharing the field both round-trip, including the one the flat registry does not point at the written proto records the concrete class and preserves the class's own payload an untagged payload with several claimants names them all an unresolvable recorded class path falls back instead of raising an import error a field with one claimant is unchanged The synthetic classes are defined in a real module inserted into sys.modules so the recorded path resolves, and a fixture restores the process-global registry afterwards. Verified against master: ruff check and ruff format --check clean, and mypy feast reports the same 24 pre-existing errors as origin/master with none added. Full tests/unit run differs from master by 9 failures that all reproduce on a clean origin/master when those modules are run in isolation (milvus, chronon HTTP retry, metrics httpd).

Open Graph Description: What this PR does / why we need it: Three SavedDatasetStorage subclasses declare _proto_attr_name = "custom_storage": $ git grep -n '_proto_attr_name = "custom_storage"'...

X Description: What this PR does / why we need it: Three SavedDatasetStorage subclasses declare _proto_attr_name = "custom_storage": $ git grep -n '_proto_attr_name = "custom_st...

Opengraph URL: https://github.com/feast-dev/feast/pull/6988

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f91769e-b78c-a42a-8b23-46541ba10124
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8774:79CF9:32AF1A:435A11:6AFE98AB
html-safe-nonceb09a1c3cdf44b213c2b5afb76fbdb4de988cf2eb3d22f6bb8375bdb7bf36d06b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzc0Ojc5Q0Y5OjMyQUYxQTo0MzVBMTE6NkFGRTk4QUIiLCJ2aXNpdG9yX2lkIjoiNzkwNzQ3MTMyMTMyMjEzMzY3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace5ee993c631bb2dcd22c586974833043b00394a09fdfa35a2f4319cb7d030ddb
hovercard-subject-tagpull_request:4804785269
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6988/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altWhat this PR does / why we need it: Three SavedDatasetStorage subclasses declare _proto_attr_name = "custom_storage": $ git grep -n '_proto_attr_name = "custom_storage"'...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6988/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6988%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6988%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6988/files
Reloadhttps://github.com/feast-dev/feast/pull/6988/files
Reloadhttps://github.com/feast-dev/feast/pull/6988/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
haoxu0https://github.com/haoxu0
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:fix/saved-dataset-storage-dispatchhttps://github.com/haoxu0/feast/tree/fix/saved-dataset-storage-dispatch
Conversation 1 https://github.com/feast-dev/feast/pull/6988
Commits 3 https://github.com/feast-dev/feast/pull/6988/commits
Checks 23 https://github.com/feast-dev/feast/pull/6988/checks
Files changed https://github.com/feast-dev/feast/pull/6988/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6988/files
fix: Record which storage class wrote a custom_storage payload https://github.com/feast-dev/feast/pull/6988/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/6988/files
be910b2 fix: Record which storage class wrote a custom_storage payload haoxu0 Oct 9, 2026 https://github.com/feast-dev/feast/pull/6988/commits/be910b2959057563a46758fca31fcc2029f0c967
2e194ae Merge branch 'master' into fix/saved-dataset-storage-dispatch haoxu0 Oct 11, 2026 https://github.com/feast-dev/feast/pull/6988/commits/2e194aebb4f23bfebdb8d72d9f914f4ad2cdf865
73e43a7 Merge branch 'master' into fix/saved-dataset-storage-dispatch haoxu0 Oct 13, 2026 https://github.com/feast-dev/feast/pull/6988/commits/73e43a7dd7aa1cf4240968ecfd5c0d2f646b6b42
Clear filters https://github.com/feast-dev/feast/pull/6988/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6988/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6988/files
clickhouse_source.py https://github.com/feast-dev/feast/pull/6988/files#diff-e9d6713596893871112160367fb7034ee8ac1eb1210a3a472e2058db89c7b568
couchbase_source.py https://github.com/feast-dev/feast/pull/6988/files#diff-074d9abd479161a0e3e71de94165b076236c3a33bfb1253371f381a9d873c19f
postgres_source.py https://github.com/feast-dev/feast/pull/6988/files#diff-200e5d0cee8130cc7bee915848db25b0c35bfca06598c6efaed1bde9a2b40f7a
saved_dataset.py https://github.com/feast-dev/feast/pull/6988/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
test_saved_dataset_storage_dispatch.py https://github.com/feast-dev/feast/pull/6988/files#diff-a542791edc38c7c67b2d3316037136ed277ba2a3a196a610e81fb5cfbf34c184
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse_source.pyhttps://github.com/feast-dev/feast/pull/6988/files#diff-e9d6713596893871112160367fb7034ee8ac1eb1210a3a472e2058db89c7b568
View file https://github.com/haoxu0/feast/blob/73e43a7dd7aa1cf4240968ecfd5c0d2f646b6b42/sdk/python/feast/infra/offline_stores/contrib/clickhouse_offline_store/clickhouse_source.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6988/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6988/files#diff-e9d6713596893871112160367fb7034ee8ac1eb1210a3a472e2058db89c7b568
https://github.com/feast-dev/feast/pull/6988/files#diff-e9d6713596893871112160367fb7034ee8ac1eb1210a3a472e2058db89c7b568
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/couchbase_offline_store/couchbase_source.pyhttps://github.com/feast-dev/feast/pull/6988/files#diff-074d9abd479161a0e3e71de94165b076236c3a33bfb1253371f381a9d873c19f
View file https://github.com/haoxu0/feast/blob/73e43a7dd7aa1cf4240968ecfd5c0d2f646b6b42/sdk/python/feast/infra/offline_stores/contrib/couchbase_offline_store/couchbase_source.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6988/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6988/files#diff-074d9abd479161a0e3e71de94165b076236c3a33bfb1253371f381a9d873c19f
https://github.com/feast-dev/feast/pull/6988/files#diff-074d9abd479161a0e3e71de94165b076236c3a33bfb1253371f381a9d873c19f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.pyhttps://github.com/feast-dev/feast/pull/6988/files#diff-200e5d0cee8130cc7bee915848db25b0c35bfca06598c6efaed1bde9a2b40f7a
View file https://github.com/haoxu0/feast/blob/73e43a7dd7aa1cf4240968ecfd5c0d2f646b6b42/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6988/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6988/files#diff-200e5d0cee8130cc7bee915848db25b0c35bfca06598c6efaed1bde9a2b40f7a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/saved_dataset.pyhttps://github.com/feast-dev/feast/pull/6988/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
View file https://github.com/haoxu0/feast/blob/73e43a7dd7aa1cf4240968ecfd5c0d2f646b6b42/sdk/python/feast/saved_dataset.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6988/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6988/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
https://github.com/feast-dev/feast/pull/6988/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
https://github.com/feast-dev/feast/pull/6988/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
https://github.com/feast-dev/feast/pull/6988/files#diff-172659538b2fa737157ade797397a542b39d6e921a7bb8651c4260a256a50f0a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_saved_dataset_storage_dispatch.pyhttps://github.com/feast-dev/feast/pull/6988/files#diff-a542791edc38c7c67b2d3316037136ed277ba2a3a196a610e81fb5cfbf34c184
View file https://github.com/haoxu0/feast/blob/73e43a7dd7aa1cf4240968ecfd5c0d2f646b6b42/sdk/python/tests/unit/test_saved_dataset_storage_dispatch.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6988/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6988/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.