René's URL Explorer Experiment


Title: fix: Restrict UI server CORS to trusted origins by ntkathole · Pull Request #6986 · feast-dev/feast · GitHub

Open Graph Title: fix: Restrict UI server CORS to trusted origins by ntkathole · Pull Request #6986 · feast-dev/feast

X Title: fix: Restrict UI server CORS to trusted origins by ntkathole · Pull Request #6986 · feast-dev/feast

Description: What this PR does / why we need it: The Feast UI server configured CORS with allow_origins=["*"] together with allow_credentials=True, so any website a user visited could issue authenticated cross-origin requests to the server and read the responses (CVE-2024-11602 / CWE-346, Origin Validation Error). The bundled Web UI is served from the same FastAPI app as the API, so it is same-origin and needs no permissive CORS policy. Disable CORS by default and let operators opt in to cross-origin access with an explicit allowlist of trusted origins. Following MLflow's convention, this is exposed as feast ui --cors-allowed-origins or the FEAST_UI_CORS_ALLOWED_ORIGINS environment variable (comma-separated). The wildcard origin is never combined with credentials again. Which issue(s) this PR fixes: Fixes #6810

Open Graph Description: What this PR does / why we need it: The Feast UI server configured CORS with allow_origins=["*"] together with allow_credentials=True, so any website a user visited could issue authentica...

X Description: What this PR does / why we need it: The Feast UI server configured CORS with allow_origins=["*"] together with allow_credentials=True, so any website a user visited could issue au...

Opengraph URL: https://github.com/feast-dev/feast/pull/6986

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:10046059-f35f-ad5f-663b-fcd6cca90103
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9294:308F56:EA7C8B:1365A88:6AFE9878
html-safe-noncea3c7c97b89b7dc3d5b61f54e2f9358382f40205634225b6f2efd33e517be134a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mjk0OjMwOEY1NjpFQTdDOEI6MTM2NUE4ODo2QUZFOTg3OCIsInZpc2l0b3JfaWQiOiI2MjkxODA1ODQzMDM2OTU5OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac29f197b63a894414c8a912a0ba1bc237557e53827d7ef1de0355c55cb081e8e9
hovercard-subject-tagpull_request:4798133041
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6986/files
twitter:imagehttps://avatars.githubusercontent.com/u/16951913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16951913?s=400&v=4
og:image:altWhat this PR does / why we need it: The Feast UI server configured CORS with allow_origins=["*"] together with allow_credentials=True, so any website a user visited could issue authentica...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6986/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6986%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6986%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6986/files
Reloadhttps://github.com/feast-dev/feast/pull/6986/files
Reloadhttps://github.com/feast-dev/feast/pull/6986/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
jyejarehttps://github.com/jyejare
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ntkathole:fix-cve-2024-11602-cors-uihttps://github.com/ntkathole/feast/tree/fix-cve-2024-11602-cors-ui
Conversation 10 https://github.com/feast-dev/feast/pull/6986
Commits 5 https://github.com/feast-dev/feast/pull/6986/commits
Checks 27 https://github.com/feast-dev/feast/pull/6986/checks
Files changed https://github.com/feast-dev/feast/pull/6986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
fix: Restrict UI server CORS to trusted origins https://github.com/feast-dev/feast/pull/6986/files#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/6986/files
c4ef83c fix: Restrict UI server CORS to trusted origins ntkathole Oct 9, 2026 https://github.com/feast-dev/feast/pull/6986/commits/c4ef83c360bc330b8b1f1fc15f8729e3cfb552fd
26adeb1 ci: Use pinned env for unit tests to fix protobuf gencode/runtime skew ntkathole Oct 9, 2026 https://github.com/feast-dev/feast/pull/6986/commits/26adeb1fcdfc9c78cf553b64f6115a3468ce0e27
786c384 ci: Disable uv auto-sync for all Makefile test targets ntkathole Oct 9, 2026 https://github.com/feast-dev/feast/pull/6986/commits/786c3842d0cde0049012549692b81174f0f3eb78
9df3e3f Merge branch 'master' into fix-cve-2024-11602-cors-ui jyejare Oct 9, 2026 https://github.com/feast-dev/feast/pull/6986/commits/9df3e3fe3da0e38099380f91334573ff8463a55e
df8455c fix: Warn on wildcard CORS origin and document origin format ntkathole Oct 9, 2026 https://github.com/feast-dev/feast/pull/6986/commits/df8455c1cd075fd17168f51d4f8a4d283ba70eee
Clear filters https://github.com/feast-dev/feast/pull/6986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
unit_tests.yml https://github.com/feast-dev/feast/pull/6986/files#diff-c91058a32040621ac54d6ea4194b302a420b7849f6e8561920d23a0e97acf69a
Makefile https://github.com/feast-dev/feast/pull/6986/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
alpha-web-ui.md https://github.com/feast-dev/feast/pull/6986/files#diff-b7fd600aa7ecbd86e47336ed54386e3ca5eee76385e692a89e290be96f181511
ui.py https://github.com/feast-dev/feast/pull/6986/files#diff-9d59a788a64672c6de34c4a671e3c35fb5e86b5daab0f308bd70219e30548e1e
feature_store.py https://github.com/feast-dev/feast/pull/6986/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
ui_server.py https://github.com/feast-dev/feast/pull/6986/files#diff-12fa0a74ad9a333ce95b2c23e6428455678ed129b3517ec355b8fa9541c3ef32
test_ui_command.py https://github.com/feast-dev/feast/pull/6986/files#diff-af152ea86297d747c2c6c3f09ef065494f6cac4203d41408f71c64063377905b
test_ui_server.py https://github.com/feast-dev/feast/pull/6986/files#diff-7f8ad5a7320306dbdb0f556dacdf4cda0a841081ff00b44670dd611c84eb512f
.github/workflows/unit_tests.ymlhttps://github.com/feast-dev/feast/pull/6986/files#diff-c91058a32040621ac54d6ea4194b302a420b7849f6e8561920d23a0e97acf69a
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/.github/workflows/unit_tests.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-c91058a32040621ac54d6ea4194b302a420b7849f6e8561920d23a0e97acf69a
https://github.com/feast-dev/feast/pull/6986/files#diff-c91058a32040621ac54d6ea4194b302a420b7849f6e8561920d23a0e97acf69a
Makefilehttps://github.com/feast-dev/feast/pull/6986/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/Makefile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
jyejarehttps://github.com/jyejare
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4230934175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
ntkatholehttps://github.com/ntkathole
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4231101010
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
https://github.com/feast-dev/feast/pull/6986/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/alpha-web-ui.mdhttps://github.com/feast-dev/feast/pull/6986/files#diff-b7fd600aa7ecbd86e47336ed54386e3ca5eee76385e692a89e290be96f181511
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/docs/reference/alpha-web-ui.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-b7fd600aa7ecbd86e47336ed54386e3ca5eee76385e692a89e290be96f181511
https://github.com/feast-dev/feast/pull/6986/files#diff-b7fd600aa7ecbd86e47336ed54386e3ca5eee76385e692a89e290be96f181511
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/cli/ui.pyhttps://github.com/feast-dev/feast/pull/6986/files#diff-9d59a788a64672c6de34c4a671e3c35fb5e86b5daab0f308bd70219e30548e1e
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/sdk/python/feast/cli/ui.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-9d59a788a64672c6de34c4a671e3c35fb5e86b5daab0f308bd70219e30548e1e
https://github.com/feast-dev/feast/pull/6986/files#diff-9d59a788a64672c6de34c4a671e3c35fb5e86b5daab0f308bd70219e30548e1e
https://github.com/feast-dev/feast/pull/6986/files#diff-9d59a788a64672c6de34c4a671e3c35fb5e86b5daab0f308bd70219e30548e1e
jyejarehttps://github.com/jyejare
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4230934202
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
ntkatholehttps://github.com/ntkathole
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4231101725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
df8455chttps://github.com/feast-dev/feast/commit/df8455c1cd075fd17168f51d4f8a4d283ba70eee
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/6986/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/6986/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/6986/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/ui_server.pyhttps://github.com/feast-dev/feast/pull/6986/files#diff-12fa0a74ad9a333ce95b2c23e6428455678ed129b3517ec355b8fa9541c3ef32
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/sdk/python/feast/ui_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-12fa0a74ad9a333ce95b2c23e6428455678ed129b3517ec355b8fa9541c3ef32
jyejarehttps://github.com/jyejare
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4230934160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
ntkatholehttps://github.com/ntkathole
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4231100584
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
df8455chttps://github.com/feast-dev/feast/commit/df8455c1cd075fd17168f51d4f8a4d283ba70eee
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
https://github.com/feast-dev/feast/pull/6986/files#diff-12fa0a74ad9a333ce95b2c23e6428455678ed129b3517ec355b8fa9541c3ef32
https://github.com/feast-dev/feast/pull/6986/files#diff-12fa0a74ad9a333ce95b2c23e6428455678ed129b3517ec355b8fa9541c3ef32
https://github.com/feast-dev/feast/pull/6986/files#diff-12fa0a74ad9a333ce95b2c23e6428455678ed129b3517ec355b8fa9541c3ef32
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/cli/test_ui_command.pyhttps://github.com/feast-dev/feast/pull/6986/files#diff-af152ea86297d747c2c6c3f09ef065494f6cac4203d41408f71c64063377905b
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/sdk/python/tests/unit/cli/test_ui_command.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_ui_server.pyhttps://github.com/feast-dev/feast/pull/6986/files#diff-7f8ad5a7320306dbdb0f556dacdf4cda0a841081ff00b44670dd611c84eb512f
View file https://github.com/ntkathole/feast/blob/df8455c1cd075fd17168f51d4f8a4d283ba70eee/sdk/python/tests/unit/test_ui_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6986/files#diff-7f8ad5a7320306dbdb0f556dacdf4cda0a841081ff00b44670dd611c84eb512f
jyejarehttps://github.com/jyejare
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4230934186
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
ntkatholehttps://github.com/ntkathole
Oct 9, 2026https://github.com/feast-dev/feast/pull/6986/files#r4231101371
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
df8455chttps://github.com/feast-dev/feast/commit/df8455c1cd075fd17168f51d4f8a4d283ba70eee
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
https://github.com/feast-dev/feast/pull/6986/files#diff-7f8ad5a7320306dbdb0f556dacdf4cda0a841081ff00b44670dd611c84eb512f
Please reload this pagehttps://github.com/feast-dev/feast/pull/6986/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.