René's URL Explorer Experiment


Title: fix: Warm up the whole DynamoDB connection pool by CyberRik · Pull Request #6985 · feast-dev/feast · GitHub

Open Graph Title: fix: Warm up the whole DynamoDB connection pool by CyberRik · Pull Request #6985 · feast-dev/feast

X Title: fix: Warm up the whole DynamoDB connection pool by CyberRik · Pull Request #6985 · feast-dev/feast

Description: What this PR does / why we need it: warmup_connections is documented to establish the connection pool at startup, but initialize() made a single describe_limits() call, so only one connection was opened. Concurrent feature requests after startup still paid the cold-start cost on every other connection. This issues max_pool_connections calls concurrently with asyncio.gather(..., return_exceptions=True). While one call is in flight its connection is busy, so each call needs its own connection. A sequential loop would reuse one connection, which is why the calls run together. A failed call is logged with the count of failures and does not stop the others, so startup behaves as before when warmup fails. The warmup now calls describe_endpoints() instead of describe_limits(). AWS documents that DescribeLimits is throttled when called more than once a minute, so a burst of calls (or several pods starting at once) would be throttled. With the default adaptive retry mode, that throttling would also slow down the client used for the first real reads. DescribeEndpoints is not tied to a table and has no such limit. Behind a VPC endpoint it needs dynamodb:DescribeEndpoints; if that is denied, the connection is still opened and a warning is logged. The config docstring, the DynamoDB reference page and the performance tuning guide now say how many calls are made and which call is used. As noted on the issue, if warming the full pool by default is too much, I can add a separate count option instead. Which issue(s) this PR fixes: Fixes #6964 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change test_dynamodb_online_store_warmup_connections now checks that max_pool_connections calls are made and that all of them are in flight at the same time, and that one failed call is logged while the others still run. On master it fails with assert 1 == 8. All 47 tests in test_dynamodb_online_store.py pass; ruff and mypy are clean on the changed files. I don't have an AWS account to test the burst against real DynamoDB, so a check on a real deployment would be welcome.

Open Graph Description: What this PR does / why we need it: warmup_connections is documented to establish the connection pool at startup, but initialize() made a single describe_limits() call, so only one connection was o...

X Description: What this PR does / why we need it: warmup_connections is documented to establish the connection pool at startup, but initialize() made a single describe_limits() call, so only one connection was o...

Opengraph URL: https://github.com/feast-dev/feast/pull/6985

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:90c390c2-f3d4-a32b-a6d5-c18b05375449
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF0C:2DC43A:C801ED:1092D68:6AFE9256
html-safe-nonce38f8820e681582405bc711e8605c5d4266857e30b091a7c34c1979a007d72f26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjBDOjJEQzQzQTpDODAxRUQ6MTA5MkQ2ODo2QUZFOTI1NiIsInZpc2l0b3JfaWQiOiIyOTMyMjUwNTAwNjM4MDg1NzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8ff59d1629d37749a224800a5a61da42ce0f27904009280fe15b5f7729d2d85d
hovercard-subject-tagpull_request:4797443435
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6985/files
twitter:imagehttps://avatars.githubusercontent.com/u/90637932?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/90637932?s=400&v=4
og:image:altWhat this PR does / why we need it: warmup_connections is documented to establish the connection pool at startup, but initialize() made a single describe_limits() call, so only one connection was o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6985/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6985%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6985%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6985/files
Reloadhttps://github.com/feast-dev/feast/pull/6985/files
Reloadhttps://github.com/feast-dev/feast/pull/6985/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
CyberRik:fix/dynamodb-warmup-poolhttps://github.com/CyberRik/feast/tree/fix/dynamodb-warmup-pool
Conversation 5 https://github.com/feast-dev/feast/pull/6985
Commits 6 https://github.com/feast-dev/feast/pull/6985/commits
Checks 1 https://github.com/feast-dev/feast/pull/6985/checks
Files changed https://github.com/feast-dev/feast/pull/6985/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6985/files
fix: Warm up the whole DynamoDB connection pool https://github.com/feast-dev/feast/pull/6985/files#top
Show all changes 6 commits https://github.com/feast-dev/feast/pull/6985/files
c5e05fa fix: Warm up the whole DynamoDB connection pool CyberRik Oct 9, 2026 https://github.com/feast-dev/feast/pull/6985/commits/c5e05fa0231ceebc81cd6be611c88bae830f90e4
3d9e34f fix: Use describe_endpoints for DynamoDB connection warmup CyberRik Oct 9, 2026 https://github.com/feast-dev/feast/pull/6985/commits/3d9e34f757f086561ca7b537e1f507c5860da11a
e462d4d Merge branch 'master' into fix/dynamodb-warmup-pool CyberRik Oct 11, 2026 https://github.com/feast-dev/feast/pull/6985/commits/e462d4d0bced55714d20ccb73adc8f529389d0f1
f2af244 Merge branch 'master' into fix/dynamodb-warmup-pool CyberRik Oct 17, 2026 https://github.com/feast-dev/feast/pull/6985/commits/f2af244e5f5e6d3ccf4e4bc749d66d416a2f9eb3
a3d57cb Merge remote-tracking branch 'origin/master' into fix/dynamodb-warmup… CyberRik Nov 9, 2026 https://github.com/feast-dev/feast/pull/6985/commits/a3d57cb69cd4a00c150dade42a7e4bde42105914
3dd7748 Merge branch 'master' into fix/dynamodb-warmup-pool shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/6985/commits/3dd7748ed30088fbe5fd6344822cc7cbe3388429
Clear filters https://github.com/feast-dev/feast/pull/6985/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6985/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6985/files
online-server-performance-tuning.md https://github.com/feast-dev/feast/pull/6985/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
dynamodb.md https://github.com/feast-dev/feast/pull/6985/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
dynamodb.py https://github.com/feast-dev/feast/pull/6985/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
test_dynamodb_online_store.py https://github.com/feast-dev/feast/pull/6985/files#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/online-server-performance-tuning.mdhttps://github.com/feast-dev/feast/pull/6985/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
View file https://github.com/CyberRik/feast/blob/3dd7748ed30088fbe5fd6344822cc7cbe3388429/docs/how-to-guides/online-server-performance-tuning.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6985/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6985/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/pull/6985/files#diff-82d8b79f95d6cae2c7dd44eecce63c06a146e04bd44b88dda34ee5ada8914b63
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/dynamodb.mdhttps://github.com/feast-dev/feast/pull/6985/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
View file https://github.com/CyberRik/feast/blob/3dd7748ed30088fbe5fd6344822cc7cbe3388429/docs/reference/online-stores/dynamodb.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6985/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6985/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
https://github.com/feast-dev/feast/pull/6985/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
https://github.com/feast-dev/feast/pull/6985/files#diff-f896d142bbc6e411c6ca31a0a8d8f55f281e3421d37dff40cf7b631d56a41c19
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/dynamodb.pyhttps://github.com/feast-dev/feast/pull/6985/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
View file https://github.com/CyberRik/feast/blob/3dd7748ed30088fbe5fd6344822cc7cbe3388429/sdk/python/feast/infra/online_stores/dynamodb.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6985/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6985/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/pull/6985/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/pull/6985/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/pull/6985/files#diff-331463f3d098d2af5805022abb43e80c4600f21f18126825bb2e3bebf1c6ea47
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_dynamodb_online_store.pyhttps://github.com/feast-dev/feast/pull/6985/files#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
View file https://github.com/CyberRik/feast/blob/3dd7748ed30088fbe5fd6344822cc7cbe3388429/sdk/python/tests/unit/infra/online_store/test_dynamodb_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6985/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6985/files#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com/feast-dev/feast/pull/6985/files#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com/feast-dev/feast/pull/6985/files#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com/feast-dev/feast/pull/6985/files#diff-47a1e36609372d7f10ad3cb7c2052999e3940d2f50d6f26b2df5473528cd93cd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.