René's URL Explorer Experiment


Title: test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast · GitHub

Open Graph Title: test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast

X Title: test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast

Description: #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [lock-python-dependencies-all] Error 1 That behaviour is still untested, and the gap is the reason the target could ship unable to run at all. Both existing tests pass a bare torch==2.13.0 as the requirements being patched, and put +cpu only in cpu_requirements — the lookup table. So neither exercises a +cpu entry on the side that gets rewritten, which is exactly the input a real resolve produces: torch==2.13.0 ; sys_platform == 'darwin' torch==2.13.0+cpu ; sys_platform != 'darwin' What is added Two tests, no production code: one for a single marker split one for the torch + torchvision pair the committed py3.*-ci-requirements.txt actually contain Both assert idempotency. The second also asserts the +cpu line is left exactly as the resolver wrote it rather than merged into, so a later change cannot widen the set of artifacts that pin accepts without failing here — that property is the reason skipping is preferable to normalising the lookup key, and nothing currently holds it in place. Verification sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.py: 4 passed. They pass against #6906's fix as merged, with the script untouched — so they describe the behaviour rather than one implementation of it. ruff check and ruff format --check clean. I had opened #6959 proposing the same fix before #6906 merged; the approach there was identical (return match[0] for a +cpu pin), and #6906 additionally normalises pins in main(), which mine did not. I have closed #6959 in favour of this, which keeps only the part that is still missing.

Open Graph Description: #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [...

X Description: #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [...

Opengraph URL: https://github.com/feast-dev/feast/pull/6980

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d7f1eab-af9c-b036-e361-daf08a7b6e88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCBE:38231F:248998:30DDE4:6AFE99B3
html-safe-nonceefca69f69ee64b0464bfe496c31d3000e43294c875c04980eeda9325da8a996e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0JFOjM4MjMxRjoyNDg5OTg6MzBEREU0OjZBRkU5OUIzIiwidmlzaXRvcl9pZCI6IjU0NTg2MTc5MjE3NDA4NjU3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5a8ad6eb6fc24daf2a02dc387790e75b144d37f7f3034e6ea314c25e7df05b08
hovercard-subject-tagpull_request:4793861254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6980/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:alt#6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6980/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6980%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6980%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6980/files
Reloadhttps://github.com/feast-dev/feast/pull/6980/files
Reloadhttps://github.com/feast-dev/feast/pull/6980/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:test/cpu-torch-hashes-cpu-pinhttps://github.com/haoxu0/feast/tree/test/cpu-torch-hashes-cpu-pin
Conversation 1 https://github.com/feast-dev/feast/pull/6980
Commits 1 https://github.com/feast-dev/feast/pull/6980/commits
Checks 23 https://github.com/feast-dev/feast/pull/6980/checks
Files changed https://github.com/feast-dev/feast/pull/6980/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6980/files
test: Cover the universal torch split in add_cpu_torch_hashes https://github.com/feast-dev/feast/pull/6980/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6980/files
bb1dc75 test: Cover the universal torch split in add_cpu_torch_hashes haoxu0 Oct 8, 2026 https://github.com/feast-dev/feast/pull/6980/commits/bb1dc7517d65fa0b4de877c4041a30cb615807ba
Clear filters https://github.com/feast-dev/feast/pull/6980/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6980/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6980/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.pyhttps://github.com/feast-dev/feast/pull/6980/files#diff-8c8d8cb7600066133e4cdef661c6ef986b101e0d0bc570eed7eeca52a4a11942
View file https://github.com/haoxu0/feast/blob/bb1dc7517d65fa0b4de877c4041a30cb615807ba/sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6980/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6980/files#diff-8c8d8cb7600066133e4cdef661c6ef986b101e0d0bc570eed7eeca52a4a11942
Please reload this pagehttps://github.com/feast-dev/feast/pull/6980/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.