Title: test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast · GitHub
Open Graph Title: test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast
X Title: test: Cover the universal torch split in add_cpu_torch_hashes by haoxu0 · Pull Request #6980 · feast-dev/feast
Description: #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [lock-python-dependencies-all] Error 1 That behaviour is still untested, and the gap is the reason the target could ship unable to run at all. Both existing tests pass a bare torch==2.13.0 as the requirements being patched, and put +cpu only in cpu_requirements — the lookup table. So neither exercises a +cpu entry on the side that gets rewritten, which is exactly the input a real resolve produces: torch==2.13.0 ; sys_platform == 'darwin' torch==2.13.0+cpu ; sys_platform != 'darwin' What is added Two tests, no production code: one for a single marker split one for the torch + torchvision pair the committed py3.*-ci-requirements.txt actually contain Both assert idempotency. The second also asserts the +cpu line is left exactly as the resolver wrote it rather than merged into, so a later change cannot widen the set of artifacts that pin accepts without failing here — that property is the reason skipping is preferable to normalising the lookup key, and nothing currently holds it in place. Verification sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.py: 4 passed. They pass against #6906's fix as merged, with the script untouched — so they describe the behaviour rather than one implementation of it. ruff check and ruff format --check clean. I had opened #6959 proposing the same fix before #6906 merged; the approach there was identical (return match[0] for a +cpu pin), and #6906 additionally normalises pins in main(), which mine did not. I have closed #6959 in favour of this, which keeps only the part that is still missing.
Open Graph Description: #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [...
X Description: #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [...
Opengraph URL: https://github.com/feast-dev/feast/pull/6980
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6d7f1eab-af9c-b036-e361-daf08a7b6e88 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCBE:38231F:248998:30DDE4:6AFE99B3 |
| html-safe-nonce | efca69f69ee64b0464bfe496c31d3000e43294c875c04980eeda9325da8a996e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0JFOjM4MjMxRjoyNDg5OTg6MzBEREU0OjZBRkU5OUIzIiwidmlzaXRvcl9pZCI6IjU0NTg2MTc5MjE3NDA4NjU3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5a8ad6eb6fc24daf2a02dc387790e75b144d37f7f3034e6ea314c25e7df05b08 |
| hovercard-subject-tag | pull_request:4793861254 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6980/files |
| twitter:image | https://avatars.githubusercontent.com/u/20422210?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/20422210?s=400&v=4 |
| og:image:alt | #6906 taught add_cpu_hashes to leave an existing +cpu pin alone, which is what make lock-python-dependencies-all needed to get past: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width