René's URL Explorer Experiment


Title: fix: Convert PdfBytes values to protos like ImageBytes by raashish1601 · Pull Request #6968 · feast-dev/feast · GitHub

Open Graph Title: fix: Convert PdfBytes values to protos like ImageBytes by raashish1601 · Pull Request #6968 · feast-dev/feast

X Title: fix: Convert PdfBytes values to protos like ImageBytes by raashish1601 · Pull Request #6968 · feast-dev/feast

Description: What this PR does / why we need it: ValueType.PDF_BYTES is missing from PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE in type_map.py, while IMAGE_BYTES is there. So python_values_to_proto_values raises for any PdfBytes field, and a feature view with one can't be materialized or written to the online store: fv = FeatureView( name="docs", entities=[doc], schema=[Field(name="doc_id", dtype=String), Field(name="pdf", dtype=PdfBytes)], source=FileSource(path=path, timestamp_field="event_timestamp"), ) store.apply([doc, fv]) store.write_to_online_store("docs", df) # same for store.materialize_incremental(...) # Exception: Unsupported data type: ValueType.PDF_BYTES The same feature view with ImageBytes instead works. This adds PDF_BYTES to the map with the same bytes_val conversion as BYTES and IMAGE_BYTES. Reading back already worked, since feast_value_type_to_python_type only looks at the proto field. Which issue(s) this PR fixes: No issue, found while checking value conversions for each ValueType. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Added test_python_values_to_proto_values_binary in sdk/python/tests/unit/test_type_map.py for BYTES, PDF_BYTES and IMAGE_BYTES; the PDF_BYTES case fails on master. I also ran the example above against a local SQLite online store: write and materialize both work and get_online_features returns the bytes. pytest tests/unit/test_type_map.py passes apart from the TestSparkNativeTypeValidation cases, which fail the same way on master here because pyspark isn't installed. ruff check and ruff format --check are clean on the changed files.

Open Graph Description: What this PR does / why we need it: ValueType.PDF_BYTES is missing from PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE in type_map.py, while IMAGE_BYTES is there. So python_values_to_proto_values raises f...

X Description: What this PR does / why we need it: ValueType.PDF_BYTES is missing from PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE in type_map.py, while IMAGE_BYTES is there. So python_values_to_proto_values raises f...

Opengraph URL: https://github.com/feast-dev/feast/pull/6968

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b7cb908-01c0-0a93-08db-e3a41115daf3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC602:15B330:FADC31:14A0067:6AFE9C70
html-safe-nonce9e42dd87c22abd289a77b50ab81331828454011f6a41b5711e3c344717a1f7ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjAyOjE1QjMzMDpGQURDMzE6MTRBMDA2Nzo2QUZFOUM3MCIsInZpc2l0b3JfaWQiOiI3OTUwMDI3MzM5MDU0NjE5NzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace45523d12b923c39083fc47b8f73273ac5baff55eacc8c965a0d518a731884f1
hovercard-subject-tagpull_request:4779856673
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6968/files
twitter:imagehttps://avatars.githubusercontent.com/u/94279692?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/94279692?s=400&v=4
og:image:altWhat this PR does / why we need it: ValueType.PDF_BYTES is missing from PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE in type_map.py, while IMAGE_BYTES is there. So python_values_to_proto_values raises f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6968/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6968%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6968%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6968/files
Reloadhttps://github.com/feast-dev/feast/pull/6968/files
Reloadhttps://github.com/feast-dev/feast/pull/6968/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
haoxu0https://github.com/haoxu0
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
raashish1601:fix/pdf-bytes-proto-conversionhttps://github.com/raashish1601/feast/tree/fix/pdf-bytes-proto-conversion
Conversation 2 https://github.com/feast-dev/feast/pull/6968
Commits 3 https://github.com/feast-dev/feast/pull/6968/commits
Checks 23 https://github.com/feast-dev/feast/pull/6968/checks
Files changed https://github.com/feast-dev/feast/pull/6968/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6968/files
fix: Convert PdfBytes values to protos like ImageBytes https://github.com/feast-dev/feast/pull/6968/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/6968/files
c469145 fix: Convert PdfBytes values to protos like ImageBytes raashish1601 Oct 7, 2026 https://github.com/feast-dev/feast/pull/6968/commits/c46914580ab973f6630c69c589ce92903ed7880b
120157d Merge branch 'master' into fix/pdf-bytes-proto-conversion haoxu0 Oct 8, 2026 https://github.com/feast-dev/feast/pull/6968/commits/120157d36932eaef068d9688da5d90efdcb2ca16
fb0d3c3 Merge branch 'master' into fix/pdf-bytes-proto-conversion haoxu0 Oct 9, 2026 https://github.com/feast-dev/feast/pull/6968/commits/fb0d3c3a3fd4af83f34290271891d2cf083c7330
Clear filters https://github.com/feast-dev/feast/pull/6968/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6968/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6968/files
type_map.py https://github.com/feast-dev/feast/pull/6968/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
test_type_map.py https://github.com/feast-dev/feast/pull/6968/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/type_map.pyhttps://github.com/feast-dev/feast/pull/6968/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
View file https://github.com/raashish1601/feast/blob/fb0d3c3a3fd4af83f34290271891d2cf083c7330/sdk/python/feast/type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6968/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6968/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/pull/6968/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_type_map.pyhttps://github.com/feast-dev/feast/pull/6968/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
View file https://github.com/raashish1601/feast/blob/fb0d3c3a3fd4af83f34290271891d2cf083c7330/sdk/python/tests/unit/test_type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6968/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6968/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/pull/6968/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
Please reload this pagehttps://github.com/feast-dev/feast/pull/6968/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.