René's URL Explorer Experiment


Title: fix: Use group_by in Polars backend aggregation by YHC66 · Pull Request #6965 · feast-dev/feast · GitHub

Open Graph Title: fix: Use group_by in Polars backend aggregation by YHC66 · Pull Request #6965 · feast-dev/feast

X Title: fix: Use group_by in Polars backend aggregation by YHC66 · Pull Request #6965 · feast-dev/feast

Description: What this PR does / why we need it: PolarsBackend.groupby_agg calls df.groupby(...). polars renamed that method to group_by in 0.19 and removed the old name in 1.0, so with any current polars release (1.x and the new 2.0.0) the call raises: AttributeError: 'DataFrame' object has no attribute 'groupby'. Did you mean: 'group_by'? This means the local compute engine configured with backend: polars fails as soon as it runs a LocalAggregationNode. polars is not installed in CI, so the backend has no test coverage today (the factory tests mock it out). The fix switches to group_by. A new test runs LocalAggregationNode with PolarsBackend (sum and nunique, so the n_unique mapping is covered too); it uses pytest.importorskip("polars"), so it is skipped where polars isn't installed. Which issue(s) this PR fixes: No existing issue; found while running the compute engine tests with polars installed. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Local results (Python 3.12, CI requirements): Setup Result master + polars 2.0.0, new test fails with the AttributeError above this branch + polars 2.0.0 tests/unit/infra/compute_engines: 117 passed this branch + polars 1.34.0 local/test_nodes.py: 11 passed this branch, polars not installed 116 passed, 1 skipped ruff check, ruff format --check and mypy on the changed files pass. Misc While testing I also noticed that LocalFilterNode uses pandas-style boolean indexing (df[df[ts] <= df[entity_ts]]), which polars rejects, so historical retrieval with the polars backend still fails at that node. I kept this PR to the aggregation fix; happy to follow up on the filter node if that's useful.

Open Graph Description: What this PR does / why we need it: PolarsBackend.groupby_agg calls df.groupby(...). polars renamed that method to group_by in 0.19 and removed the old name in 1.0, so with any current polars relea...

X Description: What this PR does / why we need it: PolarsBackend.groupby_agg calls df.groupby(...). polars renamed that method to group_by in 0.19 and removed the old name in 1.0, so with any current polars relea...

Opengraph URL: https://github.com/feast-dev/feast/pull/6965

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e4464b3f-e73e-3ac8-0e81-75b30c90d790
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBDC:2BC66C:F025DD:1492127:6AFE987F
html-safe-nonce78d442eb6d8c0dd1e99794452ca27f337dbe9ba054e208ca9c41a192855c339f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkRDOjJCQzY2QzpGMDI1REQ6MTQ5MjEyNzo2QUZFOTg3RiIsInZpc2l0b3JfaWQiOiIxMzEzMTM4NzI4NzMzOTM5ODM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3d840d91a20b744dbb3c763fbfe3fa3b375c2da1af7b050c4aa3815833a453eb
hovercard-subject-tagpull_request:4776035385
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6965/files
twitter:imagehttps://avatars.githubusercontent.com/u/122972532?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/122972532?s=400&v=4
og:image:altWhat this PR does / why we need it: PolarsBackend.groupby_agg calls df.groupby(...). polars renamed that method to group_by in 0.19 and removed the old name in 1.0, so with any current polars relea...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6965/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6965%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6965%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6965/files
Reloadhttps://github.com/feast-dev/feast/pull/6965/files
Reloadhttps://github.com/feast-dev/feast/pull/6965/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
haoxu0https://github.com/haoxu0
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
YHC66:fix-polars-backend-group-byhttps://github.com/YHC66/feast/tree/fix-polars-backend-group-by
Conversation 3 https://github.com/feast-dev/feast/pull/6965
Commits 4 https://github.com/feast-dev/feast/pull/6965/commits
Checks 23 https://github.com/feast-dev/feast/pull/6965/checks
Files changed https://github.com/feast-dev/feast/pull/6965/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6965/files
fix: Use group_by in Polars backend aggregation https://github.com/feast-dev/feast/pull/6965/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/6965/files
dea6862 fix: Use group_by in Polars backend aggregation YHC66 Oct 7, 2026 https://github.com/feast-dev/feast/pull/6965/commits/dea6862f220e7183f0dbb4b70d92aab556d0c99c
f9708a4 Merge branch 'master' into fix-polars-backend-group-by haoxu0 Oct 9, 2026 https://github.com/feast-dev/feast/pull/6965/commits/f9708a4c79f6eb54b9515070c3c4725d0c34a8f0
adc58ab Merge branch 'master' into fix-polars-backend-group-by haoxu0 Oct 9, 2026 https://github.com/feast-dev/feast/pull/6965/commits/adc58ab91f12cc95b5d7a6553194db7eff60b39c
b832615 Merge branch 'master' into fix-polars-backend-group-by haoxu0 Oct 9, 2026 https://github.com/feast-dev/feast/pull/6965/commits/b83261533b57275349a427e115786c71d6fdc603
Clear filters https://github.com/feast-dev/feast/pull/6965/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6965/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6965/files
polars_backend.py https://github.com/feast-dev/feast/pull/6965/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
test_nodes.py https://github.com/feast-dev/feast/pull/6965/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/backends/polars_backend.pyhttps://github.com/feast-dev/feast/pull/6965/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
View file https://github.com/YHC66/feast/blob/b83261533b57275349a427e115786c71d6fdc603/sdk/python/feast/infra/compute_engines/backends/polars_backend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6965/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6965/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
https://github.com/feast-dev/feast/pull/6965/files#diff-64c4d3e55bb56aa355f308f6633cb324f2b932b98fabaf768d352513d3a7092a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/compute_engines/local/test_nodes.pyhttps://github.com/feast-dev/feast/pull/6965/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
View file https://github.com/YHC66/feast/blob/b83261533b57275349a427e115786c71d6fdc603/sdk/python/tests/unit/infra/compute_engines/local/test_nodes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6965/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6965/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/6965/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/6965/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
https://github.com/feast-dev/feast/pull/6965/files#diff-c4d5ec42f07bbfbdb88dcb8c681da2c25e94694dcb9200116eb604777d57fb8f
Please reload this pagehttps://github.com/feast-dev/feast/pull/6965/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.