René's URL Explorer Experiment


Title: fix: Stop add_cpu_torch_hashes failing on a universal torch split by haoxu0 · Pull Request #6959 · feast-dev/feast · GitHub

Open Graph Title: fix: Stop add_cpu_torch_hashes failing on a universal torch split by haoxu0 · Pull Request #6959 · feast-dev/feast

X Title: fix: Stop add_cpu_torch_hashes failing on a universal torch split by haoxu0 · Pull Request #6959 · feast-dev/feast

Description: What is broken make lock-python-dependencies-all cannot complete on master. It aborts after compiling the first file: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [lock-python-dependencies-all] Error 1 Because the target begins with rm -rf sdk/python/requirements/*, a run leaves the tree with 14 of the 15 requirements files deleted and nothing regenerated. Why uv pip compile --universal --torch-backend cpu splits torch by marker, so the lock holds two pins per package. This is the shape in all three committed py3.*-ci-requirements.txt today: torch==2.14.0 ; sys_platform == 'darwin' torch==2.14.0+cpu ; sys_platform != 'darwin' torchvision==0.29.0 ; sys_platform == 'darwin' torchvision==0.29.0+cpu ; sys_platform != 'darwin' add_hashes looked every entry up by appending +cpu to its version: hashes = cpu_hashes.get((name, f"{version}+cpu")) For the second pin of each pair that asks for 2.14.0+cpu+cpu, which no resolve can produce, so the lookup missed and the script raised. Why the tests did not catch it test_cpu_hashes_preserve_pypi_hashes_and_pins feeds in a bare torch==2.13.0 and nothing else, so the +cpu pin that a real --universal resolve emits is never exercised. The script and its tests landed together in #6188, and the requirements files were last regenerated before that, so the target appears not to have been run since. The change The +cpu pin is already the CPU wheel, so it needs no hashes added and is now returned untouched. Returning it, rather than normalising the lookup key to version.removesuffix("+cpu") + "+cpu", is deliberate: both stop the crash, but normalising would union the CPU resolve's hashes into that entry and could widen the set of artifacts the pin accepts. Returning it leaves the hash set exactly as the resolver wrote it, so no lock can start accepting an artifact it did not accept before. A genuine version mismatch still raises, which the existing third test covers unchanged. Verification Two tests added, for a single marker split and for the torch + torchvision pair the lock actually contains, both asserting idempotency. sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.py: 4 passed. Checked against real data — add_cpu_hashes run over each committed file with the CPU pins a --torch-backend cpu --no-deps resolve would return: file before after py3.10-ci-requirements.txt raised OK, idempotent py3.11-ci-requirements.txt raised OK, idempotent py3.12-ci-requirements.txt raised OK, idempotent ruff check and ruff format --check clean. I found this trying to satisfy a review on #6958, which asks for regenerated locks and cannot be done until this is fixed.

Open Graph Description: What is broken make lock-python-dependencies-all cannot complete on master. It aborts after compiling the first file: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [lock-python-dep...

X Description: What is broken make lock-python-dependencies-all cannot complete on master. It aborts after compiling the first file: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [lock-python-dep...

Opengraph URL: https://github.com/feast-dev/feast/pull/6959

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b6be783e-0f0a-981e-fc49-42f6fa45f9bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D84:3C28FE:226CB9:2DF6B4:6AFE9895
html-safe-nonceb65f1cbce0c0b661c992bb4d3145997daf0afc196470519060ee4eca73e8fdf3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDg0OjNDMjhGRToyMjZDQjk6MkRGNkI0OjZBRkU5ODk1IiwidmlzaXRvcl9pZCI6Ijc1MDYzOTkxODc3OTgyMzUyODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5274d7f9bfb709d713224c312c2db7646ce08af67e46a7aae67da4896c15cbc3
hovercard-subject-tagpull_request:4769179421
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6959/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altWhat is broken make lock-python-dependencies-all cannot complete on master. It aborts after compiling the first file: ValueError: Missing CPU hashes for torch==2.14.1+cpu make: *** [lock-python-dep...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6959/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6959%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6959%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6959/files
Reloadhttps://github.com/feast-dev/feast/pull/6959/files
Reloadhttps://github.com/feast-dev/feast/pull/6959/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
haoxu0https://github.com/haoxu0
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:fix/cpu-torch-hashes-local-versionhttps://github.com/haoxu0/feast/tree/fix/cpu-torch-hashes-local-version
Conversation 2 https://github.com/feast-dev/feast/pull/6959
Commits 3 https://github.com/feast-dev/feast/pull/6959/commits
Checks 24 https://github.com/feast-dev/feast/pull/6959/checks
Files changed https://github.com/feast-dev/feast/pull/6959/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6959/files
fix: Stop add_cpu_torch_hashes failing on a universal torch split https://github.com/feast-dev/feast/pull/6959/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/6959/files
0140f54 fix: Stop add_cpu_torch_hashes failing on a universal torch split haoxu0 Oct 7, 2026 https://github.com/feast-dev/feast/pull/6959/commits/0140f54cb4a33b61ad698036364431c9857b5fd0
a1a289f Merge branch 'master' into fix/cpu-torch-hashes-local-version haoxu0 Oct 8, 2026 https://github.com/feast-dev/feast/pull/6959/commits/a1a289f7e342d2d255e08278d5bf082035bd757c
2cded3e Merge branch 'master' into fix/cpu-torch-hashes-local-version haoxu0 Oct 8, 2026 https://github.com/feast-dev/feast/pull/6959/commits/2cded3eec76c0665307ad589e0d616f3535dc6bf
Clear filters https://github.com/feast-dev/feast/pull/6959/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6959/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6959/files
add_cpu_torch_hashes.py https://github.com/feast-dev/feast/pull/6959/files#diff-40338b4817e5c2de968eb63a5780a7ba3331212e67829566b97596fcc626a37d
test_cpu_torch_hashes.py https://github.com/feast-dev/feast/pull/6959/files#diff-8c8d8cb7600066133e4cdef661c6ef986b101e0d0bc570eed7eeca52a4a11942
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/scripts/add_cpu_torch_hashes.pyhttps://github.com/feast-dev/feast/pull/6959/files#diff-40338b4817e5c2de968eb63a5780a7ba3331212e67829566b97596fcc626a37d
View file https://github.com/haoxu0/feast/blob/2cded3eec76c0665307ad589e0d616f3535dc6bf/infra/scripts/add_cpu_torch_hashes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6959/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6959/files#diff-40338b4817e5c2de968eb63a5780a7ba3331212e67829566b97596fcc626a37d
https://github.com/feast-dev/feast/pull/6959/files#diff-40338b4817e5c2de968eb63a5780a7ba3331212e67829566b97596fcc626a37d
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.pyhttps://github.com/feast-dev/feast/pull/6959/files#diff-8c8d8cb7600066133e4cdef661c6ef986b101e0d0bc570eed7eeca52a4a11942
View file https://github.com/haoxu0/feast/blob/2cded3eec76c0665307ad589e0d616f3535dc6bf/sdk/python/tests/unit/infra/scripts/test_cpu_torch_hashes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6959/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6959/files#diff-8c8d8cb7600066133e4cdef661c6ef986b101e0d0bc570eed7eeca52a4a11942
Please reload this pagehttps://github.com/feast-dev/feast/pull/6959/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.