René's URL Explorer Experiment


Title: fix: Break event timestamp ties by created timestamp in the Dask offline store by LuisFigueroaG · Pull Request #6952 · feast-dev/feast · GitHub

Open Graph Title: fix: Break event timestamp ties by created timestamp in the Dask offline store by LuisFigueroaG · Pull Request #6952 · feast-dev/feast

X Title: fix: Break event timestamp ties by created timestamp in the Dask offline store by LuisFigueroaG · Pull Request #6952 · feast-dev/feast

Description: What this PR does / why we need it: When two rows share an event timestamp, Feast is supposed to keep the one with the latest created_timestamp_column. The Dask offline store did this with two consecutive sorts, first by the created timestamp and then by the event timestamp, and relied on the second sort preserving the order of the first: df_to_join = df_to_join.sort_values(by=created_timestamp_column, na_position="first") df_to_join = df_to_join.sort_values(by=timestamp_field, na_position="first") Dask's sort_values (and pandas' default quicksort) is not stable, so for tied event timestamps the older row can end up last and win drop_duplicates(keep="last"). With 300 entities, each having two rows with the same event timestamp, 291 came back with the older row. A single partition with 20 entities already returned 12 wrong rows. This affects get_historical_features (_drop_duplicates) and pull_latest_from_table_or_query (evaluate_offline_job). This sorts once by [timestamp_field, created_timestamp_column] in both places, including the ZeroDivisionError fallbacks. Multi-column sort_values is supported by dask since well before the dask>=2024.2.1 minimum. Which issue(s) this PR fixes: No existing issue. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Added test_dask_created_timestamp_tiebreak.py, covering get_historical_features and pull_latest_from_table_or_query with 100 entities across 4 partitions. Both tests failed in 5 out of 5 runs on master and pass with this change. ruff format --check, ruff check and mypy pass on the changed files, and sdk/python/tests/unit/infra/offline_stores/ passes (291 passed).

Open Graph Description: What this PR does / why we need it: When two rows share an event timestamp, Feast is supposed to keep the one with the latest created_timestamp_column. The Dask offline store did this with two cons...

X Description: What this PR does / why we need it: When two rows share an event timestamp, Feast is supposed to keep the one with the latest created_timestamp_column. The Dask offline store did this with two cons...

Opengraph URL: https://github.com/feast-dev/feast/pull/6952

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d9bef1ca-139e-e6da-37c4-5b52aec398b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97B6:37D9F:E2E7FC:1361BF9:6AFE9261
html-safe-nonce9164f22ac7e639f2d0272f3c4d418f31073651636c44d64e3caece04ef595f94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0I2OjM3RDlGOkUyRTdGQzoxMzYxQkY5OjZBRkU5MjYxIiwidmlzaXRvcl9pZCI6IjM5ODYxNDUxOTkxNTg4OTExMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf37c497e5fa101bbec6fa9056e5fb40e2c0ac5d5ff145fd45804181424d2b117
hovercard-subject-tagpull_request:4752905566
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6952/files
twitter:imagehttps://avatars.githubusercontent.com/u/62305361?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/62305361?s=400&v=4
og:image:altWhat this PR does / why we need it: When two rows share an event timestamp, Feast is supposed to keep the one with the latest created_timestamp_column. The Dask offline store did this with two cons...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6952/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6952%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6952%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6952/files
Reloadhttps://github.com/feast-dev/feast/pull/6952/files
Reloadhttps://github.com/feast-dev/feast/pull/6952/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
LuisFigueroaG:fix/dask-created-timestamp-tiebreakhttps://github.com/LuisFigueroaG/feast/tree/fix/dask-created-timestamp-tiebreak
Conversation 2 https://github.com/feast-dev/feast/pull/6952
Commits 2 https://github.com/feast-dev/feast/pull/6952/commits
Checks 22 https://github.com/feast-dev/feast/pull/6952/checks
Files changed https://github.com/feast-dev/feast/pull/6952/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6952/files
fix: Break event timestamp ties by created timestamp in the Dask offline store https://github.com/feast-dev/feast/pull/6952/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6952/files
a6f2696 fix: Break event timestamp ties by created timestamp in the Dask offl… LuisFigueroaG Oct 6, 2026 https://github.com/feast-dev/feast/pull/6952/commits/a6f2696377b2fedd7a3358547f1792f81b8c3881
7757558 Merge branch 'master' into fix/dask-created-timestamp-tiebreak shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/6952/commits/7757558b38a20ac6affd81e24e4d8b874dafaf53
Clear filters https://github.com/feast-dev/feast/pull/6952/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6952/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6952/files
dask.py https://github.com/feast-dev/feast/pull/6952/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
test_dask_created_timestamp_tiebreak.py https://github.com/feast-dev/feast/pull/6952/files#diff-f0dc68b4771494036b29af2e8578c65d571b24c0a4dca59318254eeb5a776cad
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/dask.pyhttps://github.com/feast-dev/feast/pull/6952/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
View file https://github.com/LuisFigueroaG/feast/blob/7757558b38a20ac6affd81e24e4d8b874dafaf53/sdk/python/feast/infra/offline_stores/dask.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6952/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6952/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6952/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6952/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6952/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/test_dask_created_timestamp_tiebreak.pyhttps://github.com/feast-dev/feast/pull/6952/files#diff-f0dc68b4771494036b29af2e8578c65d571b24c0a4dca59318254eeb5a776cad
View file https://github.com/LuisFigueroaG/feast/blob/7757558b38a20ac6affd81e24e4d8b874dafaf53/sdk/python/tests/unit/infra/offline_stores/test_dask_created_timestamp_tiebreak.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6952/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6952/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.