René's URL Explorer Experiment


Title: fix: Decode fixed_size_list as the matching Feast list value type by haoxu0 · Pull Request #6944 · feast-dev/feast · GitHub

Open Graph Title: fix: Decode fixed_size_list as the matching Feast list value type by haoxu0 · Pull Request #6944 · feast-dev/feast

X Title: fix: Decode fixed_size_list as the matching Feast list value type by haoxu0 · Pull Request #6944 · feast-dev/feast

Description: What this does pa_to_feast_value_type had no handling for fixed_size_list, so decoding an Arrow vector column raised a KeyError: >>> pa_to_feast_value_type("fixed_size_list[8]") KeyError: 'fixed_size_list[8]' >>> pa_to_feast_value_type("list") # variable-width worked ValueType.FLOAT_LIST Only the fixed-width spelling was affected. "fixed_size_list" not in inspect.getsource(feast.type_map) held before this change. Why it matters fixed_size_list is how Arrow-native stores spell an embedding column, and it is the type _validate_vector_field_lengths reads a width from — the validator added in #6909. So schema inference failed on exactly the columns that vector support is meant to describe. Any source whose schema inference routes through pa_to_feast_value_type is affected, not one particular store. It surfaces through get_pyarrow_schema_from_batch_source, so offline_write_batch and feast apply schema inference both hit it. Approach A Feast value type carries no width — Field.vector_length carries it — so the two spellings must agree. The fixed-width spelling is rewritten into the variable-width one and then flows through the existing list handling unchanged, which keeps that logic single-sourced rather than duplicating the element-type table. Nesting is preserved: fixed_size_list>[8] still decodes to VALUE_LIST, matching list>. Verification spelling decodes to fixed_size_list[8] FLOAT_LIST fixed_size_list[1536] DOUBLE_LIST fixed_size_list[4] INT64_LIST fixed_size_list[4] INT32_LIST fixed_size_list[2] STRING_LIST fixed_size_list[2] BOOL_LIST fixed_size_list>[8] VALUE_LIST Each is asserted equal to its variable-width counterpart, and one test pins the parser against the exact string PyArrow emits (str(pyarrow.list_(pyarrow.float32(), 8))) so the format cannot drift away unnoticed. 5 tests added. sdk/python/tests/unit/test_type_map.py: 24 failures before the change and the same 24 after, by name — all pre-existing TestSparkNativeTypeValidation cases that need pyspark. 247 passed. ruff check and ruff format --check clean.

Open Graph Description: What this does pa_to_feast_value_type had no handling for fixed_size_list, so decoding an Arrow vector column raised a KeyError: >>> pa_to_feast_value_type("fixed_size_list<item: f...

X Description: What this does pa_to_feast_value_type had no handling for fixed_size_list, so decoding an Arrow vector column raised a KeyError: &gt;&gt;&gt; pa_to_feast_value_type(&quot;fixed_size...

Opengraph URL: https://github.com/feast-dev/feast/pull/6944

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40cca035-0d75-6a62-a37a-d7ec036d3dce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBF0:19DC88:EF494F:14847E3:6AFE9883
html-safe-nonce93f15035c6dd217c3055b6188ddb34f303b8de0b96dae82480de4dfca8655d81
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkYwOjE5REM4ODpFRjQ5NEY6MTQ4NDdFMzo2QUZFOTg4MyIsInZpc2l0b3JfaWQiOiI0MzQzMDI4OTAwOTYwMzExNDI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac764e9aa62750e2b4f4771f64b32146050edcd8e65444d5e62d2aa2d0e4feacd4
hovercard-subject-tagpull_request:4750385206
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6944/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altWhat this does pa_to_feast_value_type had no handling for fixed_size_list, so decoding an Arrow vector column raised a KeyError: >>> pa_to_feast_value_type("fixed_size_list<item: f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6944/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6944%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6944%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6944/files
Reloadhttps://github.com/feast-dev/feast/pull/6944/files
Reloadhttps://github.com/feast-dev/feast/pull/6944/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
haoxu0https://github.com/haoxu0
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:fix/fixed-size-list-value-typehttps://github.com/haoxu0/feast/tree/fix/fixed-size-list-value-type
Conversation 1 https://github.com/feast-dev/feast/pull/6944
Commits 2 https://github.com/feast-dev/feast/pull/6944/commits
Checks 23 https://github.com/feast-dev/feast/pull/6944/checks
Files changed https://github.com/feast-dev/feast/pull/6944/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6944/files
fix: Decode fixed_size_list as the matching Feast list value type https://github.com/feast-dev/feast/pull/6944/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6944/files
a836c04 fix: Decode fixed_size_list as the matching Feast list value type haoxu0 Oct 5, 2026 https://github.com/feast-dev/feast/pull/6944/commits/a836c04bbe279b31c45245adee262432a5cceadb
49c4f63 Merge branch 'master' into fix/fixed-size-list-value-type haoxu0 Oct 6, 2026 https://github.com/feast-dev/feast/pull/6944/commits/49c4f632075160abfed7930ccf427aaf95896846
Clear filters https://github.com/feast-dev/feast/pull/6944/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6944/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6944/files
type_map.py https://github.com/feast-dev/feast/pull/6944/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
test_type_map.py https://github.com/feast-dev/feast/pull/6944/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/type_map.pyhttps://github.com/feast-dev/feast/pull/6944/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
View file https://github.com/haoxu0/feast/blob/49c4f632075160abfed7930ccf427aaf95896846/sdk/python/feast/type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6944/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6944/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/pull/6944/files#diff-c8d42aa830ab4d8fd6aa406e94e35664969bb39435ec15c7627ac1606fb185c0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_type_map.pyhttps://github.com/feast-dev/feast/pull/6944/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
View file https://github.com/haoxu0/feast/blob/49c4f632075160abfed7930ccf427aaf95896846/sdk/python/tests/unit/test_type_map.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6944/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6944/files#diff-7993ac6fdd117f8808587f1b4d664e8dcc71bc3749bd9ac21a714bf3db441736
Please reload this pagehttps://github.com/feast-dev/feast/pull/6944/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.