René's URL Explorer Experiment


Title: fix: Include vector attributes in Field equality by haoxu0 · Pull Request #6934 · feast-dev/feast · GitHub

Open Graph Title: fix: Include vector attributes in Field equality by haoxu0 · Pull Request #6934 · feast-dev/feast

X Title: fix: Include vector attributes in Field equality by haoxu0 · Pull Request #6934 · feast-dev/feast

Description: Addresses item 5 of #6907: Field.__eq__ ignores vector_index and vector_search_metric, so a change that alters retrieval semantics produces no diff in feast plan / apply. Why they were disabled, and why that reason is now gone I traced this before changing it. Commit 1035cd4ab from #4855: "Have to remove the equality test for the new fields...for now we're going to ignore them so it is backwards compatible" That was the right call at the time. The same commit also switched from_proto from HasField checks to getattr(field_proto, 'vector_search_metric', ''), which introduced an asymmetry: Field(name="x", dtype=String).vector_search_metric # None Field.from_proto(that.to_proto()).vector_search_metric # '' With the comparison enabled, every field lacking an explicit metric would compare unequal to its own deserialized copy — so every feast plan would report spurious changes. Commenting out the comparison was the cheap way to stop that. This PR fixes the asymmetry instead, which removes the reason for the exclusion. The normalization belongs in __init__, not from_proto My first attempt normalized from_proto. That was the wrong layer, and the test suite caught it: two tests in test_on_demand_pandas_transformation.py started failing with ValueError: The projection for scaled cannot be applied because it contains conv_rate_x10 which the FeatureView doesn't have. BaseFeatureView.with_projection checks feature not in self.features, which is this same __eq__. Instrumenting the comparison showed the two sides disagreeing on exactly one attribute: proj field: name='conv_rate_x10' idx=False len=0 metric=None <- via Field.from_proto fv field: name='conv_rate_x10' idx=False len=0 metric='' <- via another path from_proto is not the only deserialization path — OnDemandFeatureView._parse_features_from_proto builds a Field directly from a proto message and never calls it. Normalizing in __init__ makes every construction path converge, including any added later: self.vector_search_metric = vector_search_metric or None After that, both paths agree and the projection applies again. Effect COSINE vs L2 equal=False (was: silently equal) vector_index toggled equal=False (was: silently equal) round-trip equal True (backwards compatibility preserved) Testing Added to test_eq_cross_type.py, which is already the module for equality semantics: test_field_eq_includes_vector_attributes — metric change and vector_index toggle are detected test_field_survives_a_proto_round_trip — parametrized over plain / vector-without-metric / vector-with-metric; this is the backwards-compatibility guard, so it should keep passing forever test_field_normalizes_an_empty_metric_to_none — pins the __init__-level normalization, and documents why that layer rather than from_proto The first and third fail against master and pass here. 26 passed in that module. For regressions I diffed failure names across the whole unit suite rather than comparing counts, since the suite has flaky members: with this change : 41 failures master : 41 failures only with change : (none) ruff check clean, mypy feast/field.py clean. Note on item 3 of #6907 Item 3 proposed requiring vector_length when vector_index=True. I looked into it and that specific change is not viable: there are ~29 call sites declaring vector_index=True without vector_length, including Feast's own feast init -t rag and -t ray_rag templates, several examples/, and four online stores that deliberately fall back to 512. Making it mandatory would break the onboarding path. I'll follow up separately with a non-breaking alternative — rather than skipping validation when vector_length is unset, enforce internal consistency against the first row's width, which catches ragged vectors without requiring anyone to declare anything.

Open Graph Description: Addresses item 5 of #6907: Field.__eq__ ignores vector_index and vector_search_metric, so a change that alters retrieval semantics produces no diff in feast plan / apply. Why they were disabled, an...

X Description: Addresses item 5 of #6907: Field.__eq__ ignores vector_index and vector_search_metric, so a change that alters retrieval semantics produces no diff in feast plan / apply. Why they were disabled, an...

Opengraph URL: https://github.com/feast-dev/feast/pull/6934

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:30210902-8e58-67ca-1918-e903ccc2409e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CF8:DDED5:F72D09:1526B5E:6AFE9892
html-safe-nonce23e05a2096d97109f32016b1512c8195736a90a48450ba0c42aadce7a76e47d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0Y4OkRERUQ1OkY3MkQwOToxNTI2QjVFOjZBRkU5ODkyIiwidmlzaXRvcl9pZCI6Ijg0MTExNTQ3Mjg5NjgxNjU1MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdf85627fcdb8a27d0730c1d74387e855f8c7cccbb370385ab185ff2846de831d
hovercard-subject-tagpull_request:4722982583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6934/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altAddresses item 5 of #6907: Field.__eq__ ignores vector_index and vector_search_metric, so a change that alters retrieval semantics produces no diff in feast plan / apply. Why they were disabled, an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6934/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6934%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6934%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6934/files
Reloadhttps://github.com/feast-dev/feast/pull/6934/files
Reloadhttps://github.com/feast-dev/feast/pull/6934/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
haoxu0https://github.com/haoxu0
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:fix/vector-field-equalityhttps://github.com/haoxu0/feast/tree/fix/vector-field-equality
Conversation 2 https://github.com/feast-dev/feast/pull/6934
Commits 2 https://github.com/feast-dev/feast/pull/6934/commits
Checks 23 https://github.com/feast-dev/feast/pull/6934/checks
Files changed https://github.com/feast-dev/feast/pull/6934/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6934/files
fix: Include vector attributes in Field equality https://github.com/feast-dev/feast/pull/6934/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6934/files
470e640 fix: Include vector attributes in Field equality haoxu0 Oct 3, 2026 https://github.com/feast-dev/feast/pull/6934/commits/470e64045abbb60318dcedb0adc012b3e7c6e359
d84a883 Merge branch 'master' into fix/vector-field-equality haoxu0 Oct 4, 2026 https://github.com/feast-dev/feast/pull/6934/commits/d84a883e3c0bf42638055e4dd0222aac8882c9c7
Clear filters https://github.com/feast-dev/feast/pull/6934/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6934/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6934/files
field.py https://github.com/feast-dev/feast/pull/6934/files#diff-d07bc9ff25c891d1cf5359ba1bb16ce4f06a1c742193f9f37ca80f34f378c121
test_eq_cross_type.py https://github.com/feast-dev/feast/pull/6934/files#diff-6387313921f1bdb5acf6b879d7e113c24e5c594bc343d0584d7e5a3516fe770f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/field.pyhttps://github.com/feast-dev/feast/pull/6934/files#diff-d07bc9ff25c891d1cf5359ba1bb16ce4f06a1c742193f9f37ca80f34f378c121
View file https://github.com/haoxu0/feast/blob/d84a883e3c0bf42638055e4dd0222aac8882c9c7/sdk/python/feast/field.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6934/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6934/files#diff-d07bc9ff25c891d1cf5359ba1bb16ce4f06a1c742193f9f37ca80f34f378c121
https://github.com/feast-dev/feast/pull/6934/files#diff-d07bc9ff25c891d1cf5359ba1bb16ce4f06a1c742193f9f37ca80f34f378c121
https://github.com/feast-dev/feast/pull/6934/files#diff-d07bc9ff25c891d1cf5359ba1bb16ce4f06a1c742193f9f37ca80f34f378c121
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_eq_cross_type.pyhttps://github.com/feast-dev/feast/pull/6934/files#diff-6387313921f1bdb5acf6b879d7e113c24e5c594bc343d0584d7e5a3516fe770f
View file https://github.com/haoxu0/feast/blob/d84a883e3c0bf42638055e4dd0222aac8882c9c7/sdk/python/tests/unit/test_eq_cross_type.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6934/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6934/files#diff-6387313921f1bdb5acf6b879d7e113c24e5c594bc343d0584d7e5a3516fe770f
https://github.com/feast-dev/feast/pull/6934/files#diff-6387313921f1bdb5acf6b879d7e113c24e5c594bc343d0584d7e5a3516fe770f
https://github.com/feast-dev/feast/pull/6934/files#diff-6387313921f1bdb5acf6b879d7e113c24e5c594bc343d0584d7e5a3516fe770f
Please reload this pagehttps://github.com/feast-dev/feast/pull/6934/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.