René's URL Explorer Experiment


Title: fix: Do not log /metrics requests from the pre-fork metrics server thread (Gunicorn deadlock) by aborgatin · Pull Request #6929 · feast-dev/feast · GitHub

Open Graph Title: fix: Do not log /metrics requests from the pre-fork metrics server thread (Gunicorn deadlock) by aborgatin · Pull Request #6929 · feast-dev/feast

X Title: fix: Do not log /metrics requests from the pre-fork metrics server thread (Gunicorn deadlock) by aborgatin · Pull Request #6929 · feast-dev/feast

Description: What this PR does / why we need it: The metrics HTTP server runs as a thread in the Gunicorn master, which forks the workers. Its default WSGIRequestHandler writes an access-log line to stderr for every scrape. A fork while that thread holds the stderr buffer lock leaves the new worker with the lock held forever: the worker blocks on its first log line ("Booting worker") and never serves a request. Details, stacks and a reproduction in #6928 (same class of problem as #6647). This adds _QuietWSGIRequestHandler (no-op log_message, like prometheus_client's own _SilentHandler) and uses it for both the IPv4 and the dual-stack server built by _make_metrics_httpd. Scrapes are no longer written to stderr; nothing else changes. Tested on Kubernetes with --max-requests 20 and a scrape storm: 5 hangs in 318 forks before, 0 hangs in 2,000 forks after. Locally (steps in #6928): a hang after 12–29 forks before, none in 336 forks after. Which issue(s) this PR fixes: Fixes #6928 Checks I've made sure the tests are passing. (pytest sdk/python/tests/unit/test_metrics.py: 117 passed; ruff check and ruff format --check pass; mypy feast reports no errors in metrics.py) My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests – TestMetricsHttpdDoesNotLog: a request to the server built by _make_metrics_httpd writes nothing to stderr (fails before the change, passes after) Integration tests 🤖 Generated with Claude Code

Open Graph Description: What this PR does / why we need it: The metrics HTTP server runs as a thread in the Gunicorn master, which forks the workers. Its default WSGIRequestHandler writes an access-log line to stderr for ...

X Description: What this PR does / why we need it: The metrics HTTP server runs as a thread in the Gunicorn master, which forks the workers. Its default WSGIRequestHandler writes an access-log line to stderr for ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6929

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3c091c05-7260-8682-c0a4-b1b52ff4e27d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBEA:338EF9:EE4C2D:146FCFE:6AFE9883
html-safe-noncea451f571898c20febf0c352e463b82968fd53fa84b21d448b04db630170dccbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkVBOjMzOEVGOTpFRTRDMkQ6MTQ2RkNGRTo2QUZFOTg4MyIsInZpc2l0b3JfaWQiOiI2ODg5OTk3NDY4NzMwMDM4NDAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac76d289b50bd1821e8bcff5e73a393a4cfdaa33e2fb87a61813569984a338c621
hovercard-subject-tagpull_request:4715224797
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6929/files
twitter:imagehttps://avatars.githubusercontent.com/u/43031807?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43031807?s=400&v=4
og:image:altWhat this PR does / why we need it: The metrics HTTP server runs as a thread in the Gunicorn master, which forks the workers. Its default WSGIRequestHandler writes an access-log line to stderr for ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6929/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6929%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6929%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6929/files
Reloadhttps://github.com/feast-dev/feast/pull/6929/files
Reloadhttps://github.com/feast-dev/feast/pull/6929/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
aborgatin:fix/metrics-server-quiet-handlerhttps://github.com/aborgatin/feast/tree/fix/metrics-server-quiet-handler
Conversation 2 https://github.com/feast-dev/feast/pull/6929
Commits 1 https://github.com/feast-dev/feast/pull/6929/commits
Checks 1 https://github.com/feast-dev/feast/pull/6929/checks
Files changed https://github.com/feast-dev/feast/pull/6929/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6929/files
fix: Do not log /metrics requests from the pre-fork metrics server thread (Gunicorn deadlock) https://github.com/feast-dev/feast/pull/6929/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6929/files
9237fb0 fix: Do not log /metrics requests from the pre-fork metrics server th… aborgatin Oct 2, 2026 https://github.com/feast-dev/feast/pull/6929/commits/9237fb099825a080c992b3b4baaebb0de707ff87
Clear filters https://github.com/feast-dev/feast/pull/6929/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6929/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6929/files
metrics.py https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
test_metrics.py https://github.com/feast-dev/feast/pull/6929/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/metrics.pyhttps://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
View file https://github.com/aborgatin/feast/blob/9237fb099825a080c992b3b4baaebb0de707ff87/sdk/python/feast/metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6929/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6929/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_metrics.pyhttps://github.com/feast-dev/feast/pull/6929/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
View file https://github.com/aborgatin/feast/blob/9237fb099825a080c992b3b4baaebb0de707ff87/sdk/python/tests/unit/test_metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6929/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6929/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/6929/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/6929/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.